diff options
author | Dan Bornstein <danfuzz@android.com> | 2010-12-01 17:02:26 -0800 |
---|---|---|
committer | Dan Bornstein <danfuzz@android.com> | 2010-12-01 17:02:26 -0800 |
commit | 9a1f81699cc05b58378ffb9aadb4e97677943791 (patch) | |
tree | dc005d72c75a4e81a6a75ae4dd32370655ad0488 /vm/compiler/codegen/arm/FP | |
parent | 5befcb64d815614a855199e19a0236ec3a01091c (diff) | |
download | android_dalvik-9a1f81699cc05b58378ffb9aadb4e97677943791.tar.gz android_dalvik-9a1f81699cc05b58378ffb9aadb4e97677943791.tar.bz2 android_dalvik-9a1f81699cc05b58378ffb9aadb4e97677943791.zip |
It's "opcode" not "opCode".
Similarly "Opcode" not "OpCode".
This appears to be the general worldwide consensus on the matter. Other
residents of my office didn't seem to mind one way or the other how it's
spelled in our code, but for whatever reason, it really bugged me.
Change-Id: Ia0b73d19c54aefc0f543a9c9451dda22ee876a59
Diffstat (limited to 'vm/compiler/codegen/arm/FP')
-rw-r--r-- | vm/compiler/codegen/arm/FP/Thumb2VFP.c | 10 | ||||
-rw-r--r-- | vm/compiler/codegen/arm/FP/ThumbPortableFP.c | 2 | ||||
-rw-r--r-- | vm/compiler/codegen/arm/FP/ThumbVFP.c | 38 |
3 files changed, 25 insertions, 25 deletions
diff --git a/vm/compiler/codegen/arm/FP/Thumb2VFP.c b/vm/compiler/codegen/arm/FP/Thumb2VFP.c index b5bcf994e..f0a51986e 100644 --- a/vm/compiler/codegen/arm/FP/Thumb2VFP.c +++ b/vm/compiler/codegen/arm/FP/Thumb2VFP.c @@ -25,7 +25,7 @@ static bool genArithOpFloat(CompilationUnit *cUnit, MIR *mir, * Don't attempt to optimize register usage since these opcodes call out to * the handlers. */ - switch (mir->dalvikInsn.opCode) { + switch (mir->dalvikInsn.opcode) { case OP_ADD_FLOAT_2ADDR: case OP_ADD_FLOAT: op = kThumb2Vadds; @@ -66,7 +66,7 @@ static bool genArithOpDouble(CompilationUnit *cUnit, MIR *mir, int op = kThumbBkpt; RegLocation rlResult; - switch (mir->dalvikInsn.opCode) { + switch (mir->dalvikInsn.opcode) { case OP_ADD_DOUBLE_2ADDR: case OP_ADD_DOUBLE: op = kThumb2Vaddd; @@ -109,7 +109,7 @@ static bool genArithOpDouble(CompilationUnit *cUnit, MIR *mir, static bool genConversion(CompilationUnit *cUnit, MIR *mir) { - OpCode opCode = mir->dalvikInsn.opCode; + Opcode opcode = mir->dalvikInsn.opcode; int op = kThumbBkpt; bool longSrc = false; bool longDest = false; @@ -118,7 +118,7 @@ static bool genConversion(CompilationUnit *cUnit, MIR *mir) RegLocation rlDest; RegLocation rlResult; - switch (opCode) { + switch (opcode) { case OP_INT_TO_FLOAT: longSrc = false; longDest = false; @@ -213,7 +213,7 @@ static bool genCmpFP(CompilationUnit *cUnit, MIR *mir, RegLocation rlDest, int defaultResult; RegLocation rlResult; - switch(mir->dalvikInsn.opCode) { + switch(mir->dalvikInsn.opcode) { case OP_CMPL_FLOAT: isDouble = false; defaultResult = -1; diff --git a/vm/compiler/codegen/arm/FP/ThumbPortableFP.c b/vm/compiler/codegen/arm/FP/ThumbPortableFP.c index 957b4d41f..ef288ac67 100644 --- a/vm/compiler/codegen/arm/FP/ThumbPortableFP.c +++ b/vm/compiler/codegen/arm/FP/ThumbPortableFP.c @@ -57,7 +57,7 @@ static bool genCmpFP(CompilationUnit *cUnit, MIR *mir, RegLocation rlDest, * Don't attempt to optimize register usage since these opcodes call out to * the handlers. */ - switch (mir->dalvikInsn.opCode) { + switch (mir->dalvikInsn.opcode) { case OP_CMPL_FLOAT: loadValueDirectFixed(cUnit, rlSrc1, r0); loadValueDirectFixed(cUnit, rlSrc2, r1); diff --git a/vm/compiler/codegen/arm/FP/ThumbVFP.c b/vm/compiler/codegen/arm/FP/ThumbVFP.c index db940b053..9bfcd5555 100644 --- a/vm/compiler/codegen/arm/FP/ThumbVFP.c +++ b/vm/compiler/codegen/arm/FP/ThumbVFP.c @@ -65,28 +65,28 @@ static bool genArithOpFloat(CompilationUnit *cUnit, MIR *mir, RegLocation rlDest, RegLocation rlSrc1, RegLocation rlSrc2) { - TemplateOpCode opCode; + TemplateOpcode opcode; /* * Don't attempt to optimize register usage since these opcodes call out to * the handlers. */ - switch (mir->dalvikInsn.opCode) { + switch (mir->dalvikInsn.opcode) { case OP_ADD_FLOAT_2ADDR: case OP_ADD_FLOAT: - opCode = TEMPLATE_ADD_FLOAT_VFP; + opcode = TEMPLATE_ADD_FLOAT_VFP; break; case OP_SUB_FLOAT_2ADDR: case OP_SUB_FLOAT: - opCode = TEMPLATE_SUB_FLOAT_VFP; + opcode = TEMPLATE_SUB_FLOAT_VFP; break; case OP_DIV_FLOAT_2ADDR: case OP_DIV_FLOAT: - opCode = TEMPLATE_DIV_FLOAT_VFP; + opcode = TEMPLATE_DIV_FLOAT_VFP; break; case OP_MUL_FLOAT_2ADDR: case OP_MUL_FLOAT: - opCode = TEMPLATE_MUL_FLOAT_VFP; + opcode = TEMPLATE_MUL_FLOAT_VFP; break; case OP_REM_FLOAT_2ADDR: case OP_REM_FLOAT: @@ -99,7 +99,7 @@ static bool genArithOpFloat(CompilationUnit *cUnit, MIR *mir, loadValueAddressDirect(cUnit, rlDest, r0); loadValueAddressDirect(cUnit, rlSrc1, r1); loadValueAddressDirect(cUnit, rlSrc2, r2); - genDispatchToHandler(cUnit, opCode); + genDispatchToHandler(cUnit, opcode); rlDest = dvmCompilerUpdateLoc(cUnit, rlDest); if (rlDest.location == kLocPhysReg) { dvmCompilerClobber(cUnit, rlDest.lowReg); @@ -111,24 +111,24 @@ static bool genArithOpDouble(CompilationUnit *cUnit, MIR *mir, RegLocation rlDest, RegLocation rlSrc1, RegLocation rlSrc2) { - TemplateOpCode opCode; + TemplateOpcode opcode; - switch (mir->dalvikInsn.opCode) { + switch (mir->dalvikInsn.opcode) { case OP_ADD_DOUBLE_2ADDR: case OP_ADD_DOUBLE: - opCode = TEMPLATE_ADD_DOUBLE_VFP; + opcode = TEMPLATE_ADD_DOUBLE_VFP; break; case OP_SUB_DOUBLE_2ADDR: case OP_SUB_DOUBLE: - opCode = TEMPLATE_SUB_DOUBLE_VFP; + opcode = TEMPLATE_SUB_DOUBLE_VFP; break; case OP_DIV_DOUBLE_2ADDR: case OP_DIV_DOUBLE: - opCode = TEMPLATE_DIV_DOUBLE_VFP; + opcode = TEMPLATE_DIV_DOUBLE_VFP; break; case OP_MUL_DOUBLE_2ADDR: case OP_MUL_DOUBLE: - opCode = TEMPLATE_MUL_DOUBLE_VFP; + opcode = TEMPLATE_MUL_DOUBLE_VFP; break; case OP_REM_DOUBLE_2ADDR: case OP_REM_DOUBLE: @@ -142,7 +142,7 @@ static bool genArithOpDouble(CompilationUnit *cUnit, MIR *mir, loadValueAddressDirect(cUnit, rlDest, r0); loadValueAddressDirect(cUnit, rlSrc1, r1); loadValueAddressDirect(cUnit, rlSrc2, r2); - genDispatchToHandler(cUnit, opCode); + genDispatchToHandler(cUnit, opcode); rlDest = dvmCompilerUpdateLocWide(cUnit, rlDest); if (rlDest.location == kLocPhysReg) { dvmCompilerClobber(cUnit, rlDest.lowReg); @@ -153,13 +153,13 @@ static bool genArithOpDouble(CompilationUnit *cUnit, MIR *mir, static bool genConversion(CompilationUnit *cUnit, MIR *mir) { - OpCode opCode = mir->dalvikInsn.opCode; + Opcode opcode = mir->dalvikInsn.opcode; bool longSrc = false; bool longDest = false; RegLocation rlSrc; RegLocation rlDest; - TemplateOpCode template; - switch (opCode) { + TemplateOpcode template; + switch (opcode) { case OP_INT_TO_FLOAT: longSrc = false; longDest = false; @@ -226,11 +226,11 @@ static bool genConversion(CompilationUnit *cUnit, MIR *mir) static bool genCmpFP(CompilationUnit *cUnit, MIR *mir, RegLocation rlDest, RegLocation rlSrc1, RegLocation rlSrc2) { - TemplateOpCode template; + TemplateOpcode template; RegLocation rlResult = dvmCompilerGetReturn(cUnit); bool wide = true; - switch(mir->dalvikInsn.opCode) { + switch(mir->dalvikInsn.opcode) { case OP_CMPL_FLOAT: template = TEMPLATE_CMPL_FLOAT_VFP; wide = false; |