aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShinichiro Hamaji <shinichiro.hamaji@gmail.com>2016-03-17 06:02:18 +0900
committerShinichiro Hamaji <shinichiro.hamaji@gmail.com>2016-03-17 06:02:18 +0900
commitce7a2b4fdd64a1e988de0b8e173468f794899635 (patch)
treeb80b0155e88b7874ae95c554dacc73293ec45073
parent044a51d57c9db8d3aad5f1ee43f6c6d601dbfdbc (diff)
downloadandroid_build_kati-ce7a2b4fdd64a1e988de0b8e173468f794899635.tar.gz
android_build_kati-ce7a2b4fdd64a1e988de0b8e173468f794899635.tar.bz2
android_build_kati-ce7a2b4fdd64a1e988de0b8e173468f794899635.zip
Add a whitespace after an open paren for subshell
-rw-r--r--ninja.cc2
-rw-r--r--testcase/subshell_in_recipe.mk3
2 files changed, 4 insertions, 1 deletions
diff --git a/ninja.cc b/ninja.cc
index c95ee64..58d65b3 100644
--- a/ninja.cc
+++ b/ninja.cc
@@ -422,7 +422,7 @@ class NinjaGenerator {
bool needs_subshell = (command_count > 1 || c->ignore_error);
if (needs_subshell)
- *cmd_buf += '(';
+ *cmd_buf += "( ";
size_t cmd_start = cmd_buf->size();
StringPiece translated = TranslateCommand(in, cmd_buf);
diff --git a/testcase/subshell_in_recipe.mk b/testcase/subshell_in_recipe.mk
new file mode 100644
index 0000000..7578fe7
--- /dev/null
+++ b/testcase/subshell_in_recipe.mk
@@ -0,0 +1,3 @@
+test:
+ true
+ (echo PASS)