From ce7a2b4fdd64a1e988de0b8e173468f794899635 Mon Sep 17 00:00:00 2001 From: Shinichiro Hamaji Date: Thu, 17 Mar 2016 06:02:18 +0900 Subject: Add a whitespace after an open paren for subshell --- ninja.cc | 2 +- testcase/subshell_in_recipe.mk | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 testcase/subshell_in_recipe.mk diff --git a/ninja.cc b/ninja.cc index c95ee64..58d65b3 100644 --- a/ninja.cc +++ b/ninja.cc @@ -422,7 +422,7 @@ class NinjaGenerator { bool needs_subshell = (command_count > 1 || c->ignore_error); if (needs_subshell) - *cmd_buf += '('; + *cmd_buf += "( "; size_t cmd_start = cmd_buf->size(); StringPiece translated = TranslateCommand(in, cmd_buf); diff --git a/testcase/subshell_in_recipe.mk b/testcase/subshell_in_recipe.mk new file mode 100644 index 0000000..7578fe7 --- /dev/null +++ b/testcase/subshell_in_recipe.mk @@ -0,0 +1,3 @@ +test: + true + (echo PASS) -- cgit v1.2.3