diff options
| author | Tomoharu Kasahara <tomoharu.kasahara@sonyericsson.com> | 2012-02-13 14:43:41 +0900 |
|---|---|---|
| committer | Kenneth Andersson <kenneth.andersson@sonymobile.com> | 2012-09-17 14:32:10 +0200 |
| commit | 18ce3ee1ce2c2bd4f234ce97b677b0e2425bdfbe (patch) | |
| tree | 831a7de23af02130641d6afba675160f3f345a07 /src/com/android | |
| parent | 73f51a0fc5c20ee852367643527b46902f31e9bf (diff) | |
| download | platform_packages_apps_MusicFX-18ce3ee1ce2c2bd4f234ce97b677b0e2425bdfbe.tar.gz platform_packages_apps_MusicFX-18ce3ee1ce2c2bd4f234ce97b677b0e2425bdfbe.tar.bz2 platform_packages_apps_MusicFX-18ce3ee1ce2c2bd4f234ce97b677b0e2425bdfbe.zip | |
Crash when no item selected in ControlPanelPicker
mClickPos is not initialized properly and the application crashes
due to an exception when "Done" button is clicked without selecting
the item in the list.
Change-Id: If5b141ba816fcc0174ab78e557c5625130fce7d5
Diffstat (limited to 'src/com/android')
| -rw-r--r-- | src/com/android/musicfx/ControlPanelPicker.java | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/com/android/musicfx/ControlPanelPicker.java b/src/com/android/musicfx/ControlPanelPicker.java index a01fc36..bee9924 100644 --- a/src/com/android/musicfx/ControlPanelPicker.java +++ b/src/com/android/musicfx/ControlPanelPicker.java @@ -45,7 +45,6 @@ import java.util.List; public class ControlPanelPicker extends AlertActivity implements OnClickListener, OnPrepareListViewListener { - int mClickedPos = -1; @Override public void onCreate(final Bundle savedInstanceState) { @@ -97,7 +96,7 @@ public class ControlPanelPicker extends AlertActivity implements OnClickListener public void onClick(DialogInterface dialog, int which) { // Save the position of most recently clicked item - mClickedPos = which; + mAlertParams.mCheckedItem = which; } }; @@ -108,7 +107,7 @@ public class ControlPanelPicker extends AlertActivity implements OnClickListener // set new default Intent updateIntent = new Intent(this, Service.class); Cursor c = mAlertParams.mCursor; - c.moveToPosition(mClickedPos); + c.moveToPosition(mAlertParams.mCheckedItem); updateIntent.putExtra("defPackage", c.getString(2)); updateIntent.putExtra("defName", c.getString(3)); startService(updateIntent); |
