From 18ce3ee1ce2c2bd4f234ce97b677b0e2425bdfbe Mon Sep 17 00:00:00 2001 From: Tomoharu Kasahara Date: Mon, 13 Feb 2012 14:43:41 +0900 Subject: Crash when no item selected in ControlPanelPicker mClickPos is not initialized properly and the application crashes due to an exception when "Done" button is clicked without selecting the item in the list. Change-Id: If5b141ba816fcc0174ab78e557c5625130fce7d5 --- src/com/android/musicfx/ControlPanelPicker.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/com/android') diff --git a/src/com/android/musicfx/ControlPanelPicker.java b/src/com/android/musicfx/ControlPanelPicker.java index a01fc36..bee9924 100644 --- a/src/com/android/musicfx/ControlPanelPicker.java +++ b/src/com/android/musicfx/ControlPanelPicker.java @@ -45,7 +45,6 @@ import java.util.List; public class ControlPanelPicker extends AlertActivity implements OnClickListener, OnPrepareListViewListener { - int mClickedPos = -1; @Override public void onCreate(final Bundle savedInstanceState) { @@ -97,7 +96,7 @@ public class ControlPanelPicker extends AlertActivity implements OnClickListener public void onClick(DialogInterface dialog, int which) { // Save the position of most recently clicked item - mClickedPos = which; + mAlertParams.mCheckedItem = which; } }; @@ -108,7 +107,7 @@ public class ControlPanelPicker extends AlertActivity implements OnClickListener // set new default Intent updateIntent = new Intent(this, Service.class); Cursor c = mAlertParams.mCursor; - c.moveToPosition(mClickedPos); + c.moveToPosition(mAlertParams.mCheckedItem); updateIntent.putExtra("defPackage", c.getString(2)); updateIntent.putExtra("defName", c.getString(3)); startService(updateIntent); -- cgit v1.2.3