summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRahul Chaudhry <rahulchaudhry@google.com>2016-06-29 17:08:20 (GMT)
committerandroid-build-merger <android-build-merger@google.com>2016-06-29 17:08:20 (GMT)
commitab16853a21a8f41cdd4be68ff6bca140049681ea (patch)
treec5d81e8da334346e9bbc6962fc5d7d50d3d80076
parent237115ae1298fde679c81e1ba92a34e20344680f (diff)
parent850063a5c4a41433b50cc3eeac69e4285ef5129a (diff)
downloadtoolchain_binutils-ab16853a21a8f41cdd4be68ff6bca140049681ea.zip
toolchain_binutils-ab16853a21a8f41cdd4be68ff6bca140049681ea.tar.gz
toolchain_binutils-ab16853a21a8f41cdd4be68ff6bca140049681ea.tar.bz2
Revert \\\"Disable the warning of a hidden symbol matches a reference to be resolved.\\\" am: 4520d6bee1 am: fd48d3412a
am: 850063a5c4 Change-Id: I2d991e5f66a5ef98096cd4ea833da287f6e74b3b
-rw-r--r--binutils-2.25/gold/ChangeLog9
-rw-r--r--binutils-2.25/gold/resolve.cc11
2 files changed, 18 insertions, 2 deletions
diff --git a/binutils-2.25/gold/ChangeLog b/binutils-2.25/gold/ChangeLog
index c222155..cd95752 100644
--- a/binutils-2.25/gold/ChangeLog
+++ b/binutils-2.25/gold/ChangeLog
@@ -1,3 +1,12 @@
+2016-06-28 Rahul Chaudhry <rahulchaudhry@google.com>
+
+ Revert patch -- to be replaced by the upstream patch with tests.
+
+ 2015-06-16 Yiran Wang <yiran@google.com>
+
+ * resolve.cc disable the warning of a hidden symbol matches a
+ reference to be resolved
+
2016-02-05 Sriraman Tallam <tmsriram@google.com>
* icf.cc (get_rel_addend): New function.
diff --git a/binutils-2.25/gold/resolve.cc b/binutils-2.25/gold/resolve.cc
index 54de87d..07dff4a 100644
--- a/binutils-2.25/gold/resolve.cc
+++ b/binutils-2.25/gold/resolve.cc
@@ -279,8 +279,15 @@ Symbol_table::resolve(Sized_symbol<size>* to,
&& (to->visibility() == elfcpp::STV_HIDDEN
|| to->visibility() == elfcpp::STV_INTERNAL))
{
- // it is good to be helpful, but the warning leads to build error
- // for some users, so disable it if not really wanted.
+ // A dynamic object cannot reference a hidden or internal symbol
+ // defined in another object.
+ gold_warning(_("%s symbol '%s' in %s is referenced by DSO %s"),
+ (to->visibility() == elfcpp::STV_HIDDEN
+ ? "hidden"
+ : "internal"),
+ to->demangled_name().c_str(),
+ to->object()->name().c_str(),
+ object->name().c_str());
return;
}
else