summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRahul Chaudhry <rahulchaudhry@google.com>2016-06-28 21:17:59 (GMT)
committerRahul Chaudhry <rahulchaudhry@google.com>2016-06-28 22:02:59 (GMT)
commit4520d6bee11b130d3f05175db13d3000f7ecf1a8 (patch)
treec5d81e8da334346e9bbc6962fc5d7d50d3d80076
parent21efffa54e136e1b45d8016339bda25690b2b7fd (diff)
downloadtoolchain_binutils-4520d6bee11b130d3f05175db13d3000f7ecf1a8.zip
toolchain_binutils-4520d6bee11b130d3f05175db13d3000f7ecf1a8.tar.gz
toolchain_binutils-4520d6bee11b130d3f05175db13d3000f7ecf1a8.tar.bz2
Revert "Disable the warning of a hidden symbol matches a reference to be resolved."
Bug: 21502954 This change reverts https://android-review.googlesource.com/#/c/155101/, to be replaced by the upstream patch with tests. - https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=c20ceeb226168ffd84078ef74d890c2b7f69a435 Change-Id: Id929c8422a016638f860ac508eeafc7080584600
-rw-r--r--binutils-2.25/gold/ChangeLog9
-rw-r--r--binutils-2.25/gold/resolve.cc11
2 files changed, 18 insertions, 2 deletions
diff --git a/binutils-2.25/gold/ChangeLog b/binutils-2.25/gold/ChangeLog
index c222155..cd95752 100644
--- a/binutils-2.25/gold/ChangeLog
+++ b/binutils-2.25/gold/ChangeLog
@@ -1,3 +1,12 @@
+2016-06-28 Rahul Chaudhry <rahulchaudhry@google.com>
+
+ Revert patch -- to be replaced by the upstream patch with tests.
+
+ 2015-06-16 Yiran Wang <yiran@google.com>
+
+ * resolve.cc disable the warning of a hidden symbol matches a
+ reference to be resolved
+
2016-02-05 Sriraman Tallam <tmsriram@google.com>
* icf.cc (get_rel_addend): New function.
diff --git a/binutils-2.25/gold/resolve.cc b/binutils-2.25/gold/resolve.cc
index 54de87d..07dff4a 100644
--- a/binutils-2.25/gold/resolve.cc
+++ b/binutils-2.25/gold/resolve.cc
@@ -279,8 +279,15 @@ Symbol_table::resolve(Sized_symbol<size>* to,
&& (to->visibility() == elfcpp::STV_HIDDEN
|| to->visibility() == elfcpp::STV_INTERNAL))
{
- // it is good to be helpful, but the warning leads to build error
- // for some users, so disable it if not really wanted.
+ // A dynamic object cannot reference a hidden or internal symbol
+ // defined in another object.
+ gold_warning(_("%s symbol '%s' in %s is referenced by DSO %s"),
+ (to->visibility() == elfcpp::STV_HIDDEN
+ ? "hidden"
+ : "internal"),
+ to->demangled_name().c_str(),
+ to->object()->name().c_str(),
+ object->name().c_str());
return;
}
else