summaryrefslogtreecommitdiffstats
path: root/src/com
diff options
context:
space:
mode:
authorAltaf-Mahdi <altaf.mahdi@gmail.com>2014-12-14 00:30:16 +0000
committerDan Pasanen <dan.pasanen@gmail.com>2015-12-06 23:37:53 -0600
commitca7b74de9880823d33548ed1328fd2192c9ae395 (patch)
tree08760e99da0d47c56439b1e07aae56dd97a70654 /src/com
parent61f62835299b37bb7ed1a50716004047fb358624 (diff)
downloadpackages_apps_Dialer-ca7b74de9880823d33548ed1328fd2192c9ae395.tar.gz
packages_apps_Dialer-ca7b74de9880823d33548ed1328fd2192c9ae395.tar.bz2
packages_apps_Dialer-ca7b74de9880823d33548ed1328fd2192c9ae395.zip
Dialer: fix NPE in ReverseLookupService.doLookup
-also little fix in coding style Change-Id: I333c390257685fd23e1f212a95f184be0b39f0bf
Diffstat (limited to 'src/com')
-rw-r--r--src/com/android/dialer/lookup/ReverseLookupService.java9
-rw-r--r--src/com/android/dialer/lookup/opencnam/OpenCnamReverseLookup.java2
2 files changed, 7 insertions, 4 deletions
diff --git a/src/com/android/dialer/lookup/ReverseLookupService.java b/src/com/android/dialer/lookup/ReverseLookupService.java
index 25c3f4a85..fc5a2d741 100644
--- a/src/com/android/dialer/lookup/ReverseLookupService.java
+++ b/src/com/android/dialer/lookup/ReverseLookupService.java
@@ -62,14 +62,17 @@ public class ReverseLookupService implements PhoneNumberService, Handler.Callbac
return;
}
+ String countryIso = mTelephonyManager.getSimCountryIso().toUpperCase();
+ String normalizedNumber = phoneNumber != null
+ ? PhoneNumberUtils.formatNumberToE164(phoneNumber, countryIso) : null;
+
// Can't do reverse lookup without a number
- if (phoneNumber == null) {
+ if (normalizedNumber == null) {
return;
}
LookupRequest request = new LookupRequest();
- String countryIso = mTelephonyManager.getSimCountryIso().toUpperCase();
- request.normalizedNumber = PhoneNumberUtils.formatNumberToE164(phoneNumber, countryIso);
+ request.normalizedNumber = normalizedNumber;
request.formattedNumber = PhoneNumberUtils.formatNumber(phoneNumber,
request.normalizedNumber, GeoUtil.getCurrentCountryIso(mContext));
request.numberListener = numberListener;
diff --git a/src/com/android/dialer/lookup/opencnam/OpenCnamReverseLookup.java b/src/com/android/dialer/lookup/opencnam/OpenCnamReverseLookup.java
index d1fd34ef0..39854cde8 100644
--- a/src/com/android/dialer/lookup/opencnam/OpenCnamReverseLookup.java
+++ b/src/com/android/dialer/lookup/opencnam/OpenCnamReverseLookup.java
@@ -57,7 +57,7 @@ public class OpenCnamReverseLookup extends ReverseLookup {
*/
public ContactInfo lookupNumber(Context context,
String normalizedNumber, String formattedNumber) throws IOException {
- if (normalizedNumber.startsWith("+") &&!normalizedNumber.startsWith("+1")) {
+ if (normalizedNumber.startsWith("+") && !normalizedNumber.startsWith("+1")) {
// Any non-US number will return "We currently accept only US numbers"
return null;
}