summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYorke Lee <yorkelee@google.com>2015-08-07 20:09:15 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2015-08-07 20:09:15 +0000
commitef184932f32de08a6ba99ce5de3930f2a746eb95 (patch)
treec2668ed3eb9faf84fabe69b3c7d19bdd320bf9cd
parent73cb73f47906bf486ba9781734acdc14bccdecfa (diff)
parent5eb5437aff10c0c6fe63dd6e57e8ac91e3b99c98 (diff)
downloadpackages_apps_Dialer-ef184932f32de08a6ba99ce5de3930f2a746eb95.tar.gz
packages_apps_Dialer-ef184932f32de08a6ba99ce5de3930f2a746eb95.tar.bz2
packages_apps_Dialer-ef184932f32de08a6ba99ce5de3930f2a746eb95.zip
am 5eb5437a: am f118b2b8: am 26b9e56b: Correctly check for ability to write to system settings
* commit '5eb5437aff10c0c6fe63dd6e57e8ac91e3b99c98': Correctly check for ability to write to system settings
-rw-r--r--src/com/android/dialer/settings/DialerSettingsActivity.java8
-rw-r--r--src/com/android/dialer/settings/SoundSettingsFragment.java6
2 files changed, 7 insertions, 7 deletions
diff --git a/src/com/android/dialer/settings/DialerSettingsActivity.java b/src/com/android/dialer/settings/DialerSettingsActivity.java
index abf854c08..c459d35c5 100644
--- a/src/com/android/dialer/settings/DialerSettingsActivity.java
+++ b/src/com/android/dialer/settings/DialerSettingsActivity.java
@@ -91,10 +91,10 @@ public class DialerSettingsActivity extends PreferenceActivity {
@Override
public void onHeaderClick(Header header, int position) {
if (header.id == R.id.settings_header_sounds_and_vibration) {
- // If we don't have the AppOp to write to system settings, go to system sound settings
- // instead. Otherwise, perform the super implementation (which launches our own
- // preference fragment.
- if (!PermissionsUtil.hasAppOp(this, AppOpsManager.OPSTR_WRITE_SETTINGS)) {
+ // If we don't have the permission to write to system settings, go to system sound
+ // settings instead. Otherwise, perform the super implementation (which launches our
+ // own preference fragment.
+ if (!Settings.System.canWrite(this)) {
Toast.makeText(
this,
getResources().getString(R.string.toast_cannot_write_system_settings),
diff --git a/src/com/android/dialer/settings/SoundSettingsFragment.java b/src/com/android/dialer/settings/SoundSettingsFragment.java
index 1dedcaaff..83847004d 100644
--- a/src/com/android/dialer/settings/SoundSettingsFragment.java
+++ b/src/com/android/dialer/settings/SoundSettingsFragment.java
@@ -132,7 +132,7 @@ public class SoundSettingsFragment extends PreferenceFragment
public void onResume() {
super.onResume();
- if (!PermissionsUtil.hasAppOp(getContext(), AppOpsManager.OPSTR_WRITE_SETTINGS)) {
+ if (!Settings.System.canWrite(getContext())) {
// If the user launches this setting fragment, then toggles the WRITE_SYSTEM_SETTINGS
// AppOp, then close the fragment since there is nothing useful to do.
getActivity().onBackPressed();
@@ -155,7 +155,7 @@ public class SoundSettingsFragment extends PreferenceFragment
*/
@Override
public boolean onPreferenceChange(Preference preference, Object objValue) {
- if (!PermissionsUtil.hasAppOp(getContext(), AppOpsManager.OPSTR_WRITE_SETTINGS)) {
+ if (!Settings.System.canWrite(getContext())) {
// A user shouldn't be able to get here, but this protects against monkey crashes.
Toast.makeText(
getContext(),
@@ -181,7 +181,7 @@ public class SoundSettingsFragment extends PreferenceFragment
*/
@Override
public boolean onPreferenceTreeClick(PreferenceScreen preferenceScreen, Preference preference) {
- if (!PermissionsUtil.hasAppOp(getContext(), AppOpsManager.OPSTR_WRITE_SETTINGS)) {
+ if (!Settings.System.canWrite(getContext())) {
Toast.makeText(
getContext(),
getResources().getString(R.string.toast_cannot_write_system_settings),