summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoonas Kylmälä <joonas.kylmala@iki.fi>2019-10-27 16:15:26 +0200
committerDenis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>2020-11-29 04:14:51 +0100
commit97a31d224e76512a8fbaf48d3ebecb18a3517f7a (patch)
tree861228ecd00c2625f117de5bdc1eaecd520b1283
parenta245d5701b0452145b2a813464fa2f1fec74fddd (diff)
downloadpackages_apps_Dialer-97a31d224e76512a8fbaf48d3ebecb18a3517f7a.tar.gz
packages_apps_Dialer-97a31d224e76512a8fbaf48d3ebecb18a3517f7a.tar.bz2
packages_apps_Dialer-97a31d224e76512a8fbaf48d3ebecb18a3517f7a.zip
When the phone number lookup settings were enabled the app was leaking private information. To prevent that, the following commits in vendor/cmsdk disabled it by default and made sure that the settings were switched back to disabled: de9e5b0 Disable phone number lookup by default for privacy 2d8ae47 Disable phone number lookup settings during upgrade This change removes the phone number lookup service from the graphical interface as well. If we wouldn't remove it then users could still enable it without understanding that it leaks private information to third parties. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Acked-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> GNUtoo: rebased Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
-rw-r--r--src/com/android/dialer/settings/DialerSettingsActivity.java6
1 files changed, 0 insertions, 6 deletions
diff --git a/src/com/android/dialer/settings/DialerSettingsActivity.java b/src/com/android/dialer/settings/DialerSettingsActivity.java
index 35ab02f10..b49d4aec4 100644
--- a/src/com/android/dialer/settings/DialerSettingsActivity.java
+++ b/src/com/android/dialer/settings/DialerSettingsActivity.java
@@ -59,12 +59,6 @@ public class DialerSettingsActivity extends PreferenceActivity {
TelephonyManager telephonyManager =
(TelephonyManager) getSystemService(Context.TELEPHONY_SERVICE);
- final Header lookupSettingsHeader = new Header();
- lookupSettingsHeader.titleRes = R.string.lookup_settings_label;
- lookupSettingsHeader.summaryRes = R.string.lookup_settings_description;
- lookupSettingsHeader.fragment = LookupSettingsFragment.class.getName();
- target.add(lookupSettingsHeader);
-
// Only show call setting menus if the current user is the primary/owner user.
if (isPrimaryUser()) {
// Show "Call Settings" if there is one SIM and "Phone Accounts" if there are more.