Move list adapter creation from onCreateView to onCreate

Create the fragment's list adapter in onCreate, instead of onCreateView, which
can be called multiple times in the fragment's lifecycle. This fixes a crash in
Dialer where ContactEntryListFragments can be swapped out repeatedly multiple
times, and creating a new adapter each time causes problems.

Bug: 11014225
Change-Id: I37b4adc9606f7b25c444b2230081540320b34c17

1 files changed, 1 insertions, 2 deletions

diff --git a/src/com/android/contacts/common/list/ContactEntryListFragment.java b/src/com/android/contacts/common/list/ContactEntryListFragment.java
index f7f555a1..8df8571d 100644
--- a/src/com/android/contacts/common/list/ContactEntryListFragment.java
+++ b/src/com/android/contacts/common/list/ContactEntryListFragment.java
@@ -243,6 +243,7 @@ public abstract class ContactEntryListFragment<T extends ContactEntryListAdapter
     @Override
     public void onCreate(Bundle savedState) {
         super.onCreate(savedState);
+        mAdapter = createListAdapter();
         mContactsPrefs = new ContactsPreferences(mContext);
         restoreSavedState(savedState);
     }
@@ -692,8 +693,6 @@ public abstract class ContactEntryListFragment<T extends ContactEntryListAdapter
             Bundle savedInstanceState) {
         onCreateView(inflater, container);
 
-        mAdapter = createListAdapter();
-
         boolean searchMode = isSearchMode();
         mAdapter.setSearchMode(searchMode);
         mAdapter.configureDefaultPartition(false, searchMode);