diff options
Diffstat (limited to 'src/com/android/browser/BrowserHistoryPage.java')
| -rw-r--r-- | src/com/android/browser/BrowserHistoryPage.java | 24 |
1 files changed, 15 insertions, 9 deletions
diff --git a/src/com/android/browser/BrowserHistoryPage.java b/src/com/android/browser/BrowserHistoryPage.java index 57ea87990..0c2bfae75 100644 --- a/src/com/android/browser/BrowserHistoryPage.java +++ b/src/com/android/browser/BrowserHistoryPage.java @@ -131,7 +131,12 @@ public class BrowserHistoryPage extends ExpandableListActivity { false); CombinedBookmarkHistoryActivity.getIconListenerSet() .addListener(mIconReceiver); - + Activity parent = getParent(); + if (null == parent + || !(parent instanceof CombinedBookmarkHistoryActivity)) { + throw new AssertionError("history page can only be viewed as a tab" + + "in CombinedBookmarkHistoryActivity"); + } // initialize the result to canceled, so that if the user just presses // back then it will have the correct result setResultToParent(RESULT_CANCELED, null); @@ -162,9 +167,11 @@ public class BrowserHistoryPage extends ExpandableListActivity { public boolean onOptionsItemSelected(MenuItem item) { switch (item.getItemId()) { case R.id.clear_history_menu_id: - // FIXME: Need to clear the tab control in browserActivity - // as well Browser.clearHistory(getContentResolver()); + // BrowserHistoryPage is always a child of + // CombinedBookmarkHistoryActivity + ((CombinedBookmarkHistoryActivity) getParent()) + .removeParentChildRelationShips(); mAdapter.refreshData(); return true; @@ -272,13 +279,12 @@ public class BrowserHistoryPage extends ExpandableListActivity { return false; } - // This Activity is generally a sub-Activity of CombinedHistoryActivity. In - // that situation, we need to pass our result code up to our parent. - // However, if someone calls this Activity directly, then this has no - // parent, and it needs to set it on itself. + // This Activity is always a sub-Activity of + // CombinedBookmarkHistoryActivity. Therefore, we need to pass our + // result code up to our parent. private void setResultToParent(int resultCode, Intent data) { - Activity a = getParent() == null ? this : getParent(); - a.setResult(resultCode, data); + ((CombinedBookmarkHistoryActivity) getParent()).setResultFromChild( + resultCode, data); } private class ChangeObserver extends ContentObserver { |
