diff options
| author | John Reck <jreck@google.com> | 2011-10-31 11:28:30 -0700 |
|---|---|---|
| committer | John Reck <jreck@google.com> | 2011-10-31 11:28:30 -0700 |
| commit | 868efdf4ad75e35f45d129532ccaa935a0ee28ad (patch) | |
| tree | d0dd259f2168b2ec1fd88f8f09efcb328c8bdafc /src/com/android/browser/UrlBarAutoShowManager.java | |
| parent | d7383a28ac34ba7379e6ec733e9c5397baf4a293 (diff) | |
| download | packages_apps_Browser-868efdf4ad75e35f45d129532ccaa935a0ee28ad.tar.gz packages_apps_Browser-868efdf4ad75e35f45d129532ccaa935a0ee28ad.tar.bz2 packages_apps_Browser-868efdf4ad75e35f45d129532ccaa935a0ee28ad.zip | |
Fix corner case with url pulldown
Bug: 5534329
The issue is that with 1px visible of the title bar the url
pulldown code wouldn't trigger to prevent a janky animation.
Detect whether or not the page is scrolling, and if it isn't
then show the url bar even if it is partially visible
Change-Id: I2e7771f0e08a7dc9a6d3968e2d5e1402b1a454fa
Diffstat (limited to 'src/com/android/browser/UrlBarAutoShowManager.java')
| -rw-r--r-- | src/com/android/browser/UrlBarAutoShowManager.java | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/com/android/browser/UrlBarAutoShowManager.java b/src/com/android/browser/UrlBarAutoShowManager.java index f1bbe7f01..294115e7f 100644 --- a/src/com/android/browser/UrlBarAutoShowManager.java +++ b/src/com/android/browser/UrlBarAutoShowManager.java @@ -46,6 +46,7 @@ public class UrlBarAutoShowManager implements OnTouchListener, private boolean mHasTriggered; private long mLastScrollTime; private long mTriggeredTime; + private boolean mIsScrolling; public UrlBarAutoShowManager(BaseUi ui) { mUi = ui; @@ -71,6 +72,7 @@ public class UrlBarAutoShowManager implements OnTouchListener, public void onScrollChanged(int l, int t, int oldl, int oldt) { mLastScrollTime = SystemClock.uptimeMillis(); if (t != oldt) { + mIsScrolling = true; if (t != 0) { // If it is showing, extend it if (mUi.isTitleBarShowing()) { @@ -88,6 +90,7 @@ public class UrlBarAutoShowManager implements OnTouchListener, void stopTracking() { if (mIsTracking) { mIsTracking = false; + mIsScrolling = false; if (mUi.isTitleBarShowing()) { mUi.showTitleBarForDuration(); } @@ -124,7 +127,8 @@ public class UrlBarAutoShowManager implements OnTouchListener, float angle = (float) Math.atan2(ady, adx); if (dy > mSlop && angle > V_TRIGGER_ANGLE && !mUi.isTitleBarShowing() - && web.getVisibleTitleHeight() == 0) { + && (web.getVisibleTitleHeight() == 0 + || (!mIsScrolling && web.getScrollY() > 0))) { mTriggeredTime = SystemClock.uptimeMillis(); mUi.showTitleBar(); } |
