diff options
| author | Bryan Buckley <bryan.buckley@ti.com> | 2011-10-12 11:52:13 -0500 |
|---|---|---|
| committer | Ziyann <jaraidaniel@gmail.com> | 2014-10-01 12:56:09 +0200 |
| commit | b2c474234ead0b81b5e0c4786969dc6c0d8a772e (patch) | |
| tree | d27bfedc3832dc46c55310cd02e95271708351d6 /security | |
| parent | 1be6648691fe4b1fce2f01df0953a3abe19987e1 (diff) | |
| download | kernel_samsung_tuna-b2c474234ead0b81b5e0c4786969dc6c0d8a772e.tar.gz kernel_samsung_tuna-b2c474234ead0b81b5e0c4786969dc6c0d8a772e.tar.bz2 kernel_samsung_tuna-b2c474234ead0b81b5e0c4786969dc6c0d8a772e.zip | |
OMAP4: SMC: Fix two compiler warnings in security/smc/tf_comm.c
security/smc/tf_comm.c: In function 'tf_fill_descriptor_table':
security/smc/tf_comm.c:835: warning: ISO C90 forbids mixed
declarations and code
security/smc/tf_comm.c:918: warning: 'error' may be used uninitialized
in this function
security/smc/tf_comm.c:645: note: 'error' was declared here
Moved declaration of "struct page *page" to beginning of functional block.
Ensure 'error' gets set correctly and never reports a false negative.
Change-Id: Icbb10298eb5da9b455ede587195a0a7a16feef13
Signed-off-by: Bryan Buckley <bryan.buckley@ti.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/smc/tf_comm.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/security/smc/tf_comm.c b/security/smc/tf_comm.c index 79b40348748..451e63ee678 100644 --- a/security/smc/tf_comm.c +++ b/security/smc/tf_comm.c @@ -822,6 +822,7 @@ int tf_fill_descriptor_table( for (j = page_shift; j < pages_to_get; j++) { + struct page *page; void *addr = (void *)(buffer_offset_vaddr + (j - page_shift) * PAGE_SIZE); @@ -830,14 +831,16 @@ int tf_fill_descriptor_table( "tf_fill_descriptor_table: " "cannot handle address %p\n", addr); + error = -EFAULT; goto error; } - struct page *page = vmalloc_to_page(addr); + page = vmalloc_to_page(addr); if (page == NULL) { dprintk(KERN_ERR "tf_fill_descriptor_table: " "cannot map %p to page\n", addr); + error = -ENOMEM; goto error; } coarse_pg_table->descriptors[j] = (u32)page; |