diff options
author | Jan Kara <jack@suse.cz> | 2011-12-08 21:13:46 +0100 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-21 09:40:04 -0700 |
commit | 8e8a21270cbfc41bf3bf2e014b99dc113ba554ec (patch) | |
tree | 12d5b48c6b64f63e8017c3c7036fd71dca4fccf0 /fs/ext3 | |
parent | 5c17daa89308cc028fe336af58cf9d4e4d83298d (diff) | |
download | kernel_samsung_smdk4412-8e8a21270cbfc41bf3bf2e014b99dc113ba554ec.tar.gz kernel_samsung_smdk4412-8e8a21270cbfc41bf3bf2e014b99dc113ba554ec.tar.bz2 kernel_samsung_smdk4412-8e8a21270cbfc41bf3bf2e014b99dc113ba554ec.zip |
ext3: Fix error handling on inode bitmap corruption
commit 1415dd8705394399d59a3df1ab48d149e1e41e77 upstream.
When insert_inode_locked() fails in ext3_new_inode() it most likely
means inode bitmap got corrupted and we allocated again inode which
is already in use. Also doing unlock_new_inode() during error recovery
is wrong since inode does not have I_NEW set. Fix the problem by jumping
to fail: (instead of fail_drop:) which declares filesystem error and
does not call unlock_new_inode().
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext3')
-rw-r--r-- | fs/ext3/ialloc.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/fs/ext3/ialloc.c b/fs/ext3/ialloc.c index bfc2dc43681..0b3da7cc8ab 100644 --- a/fs/ext3/ialloc.c +++ b/fs/ext3/ialloc.c @@ -561,8 +561,12 @@ got: if (IS_DIRSYNC(inode)) handle->h_sync = 1; if (insert_inode_locked(inode) < 0) { - err = -EINVAL; - goto fail_drop; + /* + * Likely a bitmap corruption causing inode to be allocated + * twice. + */ + err = -EIO; + goto fail; } spin_lock(&sbi->s_next_gen_lock); inode->i_generation = sbi->s_next_generation++; |