diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-02-11 22:03:18 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-14 11:32:04 -0700 |
| commit | c9ad62366468c20381217476c1ebc5cc13ffcbbc (patch) | |
| tree | 217fdb5824098505ec391f7a2175207fd70e02b9 /drivers/scsi | |
| parent | 8b0b58069148d9540e70af1d4963b2fe515efe89 (diff) | |
| download | kernel_samsung_smdk4412-c9ad62366468c20381217476c1ebc5cc13ffcbbc.tar.gz kernel_samsung_smdk4412-c9ad62366468c20381217476c1ebc5cc13ffcbbc.tar.bz2 kernel_samsung_smdk4412-c9ad62366468c20381217476c1ebc5cc13ffcbbc.zip | |
SCSI: dc395x: uninitialized variable in device_alloc()
commit 208afec4f3be8c51ad6eebe6611dd6d2ad2fa298 upstream.
This bug was introduced back in bitkeeper days in 2003. We use
"dcb->dev_mode" before it has been initialized.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/dc395x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index f5b718d3c31..aed7756bdbc 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -3747,13 +3747,13 @@ static struct DeviceCtlBlk *device_alloc(struct AdapterCtlBlk *acb, dcb->max_command = 1; dcb->target_id = target; dcb->target_lun = lun; + dcb->dev_mode = eeprom->target[target].cfg0; #ifndef DC395x_NO_DISCONNECT dcb->identify_msg = IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun); #else dcb->identify_msg = IDENTIFY(0, lun); #endif - dcb->dev_mode = eeprom->target[target].cfg0; dcb->inquiry7 = 0; dcb->sync_mode = 0; dcb->min_nego_period = clock_period[period_index]; |