diff options
| author | Shane Huang <shane.huang@amd.com> | 2013-06-08 16:00:16 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-07-21 18:14:41 -0700 |
| commit | b53a038e4d4e68ebbee7eddbd9c8793d75c5fe3f (patch) | |
| tree | 2fc2cf3e9c7af59d5b7d7fcb35f804e944ea9489 /drivers/ata | |
| parent | 5e9516f6d5f1f24e8b4f0327caf3d197400d3c1e (diff) | |
| download | kernel_samsung_smdk4412-b53a038e4d4e68ebbee7eddbd9c8793d75c5fe3f.tar.gz kernel_samsung_smdk4412-b53a038e4d4e68ebbee7eddbd9c8793d75c5fe3f.tar.bz2 kernel_samsung_smdk4412-b53a038e4d4e68ebbee7eddbd9c8793d75c5fe3f.zip | |
ahci: remove pmp link online check in FBS EH
commit 912b9ac683b112615d5605686f1dc086402ce9f7 upstream.
ata_link_online() check in ahci_error_intr() is unnecessary, it should
be removed otherwise may lead to lockup with FBS enabled PMP.
http://marc.info/?l=linux-ide&m=137050421603272&w=2
Reported-by: Yu Liu <liuyu.ac@gmail.com>
Signed-off-by: Shane Huang <shane.huang@amd.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libahci.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index 41223c7f020..b64e4a7260a 100644 --- a/drivers/ata/libahci.c +++ b/drivers/ata/libahci.c @@ -1495,8 +1495,7 @@ static void ahci_error_intr(struct ata_port *ap, u32 irq_stat) u32 fbs = readl(port_mmio + PORT_FBS); int pmp = fbs >> PORT_FBS_DWE_OFFSET; - if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links) && - ata_link_online(&ap->pmp_link[pmp])) { + if ((fbs & PORT_FBS_SDE) && (pmp < ap->nr_pmp_links)) { link = &ap->pmp_link[pmp]; fbs_need_dec = true; } |