diff options
| author | Joe Perches <joe@perches.com> | 2010-03-05 13:43:48 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-03-06 11:26:44 -0800 |
| commit | 8f53a9b80f011080555c498d2ca2dc6b1a77c42c (patch) | |
| tree | b4636535f12817c107ba8fc1932882984eee9e46 | |
| parent | 849382948992cc6482c778b1e854c19368b60c05 (diff) | |
| download | kernel_samsung_smdk4412-8f53a9b80f011080555c498d2ca2dc6b1a77c42c.tar.gz kernel_samsung_smdk4412-8f53a9b80f011080555c498d2ca2dc6b1a77c42c.tar.bz2 kernel_samsung_smdk4412-8f53a9b80f011080555c498d2ca2dc6b1a77c42c.zip | |
scripts/checkpatch.pl: add WARN on sizeof(&foo)
sizeof(&foo) is frequently an error. Warn on its use.
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3257d3d9676..309050f3087 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2572,6 +2572,11 @@ sub process { WARN("plain inline is preferred over $1\n" . $herecurr); } +# check for sizeof(&) + if ($line =~ /\bsizeof\s*\(\s*\&/) { + WARN("sizeof(& should be avoided\n" . $herecurr); + } + # check for new externs in .c files. if ($realfile =~ /\.c$/ && defined $stat && $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |