aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSasha Levin <sasha.levin@oracle.com>2015-01-23 20:47:00 -0500
committerBrett Rogers <brettrogers11@gmail.com>2016-02-22 16:35:15 -0800
commit2acd51f51ffd6e14b24d812da47594f53d917378 (patch)
tree08e148cb12eba2811720bec61bc654c870500539
parent6a5c4b88f9d9d3e985c9503af7cbcab0454b0887 (diff)
downloadkernel_samsung_smdk4412-2acd51f51ffd6e14b24d812da47594f53d917378.tar.gz
kernel_samsung_smdk4412-2acd51f51ffd6e14b24d812da47594f53d917378.tar.bz2
kernel_samsung_smdk4412-2acd51f51ffd6e14b24d812da47594f53d917378.zip
net: llc: use correct size for sysctl timeout entries
The timeout entries are sizeof(int) rather than sizeof(long), which means that when they were getting read we'd also leak kernel memory to userspace along with the timeout values. Change-Id: I65ab7dc468480dca04108e077194735fa9dc61b5 Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/llc/sysctl_net_llc.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/net/llc/sysctl_net_llc.c b/net/llc/sysctl_net_llc.c
index e2ebe358626..be078ec43d7 100644
--- a/net/llc/sysctl_net_llc.c
+++ b/net/llc/sysctl_net_llc.c
@@ -17,28 +17,28 @@ static struct ctl_table llc2_timeout_table[] = {
{
.procname = "ack",
.data = &sysctl_llc2_ack_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_ack_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "busy",
.data = &sysctl_llc2_busy_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_busy_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "p",
.data = &sysctl_llc2_p_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_p_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
{
.procname = "rej",
.data = &sysctl_llc2_rej_timeout,
- .maxlen = sizeof(long),
+ .maxlen = sizeof(sysctl_llc2_rej_timeout),
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},