diff options
| author | Paul Kot <pawlkt@gmail.com> | 2013-03-19 12:36:49 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-04-05 10:16:38 -0700 |
| commit | 19c0a0f3f768551fc708ebc9b2345e5dcc248d3a (patch) | |
| tree | 7e10de90b01798dfc658328e503d8c436891fe7f /net/batman-adv | |
| parent | 7f3ea0c12493c9ff38a13a89bcf08846b50c1f1c (diff) | |
| download | kernel_samsung_espresso10-19c0a0f3f768551fc708ebc9b2345e5dcc248d3a.tar.gz kernel_samsung_espresso10-19c0a0f3f768551fc708ebc9b2345e5dcc248d3a.tar.bz2 kernel_samsung_espresso10-19c0a0f3f768551fc708ebc9b2345e5dcc248d3a.zip | |
batman-adv: bat_socket_read missing checks
commit c00b6856fc642b234895cfabd15b289e76726430 upstream.
Writing a icmp_packet_rr and then reading icmp_packet can lead to kernel
memory corruption, if __user *buf is just below TASK_SIZE.
Signed-off-by: Paul Kot <pawlkt@gmail.com>
[sven@narfation.org: made it checkpatch clean]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/batman-adv')
| -rw-r--r-- | net/batman-adv/icmp_socket.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c index fa22ba2bb83..88c310aacc4 100644 --- a/net/batman-adv/icmp_socket.c +++ b/net/batman-adv/icmp_socket.c @@ -136,8 +136,8 @@ static ssize_t bat_socket_read(struct file *file, char __user *buf, spin_unlock_bh(&socket_client->lock); - error = __copy_to_user(buf, &socket_packet->icmp_packet, - socket_packet->icmp_len); + error = copy_to_user(buf, &socket_packet->icmp_packet, + socket_packet->icmp_len); packet_len = socket_packet->icmp_len; kfree(socket_packet); |