diff options
| author | Emilian Peev <epeev@mm-sol.com> | 2012-05-21 12:38:23 +0300 |
|---|---|---|
| committer | Eino-Ville Talvala <etalvala@google.com> | 2012-05-23 14:38:01 -0700 |
| commit | c78626b15e9f29a5bcf85447ceafb17dcbf58b69 (patch) | |
| tree | b6fcc502eceb58bfda03fcc60f597ce121b56585 /camera/OMXCameraAdapter/OMXAlgo.cpp | |
| parent | 8fa731ddc4e629880eda7f1f69de4fc4556cb7cb (diff) | |
| download | hardware_ti_omap4xxx-c78626b15e9f29a5bcf85447ceafb17dcbf58b69.tar.gz hardware_ti_omap4xxx-c78626b15e9f29a5bcf85447ceafb17dcbf58b69.tar.bz2 hardware_ti_omap4xxx-c78626b15e9f29a5bcf85447ceafb17dcbf58b69.zip | |
CameraHal: Avoids possible race conditions while accessing 'mParams'
- Direct access of 'mParams' outside of 'get-/setParameters()' should
be avoided. The underlying strings can get invalidated with each
call to 'setParameters()', which can lead to instabilities.
- This change also removes legacy stereo code, which is not used
any more.
Bug: 6509329
Change-Id: Ief6df206c33fbdc666644cea8630e0bce6a36c00
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Diffstat (limited to 'camera/OMXCameraAdapter/OMXAlgo.cpp')
| -rw-r--r-- | camera/OMXCameraAdapter/OMXAlgo.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/camera/OMXCameraAdapter/OMXAlgo.cpp b/camera/OMXCameraAdapter/OMXAlgo.cpp index ff68cc9..12b9058 100644 --- a/camera/OMXCameraAdapter/OMXAlgo.cpp +++ b/camera/OMXCameraAdapter/OMXAlgo.cpp @@ -641,10 +641,10 @@ status_t OMXCameraAdapter::setCaptureMode(OMXCameraAdapter::CaptureMode mode) CAMHAL_LOGDA("Camera mode: HIGH QUALITY_ZSL"); camMode.eCamOperatingMode = OMX_TI_CaptureImageProfileZeroShutterLag; - valstr = mParams.get(TICameraParameters::KEY_RECORDING_HINT); - if (!valstr || (valstr && (strcmp(valstr, "false")))) { + if ( !mIternalRecordingHint ) { zslHistoryLen.nHistoryLen = 5; } + } else if( OMXCameraAdapter::VIDEO_MODE == mode ) { |