aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorGordon Henriksen <gordonhenriksen@mac.com>2007-09-18 10:14:30 +0000
committerGordon Henriksen <gordonhenriksen@mac.com>2007-09-18 10:14:30 +0000
commitbb7de29398f27537779783bc31bc98d6769ee5e4 (patch)
tree44912cdd27db22e564a25a5ef0a44bfe16901b77 /lib
parente9ecdcfe0a818c27fd1767301c8d8e988d96be87 (diff)
downloadexternal_llvm-bb7de29398f27537779783bc31bc98d6769ee5e4.tar.gz
external_llvm-bb7de29398f27537779783bc31bc98d6769ee5e4.tar.bz2
external_llvm-bb7de29398f27537779783bc31bc98d6769ee5e4.zip
Incorporating review feedback for GC verifier patch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@42087 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r--lib/VMCore/Verifier.cpp16
1 files changed, 5 insertions, 11 deletions
diff --git a/lib/VMCore/Verifier.cpp b/lib/VMCore/Verifier.cpp
index 25826e106c..982de30b72 100644
--- a/lib/VMCore/Verifier.cpp
+++ b/lib/VMCore/Verifier.cpp
@@ -49,8 +49,7 @@
#include "llvm/ParameterAttributes.h"
#include "llvm/DerivedTypes.h"
#include "llvm/InlineAsm.h"
-#include "llvm/Instructions.h"
-#include "llvm/Intrinsics.h"
+#include "llvm/IntrinsicInst.h"
#include "llvm/PassManager.h"
#include "llvm/Analysis/Dominators.h"
#include "llvm/CodeGen/ValueTypes.h"
@@ -1078,12 +1077,6 @@ static bool HasPtrPtrType(Value *Val) {
return false;
}
-static Value *StripBitCasts(Value *Val) {
- if (BitCastInst *CI = dyn_cast<BitCastInst>(Val))
- return StripBitCasts(CI->getOperand(0));
- return Val;
-}
-
/// visitIntrinsicFunction - Allow intrinsics to be verified in different ways.
///
void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
@@ -1101,10 +1094,11 @@ void Verifier::visitIntrinsicFunctionCall(Intrinsic::ID ID, CallInst &CI) {
case Intrinsic::gcroot:
Assert1(HasPtrPtrType(CI.getOperand(1)),
"llvm.gcroot parameter #1 must be a pointer to a pointer.", &CI);
- Assert1(isa<AllocaInst>(StripBitCasts(CI.getOperand(1))),
- "llvm.gcroot parameter #1 must be an alloca (or a bitcast).", &CI);
+ Assert1(isa<AllocaInst>(IntrinsicInst::StripPointerCasts(CI.getOperand(1))),
+ "llvm.gcroot parameter #1 must be an alloca (or a bitcast of one).",
+ &CI);
Assert1(isa<Constant>(CI.getOperand(2)),
- "llvm.gcroot parameter #2 must be a constant or global.", &CI);
+ "llvm.gcroot parameter #2 must be a constant.", &CI);
break;
case Intrinsic::gcwrite:
Assert1(CI.getOperand(3)->getType()