aboutsummaryrefslogtreecommitdiffstats
path: root/lib/Support/MemoryBuffer.cpp
diff options
context:
space:
mode:
authorHal Finkel <hfinkel@anl.gov>2013-07-15 20:22:58 +0000
committerHal Finkel <hfinkel@anl.gov>2013-07-15 20:22:58 +0000
commitae4f3f6820c28a4ba4fab538f5ff4724cbe82d50 (patch)
tree7815a877e91583d63bfc0d5a2c75289ef9bcdac5 /lib/Support/MemoryBuffer.cpp
parent6057eb7ab697fcd0feb3cdd55e9a497cfe0aff72 (diff)
downloadexternal_llvm-ae4f3f6820c28a4ba4fab538f5ff4724cbe82d50.tar.gz
external_llvm-ae4f3f6820c28a4ba4fab538f5ff4724cbe82d50.tar.bz2
external_llvm-ae4f3f6820c28a4ba4fab538f5ff4724cbe82d50.zip
Fix register subclass handling in PPCInstrInfo::insertSelect
PPCInstrInfo::insertSelect and PPCInstrInfo::canInsertSelect were computing the common subclass of the true and false inputs, and then selecting either the 32-bit or the 64-bit isel variant based on the result of calling PPC::GPRCRegClass.hasSubClassEq(RC) and PPC::G8RCRegClass.hasSubClassEq(RC) (where RC is the common subclass). Unfortunately, this is not quite right: if we have something like this: %vreg8<def> = SELECT_CC_I8 %vreg4<kill>, %vreg7<kill>, %vreg6<kill>, 76; G8RC_and_G8RC_NOX0:%vreg8 CRRC:%vreg4 G8RC_NOX0:%vreg7,%vreg6 then the common subclass of G8RC_and_G8RC_NOX0 and G8RC_NOX0 is G8RC_NOX0, and G8RC_NOX0 is not a subclass of G8RC (because it also contains the ZERO8 pseudo-register). As a result, we also need to check the common subclass against GPRC_NOR0 and G8RC_NOX0 explicitly. This had not been a problem for clients of insertSelect that called canInsertSelect first (because it had a compensating mistake), but insertSelect is also used by the PPC pseudo-instruction expander, and this error was causing a problem in that context. This problem was found by csmith. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186343 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/MemoryBuffer.cpp')
0 files changed, 0 insertions, 0 deletions