aboutsummaryrefslogtreecommitdiffstats
path: root/lib/Support/APFloat.cpp
diff options
context:
space:
mode:
authorTed Kremenek <kremenek@apple.com>2013-08-28 06:21:46 +0000
committerTed Kremenek <kremenek@apple.com>2013-08-28 06:21:46 +0000
commit900617094505bba1fcf4d29c54901f48a0dacfa5 (patch)
tree1fa5cfc66e7fd32070de6a795ea09e81e1200cd7 /lib/Support/APFloat.cpp
parent631bce51b962df5f4821dfd4f91599d3f7ba05f9 (diff)
downloadexternal_llvm-900617094505bba1fcf4d29c54901f48a0dacfa5.tar.gz
external_llvm-900617094505bba1fcf4d29c54901f48a0dacfa5.tar.bz2
external_llvm-900617094505bba1fcf4d29c54901f48a0dacfa5.zip
Revert r189442 "Change default # of digits for APFloat::toString"
This is breaking numerous Clang tests on the buildbot. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189447 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Support/APFloat.cpp')
-rw-r--r--lib/Support/APFloat.cpp13
1 files changed, 5 insertions, 8 deletions
diff --git a/lib/Support/APFloat.cpp b/lib/Support/APFloat.cpp
index 676e2d4ba0..34bc6b6dd6 100644
--- a/lib/Support/APFloat.cpp
+++ b/lib/Support/APFloat.cpp
@@ -3546,14 +3546,11 @@ void APFloat::toString(SmallVectorImpl<char> &Str,
// Set FormatPrecision if zero. We want to do this before we
// truncate trailing zeros, as those are part of the precision.
if (!FormatPrecision) {
- // We use enough digits so the number can be round-tripped back to an
- // APFloat. The formula comes from "How to Print Floating-Point Numbers
- // Accurately" by Steele and White.
- // FIXME: Using a formula based purely on the precision is conservative;
- // we can print fewer digits depending on the actual value being printed.
-
- // FormatPrecision = 2 + floor(significandBits / lg_2(10))
- FormatPrecision = 2 + semantics->precision * 59 / 196;
+ // It's an interesting question whether to use the nominal
+ // precision or the active precision here for denormals.
+
+ // FormatPrecision = ceil(significandBits / lg_2(10))
+ FormatPrecision = (semantics->precision * 59 + 195) / 196;
}
// Ignore trailing binary zeros.