diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2013-09-22 14:09:50 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2013-09-22 14:09:50 +0000 |
| commit | 0d293e45b66c742fdbc3998209bb20ed6c5806bf (patch) | |
| tree | b94e3298127f119ce2169436e5c50e2f47401d56 /lib/MC/ELFObjectWriter.cpp | |
| parent | 7f80b75b963781d81b772ae2f3a35dc74e1b6457 (diff) | |
| download | external_llvm-0d293e45b66c742fdbc3998209bb20ed6c5806bf.tar.gz external_llvm-0d293e45b66c742fdbc3998209bb20ed6c5806bf.tar.bz2 external_llvm-0d293e45b66c742fdbc3998209bb20ed6c5806bf.zip | |
Provide basic type safety for array_pod_sort comparators.
This makes using array_pod_sort significantly safer. The implementation relies
on function pointer casting but that should be safe as we're dealing with void*
here.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191175 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC/ELFObjectWriter.cpp')
| -rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index 2db59acd50..402a6167f5 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -1104,11 +1104,10 @@ void ELFObjectWriter::WriteRelocationsFragment(const MCAssembler &Asm, } } -static int compareBySuffix(const void *a, const void *b) { - const MCSectionELF *secA = *static_cast<const MCSectionELF* const *>(a); - const MCSectionELF *secB = *static_cast<const MCSectionELF* const *>(b); - const StringRef &NameA = secA->getSectionName(); - const StringRef &NameB = secB->getSectionName(); +static int compareBySuffix(const MCSectionELF *const *a, + const MCSectionELF *const *b) { + const StringRef &NameA = (*a)->getSectionName(); + const StringRef &NameB = (*b)->getSectionName(); const unsigned sizeA = NameA.size(); const unsigned sizeB = NameB.size(); const unsigned len = std::min(sizeA, sizeB); |