aboutsummaryrefslogtreecommitdiffstats
path: root/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp
diff options
context:
space:
mode:
authorFilip Pizlo <fpizlo@apple.com>2013-10-02 00:59:25 +0000
committerFilip Pizlo <fpizlo@apple.com>2013-10-02 00:59:25 +0000
commit6eb43d295625cd2ff314c59b49d4fd11f3348cad (patch)
treedaec0d82ea11d026745a572949f7c7c1e6e8d5c0 /lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp
parent2b53089bd017139f0125b870ace94ff27dffd2ff (diff)
downloadexternal_llvm-6eb43d295625cd2ff314c59b49d4fd11f3348cad.tar.gz
external_llvm-6eb43d295625cd2ff314c59b49d4fd11f3348cad.tar.bz2
external_llvm-6eb43d295625cd2ff314c59b49d4fd11f3348cad.zip
This threads SectionName through the allocateCodeSection/allocateDataSection APIs, both in C++ and C land.
It's useful for the memory managers that are allocating a section to know what the name of the section is. At a minimum, this is useful for low-level debugging - it's customary for JITs to be able to tell you what memory they allocated, and as part of any such dump, they should be able to tell you some meta-data about what each allocation is for. This allows clients that supply their own memory managers to do this. Additionally, we also envision the SectionName being useful for passing meta-data from within LLVM to an LLVM client. This changes both the C and C++ APIs, and all of the clients of those APIs within LLVM. I'm assuming that it's safe to change the C++ API because that API is allowed to change. I'm assuming that it's safe to change the C API because we haven't shipped the API in a release yet (LLVM 3.3 doesn't include the MCJIT memory management C API). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191804 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp')
-rw-r--r--lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp b/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp
index 5469c8374b..cf90e77e38 100644
--- a/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp
+++ b/lib/ExecutionEngine/MCJIT/SectionMemoryManager.cpp
@@ -19,9 +19,10 @@
namespace llvm {
uint8_t *SectionMemoryManager::allocateDataSection(uintptr_t Size,
- unsigned Alignment,
- unsigned SectionID,
- bool IsReadOnly) {
+ unsigned Alignment,
+ unsigned SectionID,
+ StringRef SectionName,
+ bool IsReadOnly) {
if (IsReadOnly)
return allocateSection(RODataMem, Size, Alignment);
return allocateSection(RWDataMem, Size, Alignment);
@@ -29,7 +30,8 @@ uint8_t *SectionMemoryManager::allocateDataSection(uintptr_t Size,
uint8_t *SectionMemoryManager::allocateCodeSection(uintptr_t Size,
unsigned Alignment,
- unsigned SectionID) {
+ unsigned SectionID,
+ StringRef SectionName) {
return allocateSection(CodeMem, Size, Alignment);
}