diff options
| author | Alexey Samsonov <samsonov@google.com> | 2013-04-09 14:09:42 +0000 |
|---|---|---|
| committer | Alexey Samsonov <samsonov@google.com> | 2013-04-09 14:09:42 +0000 |
| commit | 32a3e78304a94ea214aee5fe82b10dd110e8863a (patch) | |
| tree | 0bbeb2eebc8d00a9bd64a4513f689de3e8af8d04 /lib/DebugInfo/DWARFFormValue.h | |
| parent | 3c5aaa20ee2422e3530d38b9f0199b182da8eb82 (diff) | |
| download | external_llvm-32a3e78304a94ea214aee5fe82b10dd110e8863a.tar.gz external_llvm-32a3e78304a94ea214aee5fe82b10dd110e8863a.tar.bz2 external_llvm-32a3e78304a94ea214aee5fe82b10dd110e8863a.zip | |
DWARF parser: Fix DWARF-2/3 incompatibility: size of DW_FORM_ref_addr is the same as DW_FORM_addr in DWARF2, and is 4/8 bytes on 32/64-bit DWARF starting from DWARF3. Adding a test for this is a huge pain - generating and uploading pre-built binary with DWARF3 debug info is way too ugly, and writing fine-grained unittests for DebugInfo is impossible, as it doesn't expose any headers in include/llvm. That said, I'm going to choose the second approach and submit the patch exposing DebugInfo headers for review soon enough.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179095 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/DebugInfo/DWARFFormValue.h')
| -rw-r--r-- | lib/DebugInfo/DWARFFormValue.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/DebugInfo/DWARFFormValue.h b/lib/DebugInfo/DWARFFormValue.h index b863001e4a..eaaccfb4f3 100644 --- a/lib/DebugInfo/DWARFFormValue.h +++ b/lib/DebugInfo/DWARFFormValue.h @@ -74,7 +74,7 @@ public: uint32_t *offset_ptr, const DWARFCompileUnit *cu); static bool isBlockForm(uint16_t form); static bool isDataForm(uint16_t form); - static const uint8_t *getFixedFormSizesForAddressSize(uint8_t addr_size); + static const uint8_t *getFixedFormSizes(uint8_t AddrSize, uint16_t Version); }; } |