aboutsummaryrefslogtreecommitdiffstats
path: root/lib/CodeGen/CriticalAntiDepBreaker.cpp
diff options
context:
space:
mode:
authorTim Murray <timmurray@google.com>2014-12-09 15:46:31 -0800
committerTim Murray <timmurray@google.com>2014-12-09 15:46:31 -0800
commit6eeae0cf0069a272980de53836081a244ca5dffb (patch)
tree5bd0c020c0d777cf401a68afe6dbd988228fba55 /lib/CodeGen/CriticalAntiDepBreaker.cpp
parent7a24d3c99c444122c5bcc1c49f43584140975ce8 (diff)
downloadexternal_llvm-6eeae0cf0069a272980de53836081a244ca5dffb.tar.gz
external_llvm-6eeae0cf0069a272980de53836081a244ca5dffb.tar.bz2
external_llvm-6eeae0cf0069a272980de53836081a244ca5dffb.zip
Revert "Apply rL216114 from upstream LLVM."
This reverts commit 9156e80250ada6f6d39af3b464a918d4855f9a2a.
Diffstat (limited to 'lib/CodeGen/CriticalAntiDepBreaker.cpp')
-rw-r--r--lib/CodeGen/CriticalAntiDepBreaker.cpp19
1 files changed, 2 insertions, 17 deletions
diff --git a/lib/CodeGen/CriticalAntiDepBreaker.cpp b/lib/CodeGen/CriticalAntiDepBreaker.cpp
index d2231ecf68..d3ffcc7847 100644
--- a/lib/CodeGen/CriticalAntiDepBreaker.cpp
+++ b/lib/CodeGen/CriticalAntiDepBreaker.cpp
@@ -94,14 +94,7 @@ void CriticalAntiDepBreaker::FinishBlock() {
void CriticalAntiDepBreaker::Observe(MachineInstr *MI, unsigned Count,
unsigned InsertPosIndex) {
- // Kill instructions can define registers but are really nops, and there might
- // be a real definition earlier that needs to be paired with uses dominated by
- // this kill.
-
- // FIXME: It may be possible to remove the isKill() restriction once PR18663
- // has been properly fixed. There can be value in processing kills as seen in
- // the AggressiveAntiDepBreaker class.
- if (MI->isDebugValue() || MI->isKill())
+ if (MI->isDebugValue())
return;
assert(Count < InsertPosIndex && "Instruction index out of expected range!");
@@ -244,7 +237,6 @@ void CriticalAntiDepBreaker::ScanInstruction(MachineInstr *MI,
// Update liveness.
// Proceeding upwards, registers that are defed but not used in this
// instruction are now dead.
- assert(!MI->isKill() && "Attempting to scan a kill instruction");
if (!TII->isPredicated(MI)) {
// Predicated defs are modeled as read + write, i.e. similar to two
@@ -535,14 +527,7 @@ BreakAntiDependencies(const std::vector<SUnit>& SUnits,
unsigned Count = InsertPosIndex - 1;
for (MachineBasicBlock::iterator I = End, E = Begin; I != E; --Count) {
MachineInstr *MI = --I;
- // Kill instructions can define registers but are really nops, and there
- // might be a real definition earlier that needs to be paired with uses
- // dominated by this kill.
-
- // FIXME: It may be possible to remove the isKill() restriction once PR18663
- // has been properly fixed. There can be value in processing kills as seen
- // in the AggressiveAntiDepBreaker class.
- if (MI->isDebugValue() || MI->isKill())
+ if (MI->isDebugValue())
continue;
// Check if this instruction has a dependence on the critical path that