diff options
| author | Ian Rogers <irogers@google.com> | 2014-08-12 02:30:58 -0700 |
|---|---|---|
| committer | Ian Rogers <irogers@google.com> | 2014-08-12 16:08:05 -0700 |
| commit | 1ff3c98775a4577cf053dba9a0c2d5c21c07b298 (patch) | |
| tree | 2d09c27c69678b53b4c9dc486024f3547efd4bca /runtime/utils.h | |
| parent | 99c251bbd225dd97d0deece29559a430b12a0b66 (diff) | |
| download | art-1ff3c98775a4577cf053dba9a0c2d5c21c07b298.tar.gz art-1ff3c98775a4577cf053dba9a0c2d5c21c07b298.tar.bz2 art-1ff3c98775a4577cf053dba9a0c2d5c21c07b298.zip | |
Avoid use of std::string where we have const char*.
Removing the ClassHelper caused std::string creation for all calls to
Class::GetDescriptor and a significant performance regression. Make the
std::string an out argument so the caller can maintain it and its life time
while allowing GetDescriptor to return the common const char* case.
Don't generate GC maps when compilation is disabled.
Remove other uses of std::string that are occuring on critical paths.
Use the cheaper SkipClass in CompileMethod in CompilerDriver.
Specialize the utf8 as utf16 comparison code for the common shorter byte
encoding.
Force a bit of inlining, remove some UNLIKELYs (they are prone to pessimizing
code), add some LIKELYs.
x86-64 host 1-thread interpret-only of 57 apks:
Before: 29.539s
After: 23.467s
Regular compile:
Before: 1m35.347s
After: 1m20.056s
Bug: 16853450
Change-Id: Ic705ea24784bee24ab80084d06174cbf87d557ad
Diffstat (limited to 'runtime/utils.h')
| -rw-r--r-- | runtime/utils.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/runtime/utils.h b/runtime/utils.h index f6773be289..c89c41f383 100644 --- a/runtime/utils.h +++ b/runtime/utils.h @@ -273,7 +273,7 @@ bool EndsWith(const std::string& s, const char* suffix); // "java.lang.String[]", and so forth. std::string PrettyDescriptor(mirror::String* descriptor) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); -std::string PrettyDescriptor(const std::string& descriptor); +std::string PrettyDescriptor(const char* descriptor); std::string PrettyDescriptor(mirror::Class* klass) SHARED_LOCKS_REQUIRED(Locks::mutator_lock_); std::string PrettyDescriptor(Primitive::Type type); @@ -335,10 +335,12 @@ std::string MangleForJni(const std::string& s); // Turn "java.lang.String" into "Ljava/lang/String;". std::string DotToDescriptor(const char* class_name); -// Turn "Ljava/lang/String;" into "java.lang.String". +// Turn "Ljava/lang/String;" into "java.lang.String" using the conventions of +// java.lang.Class.getName(). std::string DescriptorToDot(const char* descriptor); -// Turn "Ljava/lang/String;" into "java/lang/String". +// Turn "Ljava/lang/String;" into "java/lang/String" using the opposite conventions of +// java.lang.Class.getName(). std::string DescriptorToName(const char* descriptor); // Tests for whether 's' is a valid class name in the three common forms: |