diff options
author | Ian Rogers <irogers@google.com> | 2014-10-24 14:20:06 -0700 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-10-24 14:23:42 -0700 |
commit | 2c4257be8191c5eefde744e8965fcefc80a0a97d (patch) | |
tree | 9db3e1f1c60f2df29638ba3ce9d5d5bb8b26ca2c /runtime/mirror/object-inl.h | |
parent | 98c271d517bc4d25fc6879b4b8e35ea93885d9e2 (diff) | |
download | art-2c4257be8191c5eefde744e8965fcefc80a0a97d.tar.gz art-2c4257be8191c5eefde744e8965fcefc80a0a97d.tar.bz2 art-2c4257be8191c5eefde744e8965fcefc80a0a97d.zip |
Tidy logging code not using UNIMPLEMENTED.
Change-Id: I7a79c1671a6ff8b2040887133b3e0925ef9a3cfe
Diffstat (limited to 'runtime/mirror/object-inl.h')
-rw-r--r-- | runtime/mirror/object-inl.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/runtime/mirror/object-inl.h b/runtime/mirror/object-inl.h index b89da9d4fe..c9e60bc0b2 100644 --- a/runtime/mirror/object-inl.h +++ b/runtime/mirror/object-inl.h @@ -121,7 +121,7 @@ inline Object* Object::GetReadBarrierPointer() { OFFSET_OF_OBJECT_MEMBER(Object, x_rb_ptr_)); #else LOG(FATAL) << "Unreachable"; - return nullptr; + UNREACHABLE(); #endif } @@ -134,6 +134,7 @@ inline void Object::SetReadBarrierPointer(Object* rb_ptr) { OFFSET_OF_OBJECT_MEMBER(Object, x_rb_ptr_), rb_ptr); #else LOG(FATAL) << "Unreachable"; + UNREACHABLE(); #endif } @@ -156,7 +157,7 @@ inline bool Object::AtomicSetReadBarrierPointer(Object* expected_rb_ptr, Object* return true; #else LOG(FATAL) << "Unreachable"; - return false; + UNREACHABLE(); #endif } @@ -166,13 +167,12 @@ inline void Object::AssertReadBarrierPointer() const { DCHECK(obj->GetReadBarrierPointer() == nullptr) << "Bad Baker pointer: obj=" << reinterpret_cast<void*>(obj) << " ptr=" << reinterpret_cast<void*>(obj->GetReadBarrierPointer()); - } else if (kUseBrooksReadBarrier) { + } else { + CHECK(kUseBrooksReadBarrier); Object* obj = const_cast<Object*>(this); DCHECK_EQ(obj, obj->GetReadBarrierPointer()) << "Bad Brooks pointer: obj=" << reinterpret_cast<void*>(obj) << " ptr=" << reinterpret_cast<void*>(obj->GetReadBarrierPointer()); - } else { - LOG(FATAL) << "Unreachable"; } } |