summaryrefslogtreecommitdiffstats
path: root/runtime/jdwp
diff options
context:
space:
mode:
authorSebastien Hertz <shertz@google.com>2014-09-19 06:29:26 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2014-09-19 06:29:28 +0000
commit5cdd0734d2f79eedc530f5f1e876cd2110e29c86 (patch)
treed4fdaf86505f7474dc7127cb968a44fe4e8ba58e /runtime/jdwp
parentc64746c1d224143d85232c8899126930e3fe5d27 (diff)
parentf272af4b9dcd39cdd50fa6655601a26e837eaea9 (diff)
downloadart-5cdd0734d2f79eedc530f5f1e876cd2110e29c86.tar.gz
art-5cdd0734d2f79eedc530f5f1e876cd2110e29c86.tar.bz2
art-5cdd0734d2f79eedc530f5f1e876cd2110e29c86.zip
Merge "Move spammy logs to JDWP verbose mode"
Diffstat (limited to 'runtime/jdwp')
-rw-r--r--runtime/jdwp/jdwp_event.cc9
1 files changed, 5 insertions, 4 deletions
diff --git a/runtime/jdwp/jdwp_event.cc b/runtime/jdwp/jdwp_event.cc
index 46db63ccd5..d61660bca7 100644
--- a/runtime/jdwp/jdwp_event.cc
+++ b/runtime/jdwp/jdwp_event.cc
@@ -297,9 +297,6 @@ void JdwpState::UnregisterEvent(JdwpEvent* pEvent) {
/*
* Remove the event with the given ID from the list.
*
- * Failure to find the event isn't really an error, but it is a little
- * weird. (It looks like Eclipse will try to be extra careful and will
- * explicitly remove one-off single-step events.)
*/
void JdwpState::UnregisterEventById(uint32_t requestId) {
bool found = false;
@@ -319,7 +316,11 @@ void JdwpState::UnregisterEventById(uint32_t requestId) {
if (found) {
Dbg::ManageDeoptimization();
} else {
- LOG(WARNING) << StringPrintf("Odd: no match when removing event reqId=0x%04x", requestId);
+ // Failure to find the event isn't really an error. For instance, it looks like Eclipse will
+ // try to be extra careful and will explicitly remove one-off single-step events (using a
+ // 'count' event modifier of 1). So the event may have already been removed as part of the
+ // event notification (see JdwpState::CleanupMatchList).
+ VLOG(jdwp) << StringPrintf("No match when removing event reqId=0x%04x", requestId);
}
}