diff options
author | Ian Rogers <irogers@google.com> | 2014-07-15 22:23:51 -0700 |
---|---|---|
committer | Ian Rogers <irogers@google.com> | 2014-07-16 06:13:46 -0700 |
commit | 22d5e735f403c57525fe868304c7123f0ce66399 (patch) | |
tree | 2458684efa56f0b800dd75a9dedd0449f76f581f /runtime/entrypoints | |
parent | fbde4dd1cb6db729e3f3ee5bdae0cdd824d73054 (diff) | |
download | art-22d5e735f403c57525fe868304c7123f0ce66399.tar.gz art-22d5e735f403c57525fe868304c7123f0ce66399.tar.bz2 art-22d5e735f403c57525fe868304c7123f0ce66399.zip |
Remove object_utils.h.
Break into object_lock, field_helper and method_helper.
Clean up header files following this.
Also tidy some of the Handle code in response to compiler errors when resolving
the changes in this CL.
Change-Id: I73e63015a0f02a754d0866bfaf58208aebcaa295
Diffstat (limited to 'runtime/entrypoints')
10 files changed, 3 insertions, 11 deletions
diff --git a/runtime/entrypoints/entrypoint_utils-inl.h b/runtime/entrypoints/entrypoint_utils-inl.h index 482ad47d5d..542e1a9e2e 100644 --- a/runtime/entrypoints/entrypoint_utils-inl.h +++ b/runtime/entrypoints/entrypoint_utils-inl.h @@ -25,12 +25,12 @@ #include "indirect_reference_table.h" #include "invoke_type.h" #include "jni_internal.h" +#include "method_helper.h" #include "mirror/art_method.h" #include "mirror/array.h" #include "mirror/class-inl.h" #include "mirror/object-inl.h" #include "mirror/throwable.h" -#include "object_utils.h" #include "handle_scope-inl.h" #include "thread.h" diff --git a/runtime/entrypoints/entrypoint_utils.cc b/runtime/entrypoints/entrypoint_utils.cc index d029df2c7f..d063dfb425 100644 --- a/runtime/entrypoints/entrypoint_utils.cc +++ b/runtime/entrypoints/entrypoint_utils.cc @@ -24,7 +24,6 @@ #include "mirror/art_method-inl.h" #include "mirror/class-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "mirror/object_array-inl.h" #include "reflection.h" #include "scoped_thread_state_change.h" diff --git a/runtime/entrypoints/interpreter/interpreter_entrypoints.cc b/runtime/entrypoints/interpreter/interpreter_entrypoints.cc index 329c175986..64faf76213 100644 --- a/runtime/entrypoints/interpreter/interpreter_entrypoints.cc +++ b/runtime/entrypoints/interpreter/interpreter_entrypoints.cc @@ -18,7 +18,6 @@ #include "interpreter/interpreter.h" #include "mirror/art_method-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "reflection.h" #include "runtime.h" #include "stack.h" diff --git a/runtime/entrypoints/jni/jni_entrypoints.cc b/runtime/entrypoints/jni/jni_entrypoints.cc index bae4023c1d..edb3b723ef 100644 --- a/runtime/entrypoints/jni/jni_entrypoints.cc +++ b/runtime/entrypoints/jni/jni_entrypoints.cc @@ -18,7 +18,6 @@ #include "entrypoints/entrypoint_utils.h" #include "mirror/art_method-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "scoped_thread_state_change.h" #include "thread.h" diff --git a/runtime/entrypoints/portable/portable_throw_entrypoints.cc b/runtime/entrypoints/portable/portable_throw_entrypoints.cc index 9e36a05841..be6231cae5 100644 --- a/runtime/entrypoints/portable/portable_throw_entrypoints.cc +++ b/runtime/entrypoints/portable/portable_throw_entrypoints.cc @@ -80,7 +80,6 @@ extern "C" int32_t art_portable_find_catch_block_from_code(mirror::ArtMethod* cu } mirror::Class* exception_type = exception->GetClass(); StackHandleScope<1> hs(self); - MethodHelper mh(hs.NewHandle(current_method)); const DexFile::CodeItem* code_item = current_method->GetCodeItem(); DCHECK_LT(ti_offset, code_item->tries_size_); const DexFile::TryItem* try_item = DexFile::GetTryItems(*code_item, ti_offset); @@ -98,7 +97,8 @@ extern "C" int32_t art_portable_find_catch_block_from_code(mirror::ArtMethod* cu break; } // Does this catch exception type apply? - mirror::Class* iter_exception_type = mh.GetDexCacheResolvedType(iter_type_idx); + mirror::Class* iter_exception_type = + current_method->GetDexCacheResolvedTypes()->Get(iter_type_idx); if (UNLIKELY(iter_exception_type == NULL)) { // TODO: check, the verifier (class linker?) should take care of resolving all exception // classes early. diff --git a/runtime/entrypoints/portable/portable_trampoline_entrypoints.cc b/runtime/entrypoints/portable/portable_trampoline_entrypoints.cc index 7ee869b67f..9f75b0fcf0 100644 --- a/runtime/entrypoints/portable/portable_trampoline_entrypoints.cc +++ b/runtime/entrypoints/portable/portable_trampoline_entrypoints.cc @@ -22,7 +22,6 @@ #include "interpreter/interpreter.h" #include "mirror/art_method-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "scoped_thread_state_change.h" namespace art { diff --git a/runtime/entrypoints/quick/quick_deoptimization_entrypoints.cc b/runtime/entrypoints/quick/quick_deoptimization_entrypoints.cc index 47fb9d66f8..f9f62c2721 100644 --- a/runtime/entrypoints/quick/quick_deoptimization_entrypoints.cc +++ b/runtime/entrypoints/quick/quick_deoptimization_entrypoints.cc @@ -21,7 +21,6 @@ #include "mirror/class-inl.h" #include "mirror/object_array-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "stack.h" #include "thread.h" #include "verifier/method_verifier.h" diff --git a/runtime/entrypoints/quick/quick_jni_entrypoints.cc b/runtime/entrypoints/quick/quick_jni_entrypoints.cc index 30e86097a6..653724989a 100644 --- a/runtime/entrypoints/quick/quick_jni_entrypoints.cc +++ b/runtime/entrypoints/quick/quick_jni_entrypoints.cc @@ -21,7 +21,6 @@ #include "mirror/object.h" #include "mirror/object-inl.h" #include "mirror/object_array-inl.h" -#include "object_utils.h" #include "scoped_thread_state_change.h" #include "thread.h" #include "verify_object-inl.h" diff --git a/runtime/entrypoints/quick/quick_throw_entrypoints.cc b/runtime/entrypoints/quick/quick_throw_entrypoints.cc index 4dcb1c8dc6..879010e36e 100644 --- a/runtime/entrypoints/quick/quick_throw_entrypoints.cc +++ b/runtime/entrypoints/quick/quick_throw_entrypoints.cc @@ -18,7 +18,6 @@ #include "common_throws.h" #include "entrypoints/entrypoint_utils-inl.h" #include "mirror/object-inl.h" -#include "object_utils.h" #include "thread.h" #include "well_known_classes.h" diff --git a/runtime/entrypoints/quick/quick_trampoline_entrypoints.cc b/runtime/entrypoints/quick/quick_trampoline_entrypoints.cc index f7cb1263f2..338bd06f7c 100644 --- a/runtime/entrypoints/quick/quick_trampoline_entrypoints.cc +++ b/runtime/entrypoints/quick/quick_trampoline_entrypoints.cc @@ -27,7 +27,6 @@ #include "mirror/dex_cache-inl.h" #include "mirror/object-inl.h" #include "mirror/object_array-inl.h" -#include "object_utils.h" #include "runtime.h" #include "scoped_thread_state_change.h" |