diff options
| author | Mathieu Chartier <mathieuc@google.com> | 2014-11-10 11:08:06 -0800 |
|---|---|---|
| committer | Mathieu Chartier <mathieuc@google.com> | 2014-11-18 12:27:37 -0800 |
| commit | 2d7210188805292e463be4bcf7a133b654d7e0ea (patch) | |
| tree | 7705a3bf841ae44b2396728fa22ed0b5dcb44dbf /runtime/arch/mips/portable_entrypoints_mips.S | |
| parent | e0491682d101c69bf88c3c24a965312129cbfa38 (diff) | |
| download | art-2d7210188805292e463be4bcf7a133b654d7e0ea.tar.gz art-2d7210188805292e463be4bcf7a133b654d7e0ea.tar.bz2 art-2d7210188805292e463be4bcf7a133b654d7e0ea.zip | |
Change 64 bit ArtMethod fields to be pointer sized
Changed the 64 bit entrypoint and gc map fields in ArtMethod to be
pointer sized. This saves a large amount of memory on 32 bit systems.
Reduces ArtMethod size by 16 bytes on 32 bit.
Total number of ArtMethod on low memory mako: 169957
Image size: 49203 methods -> 787248 image size reduction.
Zygote space size: 1070 methods -> 17120 size reduction.
App methods: ~120k -> 2 MB savings.
Savings per app on low memory mako: 125K+ per app
(less active apps -> more image methods per app).
Savings depend on how often the shared methods are on dirty pages vs
shared.
TODO in another CL, delete gc map field from ArtMethod since we
should be able to get it from the Oat method header.
Bug: 17643507
Change-Id: Ie9508f05907a9f693882d4d32a564460bf273ee8
(cherry picked from commit e832e64a7e82d7f72aedbd7d798fb929d458ee8f)
Diffstat (limited to 'runtime/arch/mips/portable_entrypoints_mips.S')
| -rw-r--r-- | runtime/arch/mips/portable_entrypoints_mips.S | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/runtime/arch/mips/portable_entrypoints_mips.S b/runtime/arch/mips/portable_entrypoints_mips.S index d7e7a8e96b..8d418e8dd1 100644 --- a/runtime/arch/mips/portable_entrypoints_mips.S +++ b/runtime/arch/mips/portable_entrypoints_mips.S @@ -98,7 +98,7 @@ ENTRY art_portable_invoke_stub lw $a1, 4($sp) # copy arg value for a1 lw $a2, 8($sp) # copy arg value for a2 lw $a3, 12($sp) # copy arg value for a3 - lw $t9, MIRROR_ART_METHOD_PORTABLE_CODE_OFFSET($a0) # get pointer to the code + lw $t9, MIRROR_ART_METHOD_PORTABLE_CODE_OFFSET_32($a0) # get pointer to the code jalr $t9 # call the method sw $zero, 0($sp) # store NULL for method* at bottom of frame move $sp, $fp # restore the stack |