diff options
| author | Vladimir Marko <vmarko@google.com> | 2018-10-31 12:58:44 +0000 |
|---|---|---|
| committer | Vladimir Marko <vmarko@google.com> | 2018-10-31 12:58:44 +0000 |
| commit | 830f356912cf2e150a4701be325cd134c3f943b1 (patch) | |
| tree | 5f1b22d55501d3eddaad5c5383b3ff33b857cc9d /libartbase | |
| parent | 91ddef31f229e6d116cc8988b71aa77bc5083bcb (diff) | |
| download | art-830f356912cf2e150a4701be325cd134c3f943b1.tar.gz art-830f356912cf2e150a4701be325cd134c3f943b1.tar.bz2 art-830f356912cf2e150a4701be325cd134c3f943b1.zip | |
Clean up mem_map_test.
Address late comments on
https://android-review.googlesource.com/805054 .
Test: m test-art-host-gtest
Bug: 118408378
Change-Id: Ifd76a17ee9fd34772a9939491fe210327d122428
Diffstat (limited to 'libartbase')
| -rw-r--r-- | libartbase/base/mem_map_test.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/libartbase/base/mem_map_test.cc b/libartbase/base/mem_map_test.cc index b419ddd941..074d4c2890 100644 --- a/libartbase/base/mem_map_test.cc +++ b/libartbase/base/mem_map_test.cc @@ -200,7 +200,7 @@ TEST_F(MemMapTest, ReplaceMapping_MakeLarger) { 5 * kPageSize, // Need to make it larger // initially so we know // there won't be mappings - // in the way we we move + // in the way when we move // source. PROT_READ, /*low_4gb=*/ false, @@ -279,7 +279,7 @@ TEST_F(MemMapTest, ReplaceMapping_FailureOverlap) { MemMap::MapAnonymous( "MapAnonymousEmpty-atomic-replace-dest", 3 * kPageSize, // Need to make it larger initially so we know there won't be mappings in - // the way we we move source. + // the way when we move source. PROT_READ | PROT_WRITE, /*low_4gb=*/ false, &error_msg); @@ -575,8 +575,8 @@ TEST_F(MemMapTest, MapAnonymousLow4GBRangeTooHigh) { CommonInit(); std::string error_msg; MemMap map = MemMap::MapAnonymous("MapAnonymousLow4GBRangeTooHigh", - reinterpret_cast<uint8_t*>(0xF0000000), - 0x20000000, + /*addr=*/ reinterpret_cast<uint8_t*>(0xF0000000), + /*byte_count=*/ 0x20000000, PROT_READ | PROT_WRITE, /*low_4gb=*/ true, /*reuse=*/ false, @@ -591,15 +591,15 @@ TEST_F(MemMapTest, MapAnonymousReuse) { CommonInit(); std::string error_msg; MemMap map = MemMap::MapAnonymous("MapAnonymousReserve", - 0x20000, + /*byte_count=*/ 0x20000, PROT_READ | PROT_WRITE, /*low_4gb=*/ false, &error_msg); ASSERT_TRUE(map.IsValid()); ASSERT_TRUE(error_msg.empty()); MemMap map2 = MemMap::MapAnonymous("MapAnonymousReused", - reinterpret_cast<uint8_t*>(map.BaseBegin()), - 0x10000, + /*addr=*/ reinterpret_cast<uint8_t*>(map.BaseBegin()), + /*byte_count=*/ 0x10000, PROT_READ | PROT_WRITE, /*low_4gb=*/ false, /*reuse=*/ true, |