diff options
| author | Nicolas Geoffray <ngeoffray@google.com> | 2015-03-23 17:05:48 +0000 |
|---|---|---|
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2015-03-23 17:05:48 +0000 |
| commit | 90d480c26f7524f35323a11d6ba2880ff3db789a (patch) | |
| tree | d52251e5720bbce2c5bc066e6da90b0345f8d53d /compiler | |
| parent | c6de977f6482014a9d01a880efe3eed8bd2007e6 (diff) | |
| parent | 36540cb4d549c706cc7cd23086684f1548a91042 (diff) | |
| download | art-90d480c26f7524f35323a11d6ba2880ff3db789a.tar.gz art-90d480c26f7524f35323a11d6ba2880ff3db789a.tar.bz2 art-90d480c26f7524f35323a11d6ba2880ff3db789a.zip | |
Merge "Implement a space filter for optimizing."
Diffstat (limited to 'compiler')
| -rw-r--r-- | compiler/optimizing/optimizing_compiler.cc | 10 | ||||
| -rw-r--r-- | compiler/optimizing/optimizing_compiler_stats.h | 2 |
2 files changed, 12 insertions, 0 deletions
diff --git a/compiler/optimizing/optimizing_compiler.cc b/compiler/optimizing/optimizing_compiler.cc index b70f9252ae..933a8a005c 100644 --- a/compiler/optimizing/optimizing_compiler.cc +++ b/compiler/optimizing/optimizing_compiler.cc @@ -462,6 +462,16 @@ CompiledMethod* OptimizingCompiler::TryCompile(const DexFile::CodeItem* code_ite return nullptr; } + // Implementation of the space filter: do not compile a code item whose size in + // code units is bigger than 256. + static constexpr size_t kSpaceFilterOptimizingThreshold = 256; + const CompilerOptions& compiler_options = compiler_driver->GetCompilerOptions(); + if ((compiler_options.GetCompilerFilter() == CompilerOptions::kSpace) + && (code_item->insns_size_in_code_units_ > kSpaceFilterOptimizingThreshold)) { + compilation_stats_.RecordStat(MethodCompilationStat::kNotCompiledSpaceFilter); + return nullptr; + } + DexCompilationUnit dex_compilation_unit( nullptr, class_loader, art::Runtime::Current()->GetClassLinker(), dex_file, code_item, class_def_idx, method_idx, access_flags, diff --git a/compiler/optimizing/optimizing_compiler_stats.h b/compiler/optimizing/optimizing_compiler_stats.h index 3ebf0f8cd2..22ec2a5167 100644 --- a/compiler/optimizing/optimizing_compiler_stats.h +++ b/compiler/optimizing/optimizing_compiler_stats.h @@ -38,6 +38,7 @@ enum MethodCompilationStat { kNotCompiledUnresolvedMethod, kNotCompiledUnresolvedField, kNotCompiledNonSequentialRegPair, + kNotCompiledSpaceFilter, kNotOptimizedTryCatch, kNotOptimizedDisabled, kNotCompiledCantAccesType, @@ -96,6 +97,7 @@ class OptimizingCompilerStats { case kNotOptimizedDisabled : return "kNotOptimizedDisabled"; case kNotOptimizedTryCatch : return "kNotOptimizedTryCatch"; case kNotCompiledCantAccesType : return "kNotCompiledCantAccesType"; + case kNotCompiledSpaceFilter : return "kNotCompiledSpaceFilter"; case kNotOptimizedRegisterAllocator : return "kNotOptimizedRegisterAllocator"; case kNotCompiledUnhandledInstruction : return "kNotCompiledUnhandledInstruction"; case kRemovedCheckedCast: return "kRemovedCheckedCast"; |