summaryrefslogtreecommitdiffstats
path: root/compiler/optimizing/nodes.h
diff options
context:
space:
mode:
authorNicolas Geoffray <ngeoffray@google.com>2015-04-26 16:43:00 +0000
committerNicolas Geoffray <ngeoffray@google.com>2015-04-26 16:43:00 +0000
commit067cae2c86627d2edcf01b918ee601774bc76aeb (patch)
tree170607d1194943f4eff92e70170da36e06b68a9c /compiler/optimizing/nodes.h
parentb0bd8915cb257cdaf46ba663c450a6543bca75af (diff)
downloadart-067cae2c86627d2edcf01b918ee601774bc76aeb.tar.gz
art-067cae2c86627d2edcf01b918ee601774bc76aeb.tar.bz2
art-067cae2c86627d2edcf01b918ee601774bc76aeb.zip
Revert "[optimizing] Replace FP divide by power of 2"
Fails compiling docs. This reverts commit b0bd8915cb257cdaf46ba663c450a6543bca75af. Change-Id: I47d32525c83a73118e2163eb58c68bbb7a28bb38
Diffstat (limited to 'compiler/optimizing/nodes.h')
-rw-r--r--compiler/optimizing/nodes.h14
1 files changed, 7 insertions, 7 deletions
diff --git a/compiler/optimizing/nodes.h b/compiler/optimizing/nodes.h
index 3e922a0065..d9d15c4b18 100644
--- a/compiler/optimizing/nodes.h
+++ b/compiler/optimizing/nodes.h
@@ -234,7 +234,7 @@ class HGraph : public ArenaObject<kArenaAllocMisc> {
// Returns a constant of the given type and value. If it does not exist
// already, it is created and inserted into the graph. Only integral types
- // are currently cached.
+ // are currently supported.
HConstant* GetConstant(Primitive::Type type, int64_t value);
HNullConstant* GetNullConstant();
HIntConstant* GetIntConstant(int32_t value) {
@@ -243,8 +243,6 @@ class HGraph : public ArenaObject<kArenaAllocMisc> {
HLongConstant* GetLongConstant(int64_t value) {
return CreateConstant(value, &cached_long_constants_);
}
- HFloatConstant* GetFloatConstant(float value);
- HDoubleConstant* GetDoubleConstant(double value);
private:
HBasicBlock* FindCommonDominator(HBasicBlock* first, HBasicBlock* second) const;
@@ -2022,9 +2020,10 @@ class HFloatConstant : public HConstant {
const float value_;
- // Only the SsaBuilder and HGraph can create floating-point constants.
+ // Only the SsaBuilder can currently create floating-point constants. If we
+ // ever need to create them later in the pipeline, we will have to handle them
+ // the same way as integral constants.
friend class SsaBuilder;
- friend class HGraph;
DISALLOW_COPY_AND_ASSIGN(HFloatConstant);
};
@@ -2058,9 +2057,10 @@ class HDoubleConstant : public HConstant {
const double value_;
- // Only the SsaBuilder and HGraph can create floating-point constants.
+ // Only the SsaBuilder can currently create floating-point constants. If we
+ // ever need to create them later in the pipeline, we will have to handle them
+ // the same way as integral constants.
friend class SsaBuilder;
- friend class HGraph;
DISALLOW_COPY_AND_ASSIGN(HDoubleConstant);
};