summaryrefslogtreecommitdiffstats
path: root/compiler/optimizing/instruction_simplifier.cc
diff options
context:
space:
mode:
authorAndreas Gampe <agampe@google.com>2018-05-22 20:54:14 +0000
committerAndreas Gampe <agampe@google.com>2018-05-22 20:54:14 +0000
commit8b362a87d52a6668ffd2283ef6ffc274315f41c8 (patch)
tree14b187cd0b4afde501b9cc7a9dc82c997362e888 /compiler/optimizing/instruction_simplifier.cc
parent8268cb677bd92bfbcfec7e803775c29687494e53 (diff)
downloadart-8b362a87d52a6668ffd2283ef6ffc274315f41c8.tar.gz
art-8b362a87d52a6668ffd2283ef6ffc274315f41c8.tar.bz2
art-8b362a87d52a6668ffd2283ef6ffc274315f41c8.zip
Revert "Remove support for Valgrind in ART."
This reverts commit 8268cb677bd92bfbcfec7e803775c29687494e53. Reason for revert: ASAN failures Change-Id: I7e66d3f3fb461ae4f6dea6ec7d506b7dface3402 Test: SANITIZE_HOST=address m test-art-host Bug: 77856586 Bug: 29282211
Diffstat (limited to 'compiler/optimizing/instruction_simplifier.cc')
-rw-r--r--compiler/optimizing/instruction_simplifier.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/compiler/optimizing/instruction_simplifier.cc b/compiler/optimizing/instruction_simplifier.cc
index 6e618f4d02..ca84d421a7 100644
--- a/compiler/optimizing/instruction_simplifier.cc
+++ b/compiler/optimizing/instruction_simplifier.cc
@@ -636,8 +636,8 @@ void InstructionSimplifierVisitor::VisitCheckCast(HCheckCast* check_cast) {
return;
}
- // Historical note: The `outcome` was initialized to please Valgrind - the compiler can reorder
- // the return value check with the `outcome` check, b/27651442.
+ // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
+ // the return value check with the `outcome` check, b/27651442 .
bool outcome = false;
if (TypeCheckHasKnownOutcome(check_cast->GetTargetClassRTI(), object, &outcome)) {
if (outcome) {
@@ -682,8 +682,8 @@ void InstructionSimplifierVisitor::VisitInstanceOf(HInstanceOf* instruction) {
return;
}
- // Historical note: The `outcome` was initialized to please Valgrind - the compiler can reorder
- // the return value check with the `outcome` check, b/27651442.
+ // Note: The `outcome` is initialized to please valgrind - the compiler can reorder
+ // the return value check with the `outcome` check, b/27651442 .
bool outcome = false;
if (TypeCheckHasKnownOutcome(instruction->GetTargetClassRTI(), object, &outcome)) {
MaybeRecordStat(stats_, MethodCompilationStat::kRemovedInstanceOf);