diff options
author | Igor Murashkin <iam@google.com> | 2015-08-04 11:18:43 -0700 |
---|---|---|
committer | Igor Murashkin <iam@google.com> | 2015-08-04 11:19:56 -0700 |
commit | b1d8c314b55bb2df2b2bb72a3daaf5db65b7ebc7 (patch) | |
tree | 87e8252ee6ca23138f867989a098b7c4338c21a5 | |
parent | 1d558db0bcd841140f6fe1c6ba2e9a6de131649d (diff) | |
download | art-b1d8c314b55bb2df2b2bb72a3daaf5db65b7ebc7.tar.gz art-b1d8c314b55bb2df2b2bb72a3daaf5db65b7ebc7.tar.bz2 art-b1d8c314b55bb2df2b2bb72a3daaf5db65b7ebc7.zip |
Revert "cleanup: Replace pointers with out-parameters and fix-up formatting"
This reverts commit a315f5c546b796f55f4872bb6efc15eb858d9639.
--
Revert "runtime: cleanup class_linker out-parameters and formatting"
This reverts commit bc1d78daa463572c5a770cdca858a3b51d8e1b7b.
--
Revert "base: replace raw pointers for out-parameters with safer out<T>"
This reverts commit fb326cffc679cab8eb873b9e44795706f023cb3c.
29 files changed, 417 insertions, 1103 deletions
diff --git a/build/Android.gtest.mk b/build/Android.gtest.mk index 4850e6c44e..63ad9cf3ff 100644 --- a/build/Android.gtest.mk +++ b/build/Android.gtest.mk @@ -165,7 +165,6 @@ RUNTIME_GTEST_COMMON_SRC_FILES := \ runtime/base/hex_dump_test.cc \ runtime/base/histogram_test.cc \ runtime/base/mutex_test.cc \ - runtime/base/out_test.cc \ runtime/base/scoped_flock_test.cc \ runtime/base/stringprintf_test.cc \ runtime/base/time_utils_test.cc \ diff --git a/compiler/image_writer.cc b/compiler/image_writer.cc index 17d75a3cd3..dda36fa2ef 100644 --- a/compiler/image_writer.cc +++ b/compiler/image_writer.cc @@ -141,7 +141,7 @@ bool ImageWriter::Write(const std::string& image_filename, return false; } std::string error_msg; - oat_file_ = OatFile::OpenReadable(oat_file.get(), oat_location, nullptr, outof(error_msg)); + oat_file_ = OatFile::OpenReadable(oat_file.get(), oat_location, nullptr, &error_msg); if (oat_file_ == nullptr) { PLOG(ERROR) << "Failed to open writable oat file " << oat_filename << " for " << oat_location << ": " << error_msg; diff --git a/compiler/oat_test.cc b/compiler/oat_test.cc index 05a33d7a7f..88dc29e6ab 100644 --- a/compiler/oat_test.cc +++ b/compiler/oat_test.cc @@ -16,7 +16,6 @@ #include "arch/instruction_set_features.h" #include "art_method-inl.h" -#include "base/out.h" #include "class_linker.h" #include "common_compiler_test.h" #include "compiled_method.h" @@ -84,7 +83,7 @@ TEST_F(OatTest, WriteRead) { std::string error_msg; std::unique_ptr<const InstructionSetFeatures> insn_features( - InstructionSetFeatures::FromVariant(insn_set, "default", outof(error_msg))); + InstructionSetFeatures::FromVariant(insn_set, "default", &error_msg)); ASSERT_TRUE(insn_features.get() != nullptr) << error_msg; compiler_options_.reset(new CompilerOptions); verification_results_.reset(new VerificationResults(compiler_options_.get())); @@ -124,7 +123,7 @@ TEST_F(OatTest, WriteRead) { compiler_driver_->CompileAll(class_loader, class_linker->GetBootClassPath(), &timings); } std::unique_ptr<OatFile> oat_file(OatFile::Open(tmp.GetFilename(), tmp.GetFilename(), nullptr, - nullptr, false, nullptr, outof(error_msg))); + nullptr, false, nullptr, &error_msg)); ASSERT_TRUE(oat_file.get() != nullptr) << error_msg; const OatHeader& oat_header = oat_file->GetOatHeader(); ASSERT_TRUE(oat_header.IsValid()); @@ -191,7 +190,7 @@ TEST_F(OatTest, OatHeaderIsValid) { InstructionSet insn_set = kX86; std::string error_msg; std::unique_ptr<const InstructionSetFeatures> insn_features( - InstructionSetFeatures::FromVariant(insn_set, "default", outof(error_msg))); + InstructionSetFeatures::FromVariant(insn_set, "default", &error_msg)); ASSERT_TRUE(insn_features.get() != nullptr) << error_msg; std::vector<const DexFile*> dex_files; uint32_t image_file_location_oat_checksum = 0; diff --git a/oatdump/oatdump.cc b/oatdump/oatdump.cc index 99140d4101..b8b6a5f7c0 100644 --- a/oatdump/oatdump.cc +++ b/oatdump/oatdump.cc @@ -159,7 +159,7 @@ class OatSymbolizer FINAL { void WalkOatDexFile(const OatFile::OatDexFile* oat_dex_file, Callback callback) { std::string error_msg; - std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(outof(error_msg))); + std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(&error_msg)); if (dex_file.get() == nullptr) { return; } @@ -504,7 +504,7 @@ class OatDumper { const OatFile::OatDexFile* oat_dex_file = oat_dex_files_[i]; CHECK(oat_dex_file != nullptr); std::string error_msg; - std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(outof(error_msg))); + std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(&error_msg)); if (dex_file.get() == nullptr) { LOG(WARNING) << "Failed to open dex file '" << oat_dex_file->GetDexFileLocation() << "': " << error_msg; @@ -533,7 +533,7 @@ class OatDumper { const OatFile::OatDexFile* oat_dex_file = oat_dex_files_[i]; CHECK(oat_dex_file != nullptr); std::string error_msg; - std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(outof(error_msg))); + std::unique_ptr<const DexFile> dex_file(oat_dex_file->OpenDexFile(&error_msg)); if (dex_file.get() == nullptr) { LOG(WARNING) << "Failed to open dex file '" << oat_dex_file->GetDexFileLocation() << "': " << error_msg; @@ -593,7 +593,7 @@ class OatDumper { // Create the verifier early. std::string error_msg; - std::unique_ptr<const DexFile> dex_file(oat_dex_file.OpenDexFile(outof(error_msg))); + std::unique_ptr<const DexFile> dex_file(oat_dex_file.OpenDexFile(&error_msg)); if (dex_file.get() == nullptr) { os << "NOT FOUND: " << error_msg << "\n\n"; os << std::flush; @@ -638,7 +638,7 @@ class OatDumper { std::string error_msg; std::string dex_file_location = oat_dex_file.GetDexFileLocation(); - std::unique_ptr<const DexFile> dex_file(oat_dex_file.OpenDexFile(outof(error_msg))); + std::unique_ptr<const DexFile> dex_file(oat_dex_file.OpenDexFile(&error_msg)); if (dex_file == nullptr) { os << "Failed to open dex file '" << dex_file_location << "': " << error_msg; return false; @@ -1553,7 +1553,7 @@ class ImageDumper { if (oat_file == nullptr) { oat_file = OatFile::Open(oat_location, oat_location, nullptr, nullptr, false, nullptr, - outof(error_msg)); + &error_msg); if (oat_file == nullptr) { os << "NOT FOUND: " << error_msg << "\n"; return false; @@ -2321,7 +2321,7 @@ static int DumpOatWithRuntime(Runtime* runtime, OatFile* oat_file, OatDumperOpti std::vector<std::unique_ptr<const DexFile>> dex_files; for (const OatFile::OatDexFile* odf : oat_file->GetOatDexFiles()) { std::string error_msg; - std::unique_ptr<const DexFile> dex_file = odf->OpenDexFile(outof(error_msg)); + std::unique_ptr<const DexFile> dex_file = odf->OpenDexFile(&error_msg); CHECK(dex_file != nullptr) << error_msg; class_linker->RegisterDexFile(*dex_file); dex_files.push_back(std::move(dex_file)); @@ -2361,7 +2361,7 @@ static int DumpOat(Runtime* runtime, const char* oat_filename, OatDumperOptions* std::ostream* os) { std::string error_msg; OatFile* oat_file = OatFile::Open(oat_filename, oat_filename, nullptr, nullptr, false, - nullptr, outof(error_msg)); + nullptr, &error_msg); if (oat_file == nullptr) { fprintf(stderr, "Failed to open oat file from '%s': %s\n", oat_filename, error_msg.c_str()); return EXIT_FAILURE; @@ -2377,7 +2377,7 @@ static int DumpOat(Runtime* runtime, const char* oat_filename, OatDumperOptions* static int SymbolizeOat(const char* oat_filename, std::string& output_name) { std::string error_msg; OatFile* oat_file = OatFile::Open(oat_filename, oat_filename, nullptr, nullptr, false, - nullptr, outof(error_msg)); + nullptr, &error_msg); if (oat_file == nullptr) { fprintf(stderr, "Failed to open oat file from '%s': %s\n", oat_filename, error_msg.c_str()); return EXIT_FAILURE; diff --git a/runtime/art_method.cc b/runtime/art_method.cc index f37e0407ca..17c9fe4149 100644 --- a/runtime/art_method.cc +++ b/runtime/art_method.cc @@ -19,7 +19,6 @@ #include "arch/context.h" #include "art_field-inl.h" #include "art_method-inl.h" -#include "base/out.h" #include "base/stringpiece.h" #include "dex_file-inl.h" #include "dex_instruction.h" @@ -566,7 +565,7 @@ bool ArtMethod::EqualParameters(Handle<mirror::ObjectArray<mirror::Class>> param const uint8_t* ArtMethod::GetQuickenedInfo() { bool found = false; OatFile::OatMethod oat_method = - Runtime::Current()->GetClassLinker()->FindOatMethodFor(this, outof(found)); + Runtime::Current()->GetClassLinker()->FindOatMethodFor(this, &found); if (!found || (oat_method.GetQuickCode() != nullptr)) { return nullptr; } diff --git a/runtime/base/out.h b/runtime/base/out.h deleted file mode 100644 index 7b4bc1216c..0000000000 --- a/runtime/base/out.h +++ /dev/null @@ -1,279 +0,0 @@ -/* - * Copyright (C) 2015 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef ART_RUNTIME_BASE_OUT_H_ -#define ART_RUNTIME_BASE_OUT_H_ - -#include <base/macros.h> -#include <base/logging.h> - -#include <memory> -// A zero-overhead abstraction marker that means this value is meant to be used as an out -// parameter for functions. It mimics semantics of a pointer that the function will -// dereference and output its value into. -// -// Inspired by the 'out' language keyword in C#. -// -// Declaration example: -// int do_work(size_t args, out<int> result); -// // returns 0 on success, sets result, otherwise error code -// -// Use-site example: -// // (1) -- out of a local variable or field -// int res; -// if (do_work(1, outof(res)) { -// cout << "success: " << res; -// } -// // (2) -- out of an iterator -// std::vector<int> list = {1}; -// std::vector<int>::iterator it = list.begin(); -// if (do_work(2, outof_iterator(*it)) { -// cout << "success: " << list[0]; -// } -// // (3) -- out of a pointer -// int* array = &some_other_value; -// if (do_work(3, outof_ptr(array))) { -// cout << "success: " << *array; -// } -// -// The type will also automatically decay into a C-style pointer for compatibility -// with calling legacy code that expect pointers. -// -// Declaration example: -// void write_data(int* res) { *res = 5; } -// -// Use-site example: -// int data; -// write_data(outof(res)); -// // data is now '5' -// (The other outof_* functions can be used analogously when the target is a C-style pointer). -// -// --------------- -// -// Other typical pointer operations such as addition, subtraction, etc are banned -// since there is exactly one value being output. -// -namespace art { - -// Forward declarations. See below for specific functions. -template <typename T> -struct out_convertible; // Implicitly converts to out<T> or T*. - -// Helper function that automatically infers 'T' -// -// Returns a type that is implicitly convertible to either out<T> or T* depending -// on the call site. -// -// Example: -// int do_work(size_t args, out<int> result); -// // returns 0 on success, sets result, otherwise error code -// -// Usage: -// int res; -// if (do_work(1, outof(res)) { -// cout << "success: " << res; -// } -template <typename T> -out_convertible<T> outof(T& param) ALWAYS_INLINE; - -// Helper function that automatically infers 'T' from a container<T>::iterator. -// To use when the argument is already inside an iterator. -// -// Returns a type that is implicitly convertible to either out<T> or T* depending -// on the call site. -// -// Example: -// int do_work(size_t args, out<int> result); -// // returns 0 on success, sets result, otherwise error code -// -// Usage: -// std::vector<int> list = {1}; -// std::vector<int>::iterator it = list.begin(); -// if (do_work(2, outof_iterator(*it)) { -// cout << "success: " << list[0]; -// } -template <typename It> -auto ALWAYS_INLINE outof_iterator(It iter) - -> out_convertible<typename std::remove_reference<decltype(*iter)>::type>; - -// Helper function that automatically infers 'T'. -// To use when the argument is already a pointer. -// -// ptr must be not-null, else a DCHECK failure will occur. -// -// Returns a type that is implicitly convertible to either out<T> or T* depending -// on the call site. -// -// Example: -// int do_work(size_t args, out<int> result); -// // returns 0 on success, sets result, otherwise error code -// -// Usage: -// int* array = &some_other_value; -// if (do_work(3, outof_ptr(array))) { -// cout << "success: " << *array; -// } -template <typename T> -out_convertible<T> outof_ptr(T* ptr) ALWAYS_INLINE; - -// Zero-overhead wrapper around a non-null non-const pointer meant to be used to output -// the result of parameters. There are no other extra guarantees. -// -// The most common use case is to treat this like a typical pointer argument, for example: -// -// void write_out_5(out<int> x) { -// *x = 5; -// } -// -// The following operations are supported: -// operator* -> use like a pointer (guaranteed to be non-null) -// == and != -> compare against other pointers for (in)equality -// begin/end -> use in standard C++ algorithms as if it was an iterator -template <typename T> -struct out { - // Has to be mutable lref. Otherwise how would you write something as output into it? - explicit inline out(T& param) - : param_(param) {} - - // Model a single-element iterator (or pointer) to the parameter. - inline T& operator *() { - return param_; - } - - // Model dereferencing fields/methods on a pointer. - inline T* operator->() { - return std::addressof(param_); - } - - // - // Comparison against this or other pointers. - // - template <typename T2> - inline bool operator==(const T2* other) const { - return std::addressof(param_) == other; - } - - template <typename T2> - inline bool operator==(const out<T>& other) const { - return std::addressof(param_) == std::addressof(other.param_); - } - - // An out-parameter is never null. - inline bool operator==(std::nullptr_t) const { - return false; - } - - template <typename T2> - inline bool operator!=(const T2* other) const { - return std::addressof(param_) != other; - } - - template <typename T2> - inline bool operator!=(const out<T>& other) const { - return std::addressof(param_) != std::addressof(other.param_); - } - - // An out-parameter is never null. - inline bool operator!=(std::nullptr_t) const { - return true; - } - - // - // Iterator interface implementation. Use with standard algorithms. - // TODO: (add items in iterator_traits if this is truly useful). - // - - inline T* begin() { - return std::addressof(param_); - } - - inline const T* begin() const { - return std::addressof(param_); - } - - inline T* end() { - return std::addressof(param_) + 1; - } - - inline const T* end() const { - return std::addressof(param_) + 1; - } - - private: - T& param_; -}; - -// -// IMPLEMENTATION DETAILS -// - -// -// This intermediate type should not be used directly by user code. -// -// It enables 'outof(x)' to be passed into functions that expect either -// an out<T> **or** a regular C-style pointer (T*). -// -template <typename T> -struct out_convertible { - explicit inline out_convertible(T& param) - : param_(param) { - } - - // Implicitly convert into an out<T> for standard usage. - inline operator out<T>() { - return out<T>(param_); - } - - // Implicitly convert into a '*' for legacy usage. - inline operator T*() { - return std::addressof(param_); - } - private: - T& param_; -}; - -// Helper function that automatically infers 'T' -template <typename T> -inline out_convertible<T> outof(T& param) { - return out_convertible<T>(param); -} - -// Helper function that automatically infers 'T'. -// To use when the argument is already inside an iterator. -template <typename It> -inline auto outof_iterator(It iter) - -> out_convertible<typename std::remove_reference<decltype(*iter)>::type> { - return outof(*iter); -} - -// Helper function that automatically infers 'T'. -// To use when the argument is already a pointer. -template <typename T> -inline out_convertible<T> outof_ptr(T* ptr) { - DCHECK(ptr != nullptr); - return outof(*ptr); -} - -// Helper function that automatically infers 'T'. -// Forwards an out parameter from one function into another. -template <typename T> -inline out_convertible<T> outof_forward(out<T>& out_param) { - T& param = *out_param; - return out_convertible<T>(param); -} - -} // namespace art -#endif // ART_RUNTIME_BASE_OUT_H_ diff --git a/runtime/base/out_fwd.h b/runtime/base/out_fwd.h deleted file mode 100644 index 6b2f926429..0000000000 --- a/runtime/base/out_fwd.h +++ /dev/null @@ -1,30 +0,0 @@ -/* - * Copyright (C) 2015 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef ART_RUNTIME_BASE_OUT_FWD_H_ -#define ART_RUNTIME_BASE_OUT_FWD_H_ - -// Forward declaration for "out<T>". See <out.h> for more information. -// Other headers use only the forward declaration. - -// Callers of functions that take an out<T> parameter should #include <out.h> to get outof_. -// which constructs out<T> through type inference. -namespace art { -template <typename T> -struct out; -} // namespace art - -#endif // ART_RUNTIME_BASE_OUT_FWD_H_ diff --git a/runtime/base/out_test.cc b/runtime/base/out_test.cc deleted file mode 100644 index 427420035b..0000000000 --- a/runtime/base/out_test.cc +++ /dev/null @@ -1,99 +0,0 @@ -/* - * Copyright (C) 2015 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#include "out.h" - -#include <algorithm> -#include <gtest/gtest.h> - -namespace art { - -struct OutTest : public testing::Test { - // Multiplies values less than 10 by two, stores the result and returns 0. - // Returns -1 if the original value was not multiplied by two. - static int multiply_small_values_by_two(size_t args, out<int> result) { - if (args < 10) { - *result = args * 2; - return 0; - } else { - return -1; - } - } -}; - -extern "C" int multiply_small_values_by_two_legacy(size_t args, int* result) { - if (args < 10) { - *result = args * 2; - return 0; - } else { - return -1; - } -} - -TEST_F(OutTest, TraditionalCall) { - // For calling traditional C++ functions. - int res; - EXPECT_EQ(multiply_small_values_by_two(1, outof(res)), 0); - EXPECT_EQ(2, res); -} - -TEST_F(OutTest, LegacyCall) { - // For calling legacy, e.g. C-style functions. - int res2; - EXPECT_EQ(0, multiply_small_values_by_two_legacy(1, outof(res2))); - EXPECT_EQ(2, res2); -} - -TEST_F(OutTest, CallFromIterator) { - // For calling a function with a parameter originating as an iterator. - std::vector<int> list = {1, 2, 3}; // NOLINT [whitespace/labels] [4] - std::vector<int>::iterator it = list.begin(); - - EXPECT_EQ(0, multiply_small_values_by_two(2, outof_iterator(it))); - EXPECT_EQ(4, list[0]); -} - -TEST_F(OutTest, CallFromPointer) { - // For calling a function with a parameter originating as a C-pointer. - std::vector<int> list = {1, 2, 3}; // NOLINT [whitespace/labels] [4] - - int* list_ptr = &list[2]; // 3 - - EXPECT_EQ(0, multiply_small_values_by_two(2, outof_ptr(list_ptr))); - EXPECT_EQ(4, list[2]); -} - -TEST_F(OutTest, OutAsIterator) { - // For using the out<T> parameter as an iterator inside of the callee. - std::vector<int> list; - int x = 100; - out<int> out_from_x = outof(x); - - for (const int& val : out_from_x) { - list.push_back(val); - } - - ASSERT_EQ(1u, list.size()); - EXPECT_EQ(100, list[0]); - - // A more typical use-case would be to use std algorithms - EXPECT_NE(out_from_x.end(), - std::find(out_from_x.begin(), - out_from_x.end(), - 100)); // Search for '100' in out. -} - -} // namespace art diff --git a/runtime/class_linker-inl.h b/runtime/class_linker-inl.h index c08417f542..11901b3bef 100644 --- a/runtime/class_linker-inl.h +++ b/runtime/class_linker-inl.h @@ -117,10 +117,8 @@ inline ArtMethod* ClassLinker::GetResolvedMethod(uint32_t method_idx, ArtMethod* return resolved_method; } -inline ArtMethod* ClassLinker::ResolveMethod(Thread* self, - uint32_t method_idx, - ArtMethod* referrer, - InvokeType type) { +inline ArtMethod* ClassLinker::ResolveMethod(Thread* self, uint32_t method_idx, + ArtMethod* referrer, InvokeType type) { ArtMethod* resolved_method = GetResolvedMethod(method_idx, referrer); if (UNLIKELY(resolved_method == nullptr)) { mirror::Class* declaring_class = referrer->GetDeclaringClass(); @@ -145,8 +143,7 @@ inline ArtField* ClassLinker::GetResolvedField( return GetResolvedField(field_idx, field_declaring_class->GetDexCache()); } -inline ArtField* ClassLinker::ResolveField(uint32_t field_idx, - ArtMethod* referrer, +inline ArtField* ClassLinker::ResolveField(uint32_t field_idx, ArtMethod* referrer, bool is_static) { mirror::Class* declaring_class = referrer->GetDeclaringClass(); ArtField* resolved_field = GetResolvedField(field_idx, declaring_class); diff --git a/runtime/class_linker.cc b/runtime/class_linker.cc index 82cf7afb18..56fae81512 100644 --- a/runtime/class_linker.cc +++ b/runtime/class_linker.cc @@ -30,7 +30,6 @@ #include "base/arena_allocator.h" #include "base/casts.h" #include "base/logging.h" -#include "base/out.h" #include "base/scoped_arena_containers.h" #include "base/scoped_flock.h" #include "base/stl_util.h" @@ -199,7 +198,7 @@ struct FieldGapsComparator { return lhs.size < rhs.size || (lhs.size == rhs.size && lhs.start_offset > rhs.start_offset); } }; -using FieldGaps = std::priority_queue<FieldGap, std::vector<FieldGap>, FieldGapsComparator>; +typedef std::priority_queue<FieldGap, std::vector<FieldGap>, FieldGapsComparator> FieldGaps; // Adds largest aligned gaps to queue of gaps. static void AddFieldGap(uint32_t gap_start, uint32_t gap_end, FieldGaps* gaps) { @@ -776,13 +775,12 @@ class DexFileAndClassPair : ValueObject { // be from multidex, which resolves correctly). }; -static void AddDexFilesFromOat(const OatFile* oat_file, - bool already_loaded, +static void AddDexFilesFromOat(const OatFile* oat_file, bool already_loaded, std::priority_queue<DexFileAndClassPair>* heap) { const std::vector<const OatDexFile*>& oat_dex_files = oat_file->GetOatDexFiles(); for (const OatDexFile* oat_dex_file : oat_dex_files) { std::string error; - std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(outof(error)); + std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error); if (dex_file.get() == nullptr) { LOG(WARNING) << "Could not create dex file from oat file: " << error; } else { @@ -838,7 +836,7 @@ const OatFile* ClassLinker::GetPrimaryOatFile() { // against the following top element. If the descriptor is the same, it is now checked whether // the two elements agree on whether their dex file was from an already-loaded oat-file or the // new oat file. Any disagreement indicates a collision. -bool ClassLinker::HasCollisions(const OatFile* oat_file, out<std::string> error_msg) { +bool ClassLinker::HasCollisions(const OatFile* oat_file, std::string* error_msg) { if (!kDuplicateClassesCheck) { return false; } @@ -903,9 +901,10 @@ bool ClassLinker::HasCollisions(const OatFile* oat_file, out<std::string> error_ } std::vector<std::unique_ptr<const DexFile>> ClassLinker::OpenDexFilesFromOat( - const char* dex_location, - const char* oat_location, - out<std::vector<std::string>> error_msgs) { + const char* dex_location, const char* oat_location, + std::vector<std::string>* error_msgs) { + CHECK(error_msgs != nullptr); + // Verify we aren't holding the mutator lock, which could starve GC if we // have to generate or relocate an oat file. Locks::mutator_lock_->AssertNotHeld(Thread::Current()); @@ -947,7 +946,7 @@ std::vector<std::unique_ptr<const DexFile>> ClassLinker::OpenDexFilesFromOat( std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile(); if (oat_file.get() != nullptr) { // Take the file only if it has no collisions, or we must take it because of preopting. - bool accept_oat_file = !HasCollisions(oat_file.get(), outof(error_msg)); + bool accept_oat_file = !HasCollisions(oat_file.get(), &error_msg); if (!accept_oat_file) { // Failed the collision check. Print warning. if (Runtime::Current()->IsDexFileFallbackEnabled()) { @@ -981,7 +980,8 @@ std::vector<std::unique_ptr<const DexFile>> ClassLinker::OpenDexFilesFromOat( if (source_oat_file != nullptr) { dex_files = oat_file_assistant.LoadDexFiles(*source_oat_file, dex_location); if (dex_files.empty()) { - error_msgs->push_back("Failed to open dex files from " + source_oat_file->GetLocation()); + error_msgs->push_back("Failed to open dex files from " + + source_oat_file->GetLocation()); } } @@ -1017,8 +1017,7 @@ const OatFile* ClassLinker::FindOpenedOatFileFromOatLocation(const std::string& return nullptr; } -static void SanityCheckArtMethod(ArtMethod* m, - mirror::Class* expected_class, +static void SanityCheckArtMethod(ArtMethod* m, mirror::Class* expected_class, gc::space::ImageSpace* space) SHARED_REQUIRES(Locks::mutator_lock_) { if (m->IsRuntimeMethod()) { @@ -1036,11 +1035,9 @@ static void SanityCheckArtMethod(ArtMethod* m, } } -static void SanityCheckArtMethodPointerArray(mirror::PointerArray* arr, - mirror::Class* expected_class, - size_t pointer_size, - gc::space::ImageSpace* space) - SHARED_REQUIRES(Locks::mutator_lock_) { +static void SanityCheckArtMethodPointerArray( + mirror::PointerArray* arr, mirror::Class* expected_class, size_t pointer_size, + gc::space::ImageSpace* space) SHARED_REQUIRES(Locks::mutator_lock_) { CHECK(arr != nullptr); for (int32_t j = 0; j < arr->GetLength(); ++j) { auto* method = arr->GetElementPtrSize<ArtMethod*>(j, pointer_size); @@ -1146,7 +1143,7 @@ void ClassLinker::InitFromImage() { nullptr); CHECK(oat_dex_file != nullptr) << oat_file.GetLocation() << " " << dex_file_location; std::string error_msg; - std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(outof(error_msg)); + std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg); if (dex_file.get() == nullptr) { LOG(FATAL) << "Failed to open dex file " << dex_file_location << " from within oat file " << oat_file.GetLocation() @@ -1506,8 +1503,7 @@ mirror::DexCache* ClassLinker::AllocDexCache(Thread* self, const DexFile& dex_fi return dex_cache.Get(); } -mirror::Class* ClassLinker::AllocClass(Thread* self, - mirror::Class* java_lang_Class, +mirror::Class* ClassLinker::AllocClass(Thread* self, mirror::Class* java_lang_Class, uint32_t class_size) { DCHECK_GE(class_size, sizeof(mirror::Class)); gc::Heap* heap = Runtime::Current()->GetHeap(); @@ -1526,14 +1522,13 @@ mirror::Class* ClassLinker::AllocClass(Thread* self, uint32_t class_size) { return AllocClass(self, GetClassRoot(kJavaLangClass), class_size); } -mirror::ObjectArray<mirror::StackTraceElement>* -ClassLinker::AllocStackTraceElementArray(Thread* self, size_t length) { +mirror::ObjectArray<mirror::StackTraceElement>* ClassLinker::AllocStackTraceElementArray( + Thread* self, size_t length) { return mirror::ObjectArray<mirror::StackTraceElement>::Alloc( self, GetClassRoot(kJavaLangStackTraceElementArrayClass), length); } -mirror::Class* ClassLinker::EnsureResolved(Thread* self, - const char* descriptor, +mirror::Class* ClassLinker::EnsureResolved(Thread* self, const char* descriptor, mirror::Class* klass) { DCHECK(klass != nullptr); @@ -1592,8 +1587,7 @@ typedef std::pair<const DexFile*, const DexFile::ClassDef*> ClassPathEntry; // Search a collection of DexFiles for a descriptor ClassPathEntry FindInClassPath(const char* descriptor, - size_t hash, - const std::vector<const DexFile*>& class_path) { + size_t hash, const std::vector<const DexFile*>& class_path) { for (const DexFile* dex_file : class_path) { const DexFile::ClassDef* dex_class_def = dex_file->FindClassDef(descriptor, hash); if (dex_class_def != nullptr) { @@ -1612,17 +1606,16 @@ static bool IsBootClassLoader(ScopedObjectAccessAlreadyRunnable& soa, } bool ClassLinker::FindClassInPathClassLoader(ScopedObjectAccessAlreadyRunnable& soa, - Thread* self, - const char* descriptor, + Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader, - out<mirror::Class*> result) { + mirror::Class** result) { // Termination case: boot class-loader. if (IsBootClassLoader(soa, class_loader.Get())) { // The boot class loader, search the boot class path. ClassPathEntry pair = FindInClassPath(descriptor, hash, boot_class_path_); if (pair.second != nullptr) { - mirror::Class* klass = LookupClass(self, descriptor, hash, nullptr /* no classloader */); + mirror::Class* klass = LookupClass(self, descriptor, hash, nullptr); if (klass != nullptr) { *result = EnsureResolved(self, descriptor, klass); } else { @@ -1724,8 +1717,7 @@ bool ClassLinker::FindClassInPathClassLoader(ScopedObjectAccessAlreadyRunnable& return true; } -mirror::Class* ClassLinker::FindClass(Thread* self, - const char* descriptor, +mirror::Class* ClassLinker::FindClass(Thread* self, const char* descriptor, Handle<mirror::ClassLoader> class_loader) { DCHECK_NE(*descriptor, '\0') << "descriptor is empty string"; DCHECK(self != nullptr); @@ -1761,7 +1753,7 @@ mirror::Class* ClassLinker::FindClass(Thread* self, } else { ScopedObjectAccessUnchecked soa(self); mirror::Class* cp_klass; - if (FindClassInPathClassLoader(soa, self, descriptor, hash, class_loader, outof(cp_klass))) { + if (FindClassInPathClassLoader(soa, self, descriptor, hash, class_loader, &cp_klass)) { // The chain was understood. So the value in cp_klass is either the class we were looking // for, or not found. if (cp_klass != nullptr) { @@ -1814,9 +1806,7 @@ mirror::Class* ClassLinker::FindClass(Thread* self, UNREACHABLE(); } -mirror::Class* ClassLinker::DefineClass(Thread* self, - const char* descriptor, - size_t hash, +mirror::Class* ClassLinker::DefineClass(Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader, const DexFile& dex_file, const DexFile::ClassDef& dex_class_def) { @@ -1902,7 +1892,7 @@ mirror::Class* ClassLinker::DefineClass(Thread* self, auto interfaces = hs.NewHandle<mirror::ObjectArray<mirror::Class>>(nullptr); MutableHandle<mirror::Class> h_new_class = hs.NewHandle<mirror::Class>(nullptr); - if (!LinkClass(self, descriptor, klass, interfaces, outof(h_new_class))) { + if (!LinkClass(self, descriptor, klass, interfaces, &h_new_class)) { // Linking failed. if (!klass->IsErroneous()) { mirror::Class::SetStatus(klass, mirror::Class::kStatusError, self); @@ -1985,9 +1975,8 @@ uint32_t ClassLinker::SizeOfClassWithoutEmbeddedTables(const DexFile& dex_file, image_pointer_size_); } -OatFile::OatClass ClassLinker::FindOatClass(const DexFile& dex_file, - uint16_t class_def_idx, - out<bool> found) { +OatFile::OatClass ClassLinker::FindOatClass(const DexFile& dex_file, uint16_t class_def_idx, + bool* found) { DCHECK_NE(class_def_idx, DexFile::kDexNoIndex16); const OatFile::OatDexFile* oat_dex_file = dex_file.GetOatDexFile(); if (oat_dex_file == nullptr) { @@ -1998,8 +1987,7 @@ OatFile::OatClass ClassLinker::FindOatClass(const DexFile& dex_file, return oat_dex_file->GetOatClass(class_def_idx); } -static uint32_t GetOatMethodIndexFromMethodIndex(const DexFile& dex_file, - uint16_t class_def_idx, +static uint32_t GetOatMethodIndexFromMethodIndex(const DexFile& dex_file, uint16_t class_def_idx, uint32_t method_idx) { const DexFile::ClassDef& class_def = dex_file.GetClassDef(class_def_idx); const uint8_t* class_data = dex_file.GetClassData(class_def); @@ -2033,7 +2021,7 @@ static uint32_t GetOatMethodIndexFromMethodIndex(const DexFile& dex_file, UNREACHABLE(); } -const OatFile::OatMethod ClassLinker::FindOatMethodFor(ArtMethod* method, out<bool> found) { +const OatFile::OatMethod ClassLinker::FindOatMethodFor(ArtMethod* method, bool* found) { // Although we overwrite the trampoline of non-static methods, we may get here via the resolution // method for direct methods (or virtual methods made direct). mirror::Class* declaring_class = method->GetDeclaringClass(); @@ -2065,7 +2053,7 @@ const OatFile::OatMethod ClassLinker::FindOatMethodFor(ArtMethod* method, out<bo method->GetDexMethodIndex())); OatFile::OatClass oat_class = FindOatClass(*declaring_class->GetDexCache()->GetDexFile(), declaring_class->GetDexClassDefIndex(), - outof_forward(found)); + found); if (!(*found)) { return OatFile::OatMethod::Invalid(); } @@ -2079,7 +2067,7 @@ const void* ClassLinker::GetQuickOatCodeFor(ArtMethod* method) { return GetQuickProxyInvokeHandler(); } bool found; - OatFile::OatMethod oat_method = FindOatMethodFor(method, outof(found)); + OatFile::OatMethod oat_method = FindOatMethodFor(method, &found); if (found) { auto* code = oat_method.GetQuickCode(); if (code != nullptr) { @@ -2105,7 +2093,7 @@ const void* ClassLinker::GetOatMethodQuickCodeFor(ArtMethod* method) { return nullptr; } bool found; - OatFile::OatMethod oat_method = FindOatMethodFor(method, outof(found)); + OatFile::OatMethod oat_method = FindOatMethodFor(method, &found); if (found) { return oat_method.GetQuickCode(); } @@ -2119,11 +2107,10 @@ const void* ClassLinker::GetOatMethodQuickCodeFor(ArtMethod* method) { return nullptr; } -const void* ClassLinker::GetQuickOatCodeFor(const DexFile& dex_file, - uint16_t class_def_idx, +const void* ClassLinker::GetQuickOatCodeFor(const DexFile& dex_file, uint16_t class_def_idx, uint32_t method_idx) { bool found; - OatFile::OatClass oat_class = FindOatClass(dex_file, class_def_idx, outof(found)); + OatFile::OatClass oat_class = FindOatClass(dex_file, class_def_idx, &found); if (!found) { return nullptr; } @@ -2174,7 +2161,7 @@ void ClassLinker::FixupStaticTrampolines(mirror::Class* klass) { } bool has_oat_class; OatFile::OatClass oat_class = FindOatClass(dex_file, klass->GetDexClassDefIndex(), - outof(has_oat_class)); + &has_oat_class); // Link the code of methods skipped by LinkCode. for (size_t method_index = 0; it.HasNextDirectMethod(); ++method_index, it.Next()) { ArtMethod* method = klass->GetDirectMethod(method_index, image_pointer_size_); @@ -2202,8 +2189,7 @@ void ClassLinker::FixupStaticTrampolines(mirror::Class* klass) { // Ignore virtual methods on the iterator. } -void ClassLinker::LinkCode(ArtMethod* method, - const OatFile::OatClass* oat_class, +void ClassLinker::LinkCode(ArtMethod* method, const OatFile::OatClass* oat_class, uint32_t class_def_method_index) { Runtime* const runtime = Runtime::Current(); if (runtime->IsAotCompiler()) { @@ -2255,10 +2241,8 @@ void ClassLinker::LinkCode(ArtMethod* method, } } -void ClassLinker::SetupClass(const DexFile& dex_file, - const DexFile::ClassDef& dex_class_def, - Handle<mirror::Class> klass, - mirror::ClassLoader* class_loader) { +void ClassLinker::SetupClass(const DexFile& dex_file, const DexFile::ClassDef& dex_class_def, + Handle<mirror::Class> klass, mirror::ClassLoader* class_loader) { CHECK(klass.Get() != nullptr); CHECK(klass->GetDexCache() != nullptr); CHECK_EQ(mirror::Class::kStatusNotReady, klass->GetStatus()); @@ -2278,8 +2262,7 @@ void ClassLinker::SetupClass(const DexFile& dex_file, CHECK(klass->GetDexCacheStrings() != nullptr); } -void ClassLinker::LoadClass(Thread* self, - const DexFile& dex_file, +void ClassLinker::LoadClass(Thread* self, const DexFile& dex_file, const DexFile::ClassDef& dex_class_def, Handle<mirror::Class> klass) { const uint8_t* class_data = dex_file.GetClassData(dex_class_def); @@ -2289,7 +2272,7 @@ void ClassLinker::LoadClass(Thread* self, bool has_oat_class = false; if (Runtime::Current()->IsStarted() && !Runtime::Current()->IsAotCompiler()) { OatFile::OatClass oat_class = FindOatClass(dex_file, klass->GetDexClassDefIndex(), - outof(has_oat_class)); + &has_oat_class); if (has_oat_class) { LoadClassMembers(self, dex_file, class_data, klass, &oat_class); } @@ -2318,8 +2301,7 @@ ArtMethod* ClassLinker::AllocArtMethodArray(Thread* self, size_t length) { return reinterpret_cast<ArtMethod*>(ptr); } -void ClassLinker::LoadClassMembers(Thread* self, - const DexFile& dex_file, +void ClassLinker::LoadClassMembers(Thread* self, const DexFile& dex_file, const uint8_t* class_data, Handle<mirror::Class> klass, const OatFile::OatClass* oat_class) { @@ -2414,8 +2396,7 @@ void ClassLinker::LoadClassMembers(Thread* self, self->AllowThreadSuspension(); } -void ClassLinker::LoadField(const ClassDataItemIterator& it, - Handle<mirror::Class> klass, +void ClassLinker::LoadField(const ClassDataItemIterator& it, Handle<mirror::Class> klass, ArtField* dst) { const uint32_t field_idx = it.GetMemberIndex(); dst->SetDexFieldIndex(field_idx); @@ -2423,11 +2404,8 @@ void ClassLinker::LoadField(const ClassDataItemIterator& it, dst->SetAccessFlags(it.GetFieldAccessFlags()); } -void ClassLinker::LoadMethod(Thread* self, - const DexFile& dex_file, - const ClassDataItemIterator& it, - Handle<mirror::Class> klass, - ArtMethod* dst) { +void ClassLinker::LoadMethod(Thread* self, const DexFile& dex_file, const ClassDataItemIterator& it, + Handle<mirror::Class> klass, ArtMethod* dst) { uint32_t dex_method_idx = it.GetMemberIndex(); const DexFile::MethodId& method_id = dex_file.GetMethodId(dex_method_idx); const char* method_name = dex_file.StringDataByIdx(method_id.name_idx_); @@ -2627,9 +2605,7 @@ mirror::Class* ClassLinker::InitializePrimitiveClass(mirror::Class* primitive_cl // array class; that always comes from the base element class. // // Returns null with an exception raised on failure. -mirror::Class* ClassLinker::CreateArrayClass(Thread* self, - const char* descriptor, - size_t hash, +mirror::Class* ClassLinker::CreateArrayClass(Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader) { // Identify the underlying component type CHECK_EQ('[', descriptor[0]); @@ -2831,8 +2807,7 @@ mirror::Class* ClassLinker::InsertClass(const char* descriptor, mirror::Class* k return nullptr; } -void ClassLinker::UpdateClassVirtualMethods(mirror::Class* klass, - ArtMethod* new_methods, +void ClassLinker::UpdateClassVirtualMethods(mirror::Class* klass, ArtMethod* new_methods, size_t new_num_methods) { // TODO: Fix the race condition here. b/22832610 klass->SetNumVirtualMethods(new_num_methods); @@ -2847,9 +2822,7 @@ bool ClassLinker::RemoveClass(const char* descriptor, mirror::ClassLoader* class return class_table != nullptr && class_table->Remove(descriptor); } -mirror::Class* ClassLinker::LookupClass(Thread* self, - const char* descriptor, - size_t hash, +mirror::Class* ClassLinker::LookupClass(Thread* self, const char* descriptor, size_t hash, mirror::ClassLoader* class_loader) { { ReaderMutexLock mu(self, *Locks::classlinker_classes_lock_); @@ -2953,9 +2926,7 @@ mirror::Class* ClassLinker::LookupClassFromImage(const char* descriptor) { return nullptr; } -void ClassLinker::LookupClasses(const char* descriptor, - out<std::vector<mirror::Class*>> out_result) { - std::vector<mirror::Class*>& result = *out_result; +void ClassLinker::LookupClasses(const char* descriptor, std::vector<mirror::Class*>& result) { result.clear(); if (dex_cache_image_class_lookup_required_) { MoveImageClassesToClassTable(); @@ -3132,8 +3103,7 @@ void ClassLinker::EnsurePreverifiedMethods(Handle<mirror::Class> klass) { } } -bool ClassLinker::VerifyClassUsingOatFile(const DexFile& dex_file, - mirror::Class* klass, +bool ClassLinker::VerifyClassUsingOatFile(const DexFile& dex_file, mirror::Class* klass, mirror::Class::Status& oat_file_class_status) { // If we're compiling, we can only verify the class using the oat file if // we are not compiling the image or if the class we're verifying is not part of @@ -3255,12 +3225,9 @@ void ClassLinker::ResolveMethodExceptionHandlerTypes(const DexFile& dex_file, } } -mirror::Class* ClassLinker::CreateProxyClass(ScopedObjectAccessAlreadyRunnable& soa, - jstring name, - jobjectArray interfaces, - jobject loader, - jobjectArray methods, - jobjectArray throws) { +mirror::Class* ClassLinker::CreateProxyClass(ScopedObjectAccessAlreadyRunnable& soa, jstring name, + jobjectArray interfaces, jobject loader, + jobjectArray methods, jobjectArray throws) { Thread* self = soa.Self(); StackHandleScope<10> hs(self); MutableHandle<mirror::Class> klass(hs.NewHandle( @@ -3355,7 +3322,7 @@ mirror::Class* ClassLinker::CreateProxyClass(ScopedObjectAccessAlreadyRunnable& // The new class will replace the old one in the class table. Handle<mirror::ObjectArray<mirror::Class>> h_interfaces( hs.NewHandle(soa.Decode<mirror::ObjectArray<mirror::Class>*>(interfaces))); - if (!LinkClass(self, descriptor.c_str(), klass, h_interfaces, outof(new_class))) { + if (!LinkClass(self, descriptor.c_str(), klass, h_interfaces, &new_class)) { mirror::Class::SetStatus(klass, mirror::Class::kStatusError, self); return nullptr; } @@ -3460,8 +3427,7 @@ void ClassLinker::CheckProxyConstructor(ArtMethod* constructor) const { DCHECK(constructor->IsPublic()); } -void ClassLinker::CreateProxyMethod(Handle<mirror::Class> klass, - ArtMethod* prototype, +void ClassLinker::CreateProxyMethod(Handle<mirror::Class> klass, ArtMethod* prototype, ArtMethod* out) { // Ensure prototype is in dex cache so that we can use the dex cache to look up the overridden // prototype method @@ -3507,8 +3473,7 @@ void ClassLinker::CheckProxyMethod(ArtMethod* method, ArtMethod* prototype) cons CHECK_EQ(np->GetReturnType(), prototype->GetReturnType()); } -bool ClassLinker::CanWeInitializeClass(mirror::Class* klass, - bool can_init_statics, +bool ClassLinker::CanWeInitializeClass(mirror::Class* klass, bool can_init_statics, bool can_init_parents) { if (can_init_statics && can_init_parents) { return true; @@ -3538,10 +3503,8 @@ bool ClassLinker::CanWeInitializeClass(mirror::Class* klass, return CanWeInitializeClass(super_class, can_init_statics, can_init_parents); } -bool ClassLinker::InitializeClass(Thread* self, - Handle<mirror::Class> klass, - bool can_init_statics, - bool can_init_parents) { +bool ClassLinker::InitializeClass(Thread* self, Handle<mirror::Class> klass, + bool can_init_statics, bool can_init_parents) { // see JLS 3rd edition, 12.4.2 "Detailed Initialization Procedure" for the locking protocol // Are we already initialized and therefore done? @@ -3610,7 +3573,7 @@ bool ClassLinker::InitializeClass(Thread* self, return true; } // No. That's fine. Wait for another thread to finish initializing. - return WaitForInitializeClass(klass, self, &lock); + return WaitForInitializeClass(klass, self, lock); } if (!ValidateSuperClassDescriptors(klass)) { @@ -3744,16 +3707,13 @@ bool ClassLinker::InitializeClass(Thread* self, return success; } -bool ClassLinker::WaitForInitializeClass(Handle<mirror::Class> klass, - Thread* self, - ObjectLock<mirror::Class>* lock) +bool ClassLinker::WaitForInitializeClass(Handle<mirror::Class> klass, Thread* self, + ObjectLock<mirror::Class>& lock) SHARED_REQUIRES(Locks::mutator_lock_) { - DCHECK(lock != nullptr); - while (true) { self->AssertNoPendingException(); CHECK(!klass->IsInitialized()); - lock->WaitIgnoringInterrupts(); + lock.WaitIgnoringInterrupts(); // When we wake up, repeat the test for init-in-progress. If // there's an exception pending (only possible if @@ -3816,8 +3776,7 @@ static void ThrowSignatureCheckResolveArgException(Handle<mirror::Class> klass, Handle<mirror::Class> super_klass, ArtMethod* method, ArtMethod* m, - uint32_t index, - uint32_t arg_type_idx) + uint32_t index, uint32_t arg_type_idx) SHARED_REQUIRES(Locks::mutator_lock_) { DCHECK(Thread::Current()->IsExceptionPending()); DCHECK(!m->IsProxyMethod()); @@ -3979,8 +3938,7 @@ bool ClassLinker::ValidateSuperClassDescriptors(Handle<mirror::Class> klass) { return true; } -bool ClassLinker::EnsureInitialized(Thread* self, Handle<mirror::Class> c, - bool can_init_fields, +bool ClassLinker::EnsureInitialized(Thread* self, Handle<mirror::Class> c, bool can_init_fields, bool can_init_parents) { DCHECK(c.Get() != nullptr); if (c->IsInitialized()) { @@ -4054,11 +4012,9 @@ ClassTable* ClassLinker::ClassTableForClassLoader(mirror::ClassLoader* class_loa return nullptr; } -bool ClassLinker::LinkClass(Thread* self, - const char* descriptor, - Handle<mirror::Class> klass, +bool ClassLinker::LinkClass(Thread* self, const char* descriptor, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<MutableHandle<mirror::Class>> h_new_class_out) { + MutableHandle<mirror::Class>* h_new_class_out) { CHECK_EQ(mirror::Class::kStatusLoaded, klass->GetStatus()); if (!LinkSuperClass(klass)) { @@ -4066,14 +4022,14 @@ bool ClassLinker::LinkClass(Thread* self, } ArtMethod* imt[mirror::Class::kImtSize]; std::fill_n(imt, arraysize(imt), Runtime::Current()->GetImtUnimplementedMethod()); - if (!LinkMethods(self, klass, interfaces, outof(imt))) { + if (!LinkMethods(self, klass, interfaces, imt)) { return false; } if (!LinkInstanceFields(self, klass)) { return false; } size_t class_size; - if (!LinkStaticFields(self, klass, outof(class_size))) { + if (!LinkStaticFields(self, klass, &class_size)) { return false; } CreateReferenceInstanceOffsets(klass); @@ -4149,31 +4105,30 @@ bool ClassLinker::LinkClass(Thread* self, return true; } -static void CountMethodsAndFields(ClassDataItemIterator* dex_data, - out<size_t> virtual_methods, - out<size_t> direct_methods, - out<size_t> static_fields, - out<size_t> instance_fields) { - DCHECK(dex_data != nullptr); +static void CountMethodsAndFields(ClassDataItemIterator& dex_data, + size_t* virtual_methods, + size_t* direct_methods, + size_t* static_fields, + size_t* instance_fields) { *virtual_methods = *direct_methods = *static_fields = *instance_fields = 0; - while (dex_data->HasNextStaticField()) { - dex_data->Next(); + while (dex_data.HasNextStaticField()) { + dex_data.Next(); (*static_fields)++; } - while (dex_data->HasNextInstanceField()) { - dex_data->Next(); + while (dex_data.HasNextInstanceField()) { + dex_data.Next(); (*instance_fields)++; } - while (dex_data->HasNextDirectMethod()) { + while (dex_data.HasNextDirectMethod()) { (*direct_methods)++; - dex_data->Next(); + dex_data.Next(); } - while (dex_data->HasNextVirtualMethod()) { + while (dex_data.HasNextVirtualMethod()) { (*virtual_methods)++; - dex_data->Next(); + dex_data.Next(); } - DCHECK(!dex_data->HasNext()); + DCHECK(!dex_data.HasNext()); } static void DumpClass(std::ostream& os, @@ -4207,10 +4162,8 @@ static void DumpClass(std::ostream& os, } } -static std::string DumpClasses(const DexFile& dex_file1, - const DexFile::ClassDef& dex_class_def1, - const DexFile& dex_file2, - const DexFile::ClassDef& dex_class_def2) { +static std::string DumpClasses(const DexFile& dex_file1, const DexFile::ClassDef& dex_class_def1, + const DexFile& dex_file2, const DexFile::ClassDef& dex_class_def2) { std::ostringstream os; DumpClass(os, dex_file1, dex_class_def1, " (Compile time)"); DumpClass(os, dex_file2, dex_class_def2, " (Runtime)"); @@ -4220,28 +4173,20 @@ static std::string DumpClasses(const DexFile& dex_file1, // Very simple structural check on whether the classes match. Only compares the number of // methods and fields. -static bool SimpleStructuralCheck(const DexFile& dex_file1, - const DexFile::ClassDef& dex_class_def1, - const DexFile& dex_file2, - const DexFile::ClassDef& dex_class_def2, +static bool SimpleStructuralCheck(const DexFile& dex_file1, const DexFile::ClassDef& dex_class_def1, + const DexFile& dex_file2, const DexFile::ClassDef& dex_class_def2, std::string* error_msg) { ClassDataItemIterator dex_data1(dex_file1, dex_file1.GetClassData(dex_class_def1)); ClassDataItemIterator dex_data2(dex_file2, dex_file2.GetClassData(dex_class_def2)); // Counters for current dex file. size_t dex_virtual_methods1, dex_direct_methods1, dex_static_fields1, dex_instance_fields1; - CountMethodsAndFields(&dex_data1, - outof(dex_virtual_methods1), - outof(dex_direct_methods1), - outof(dex_static_fields1), - outof(dex_instance_fields1)); + CountMethodsAndFields(dex_data1, &dex_virtual_methods1, &dex_direct_methods1, &dex_static_fields1, + &dex_instance_fields1); // Counters for compile-time dex file. size_t dex_virtual_methods2, dex_direct_methods2, dex_static_fields2, dex_instance_fields2; - CountMethodsAndFields(&dex_data2, - outof(dex_virtual_methods2), - outof(dex_direct_methods2), - outof(dex_static_fields2), - outof(dex_instance_fields2)); + CountMethodsAndFields(dex_data2, &dex_virtual_methods2, &dex_direct_methods2, &dex_static_fields2, + &dex_instance_fields2); if (dex_virtual_methods1 != dex_virtual_methods2) { std::string class_dump = DumpClasses(dex_file1, dex_class_def1, dex_file2, dex_class_def2); @@ -4444,10 +4389,9 @@ bool ClassLinker::LinkSuperClass(Handle<mirror::Class> klass) { } // Populate the class vtable and itable. Compute return type indices. -bool ClassLinker::LinkMethods(Thread* self, - Handle<mirror::Class> klass, +bool ClassLinker::LinkMethods(Thread* self, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<ArtMethod* [mirror::Class::kImtSize]> out_imt) { + ArtMethod** out_imt) { self->AllowThreadSuspension(); if (klass->IsInterface()) { // No vtable. @@ -4462,10 +4406,7 @@ bool ClassLinker::LinkMethods(Thread* self, } else if (!LinkVirtualMethods(self, klass)) { // Link virtual methods first. return false; } - return LinkInterfaceMethods(self, - klass, - interfaces, - outof_forward(out_imt)); // Link interface method last. + return LinkInterfaceMethods(self, klass, interfaces, out_imt); // Link interface method last. } // Comparator for name and signature of a method, used in finding overriding methods. Implementation @@ -4518,9 +4459,7 @@ class MethodNameAndSignatureComparator FINAL : public ValueObject { class LinkVirtualHashTable { public: - LinkVirtualHashTable(Handle<mirror::Class> klass, - size_t hash_size, - uint32_t* hash_table, + LinkVirtualHashTable(Handle<mirror::Class> klass, size_t hash_size, uint32_t* hash_table, size_t image_pointer_size) : klass_(klass), hash_size_(hash_size), hash_table_(hash_table), image_pointer_size_(image_pointer_size) { @@ -4724,12 +4663,9 @@ bool ClassLinker::LinkVirtualMethods(Thread* self, Handle<mirror::Class> klass) return true; } -bool ClassLinker::LinkInterfaceMethods(Thread* self, - Handle<mirror::Class> klass, +bool ClassLinker::LinkInterfaceMethods(Thread* self, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<ArtMethod* [mirror::Class::kImtSize]> out_imt_array) { - auto& out_imt = *out_imt_array; - + ArtMethod** out_imt) { StackHandleScope<3> hs(self); Runtime* const runtime = Runtime::Current(); const bool has_superclass = klass->HasSuperClass(); @@ -4917,7 +4853,7 @@ bool ClassLinker::LinkInterfaceMethods(Thread* self, } } - const char* old_cause = self->StartAssertNoThreadSuspension( + auto* old_cause = self->StartAssertNoThreadSuspension( "Copying ArtMethods for LinkInterfaceMethods"); for (size_t i = 0; i < ifcount; ++i) { size_t num_methods = iftable->GetInterface(i)->NumVirtualMethods(); @@ -5138,16 +5074,12 @@ bool ClassLinker::LinkInterfaceMethods(Thread* self, bool ClassLinker::LinkInstanceFields(Thread* self, Handle<mirror::Class> klass) { CHECK(klass.Get() != nullptr); - size_t class_size_dont_care; - UNUSED(class_size_dont_care); // This doesn't get set for instance fields. - return LinkFields(self, klass, false, outof(class_size_dont_care)); + return LinkFields(self, klass, false, nullptr); } -bool ClassLinker::LinkStaticFields(Thread* self, - Handle<mirror::Class> klass, - out<size_t> class_size) { +bool ClassLinker::LinkStaticFields(Thread* self, Handle<mirror::Class> klass, size_t* class_size) { CHECK(klass.Get() != nullptr); - return LinkFields(self, klass, true, outof_forward(class_size)); + return LinkFields(self, klass, true, class_size); } struct LinkFieldsComparator { @@ -5184,10 +5116,8 @@ struct LinkFieldsComparator { } }; -bool ClassLinker::LinkFields(Thread* self, - Handle<mirror::Class> klass, - bool is_static, - out<size_t> class_size) { +bool ClassLinker::LinkFields(Thread* self, Handle<mirror::Class> klass, bool is_static, + size_t* class_size) { self->AllowThreadSuspension(); const size_t num_fields = is_static ? klass->NumStaticFields() : klass->NumInstanceFields(); ArtField* const fields = is_static ? klass->GetSFields() : klass->GetIFields(); @@ -5358,8 +5288,7 @@ void ClassLinker::CreateReferenceInstanceOffsets(Handle<mirror::Class> klass) { klass->SetReferenceInstanceOffsets(reference_offsets); } -mirror::String* ClassLinker::ResolveString(const DexFile& dex_file, - uint32_t string_idx, +mirror::String* ClassLinker::ResolveString(const DexFile& dex_file, uint32_t string_idx, Handle<mirror::DexCache> dex_cache) { DCHECK(dex_cache.Get() != nullptr); mirror::String* resolved = dex_cache->GetResolvedString(string_idx); @@ -5373,8 +5302,7 @@ mirror::String* ClassLinker::ResolveString(const DexFile& dex_file, return string; } -mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, - uint16_t type_idx, +mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, uint16_t type_idx, mirror::Class* referrer) { StackHandleScope<2> hs(Thread::Current()); Handle<mirror::DexCache> dex_cache(hs.NewHandle(referrer->GetDexCache())); @@ -5382,8 +5310,7 @@ mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, return ResolveType(dex_file, type_idx, dex_cache, class_loader); } -mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, - uint16_t type_idx, +mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, uint16_t type_idx, Handle<mirror::DexCache> dex_cache, Handle<mirror::ClassLoader> class_loader) { DCHECK(dex_cache.Get() != nullptr); @@ -5416,8 +5343,7 @@ mirror::Class* ClassLinker::ResolveType(const DexFile& dex_file, return resolved; } -ArtMethod* ClassLinker::ResolveMethod(const DexFile& dex_file, - uint32_t method_idx, +ArtMethod* ClassLinker::ResolveMethod(const DexFile& dex_file, uint32_t method_idx, Handle<mirror::DexCache> dex_cache, Handle<mirror::ClassLoader> class_loader, ArtMethod* referrer, InvokeType type) { @@ -5574,11 +5500,9 @@ ArtMethod* ClassLinker::ResolveMethod(const DexFile& dex_file, } } -ArtField* ClassLinker::ResolveField(const DexFile& dex_file, - uint32_t field_idx, +ArtField* ClassLinker::ResolveField(const DexFile& dex_file, uint32_t field_idx, Handle<mirror::DexCache> dex_cache, - Handle<mirror::ClassLoader> class_loader, - bool is_static) { + Handle<mirror::ClassLoader> class_loader, bool is_static) { DCHECK(dex_cache.Get() != nullptr); ArtField* resolved = dex_cache->GetResolvedField(field_idx, image_pointer_size_); if (resolved != nullptr) { @@ -5617,8 +5541,7 @@ ArtField* ClassLinker::ResolveField(const DexFile& dex_file, return resolved; } -ArtField* ClassLinker::ResolveFieldJLS(const DexFile& dex_file, - uint32_t field_idx, +ArtField* ClassLinker::ResolveFieldJLS(const DexFile& dex_file, uint32_t field_idx, Handle<mirror::DexCache> dex_cache, Handle<mirror::ClassLoader> class_loader) { DCHECK(dex_cache.Get() != nullptr); @@ -5648,8 +5571,7 @@ ArtField* ClassLinker::ResolveFieldJLS(const DexFile& dex_file, return resolved; } -const char* ClassLinker::MethodShorty(uint32_t method_idx, - ArtMethod* referrer, +const char* ClassLinker::MethodShorty(uint32_t method_idx, ArtMethod* referrer, uint32_t* length) { mirror::Class* declaring_class = referrer->GetDeclaringClass(); mirror::DexCache* dex_cache = declaring_class->GetDexCache(); @@ -5856,8 +5778,7 @@ bool ClassLinker::MayBeCalledWithDirectCodePointer(ArtMethod* m) { } } -jobject ClassLinker::CreatePathClassLoader(Thread* self, - const std::vector<const DexFile*>& dex_files) { +jobject ClassLinker::CreatePathClassLoader(Thread* self, std::vector<const DexFile*>& dex_files) { // SOAAlreadyRunnable is protected, and we need something to add a global reference. // We could move the jobject to the callers, but all call-sites do this... ScopedObjectAccessUnchecked soa(self); diff --git a/runtime/class_linker.h b/runtime/class_linker.h index 54f1f3dac8..c53ff616e5 100644 --- a/runtime/class_linker.h +++ b/runtime/class_linker.h @@ -25,7 +25,6 @@ #include "base/hash_set.h" #include "base/macros.h" #include "base/mutex.h" -#include "base/out_fwd.h" #include "class_table.h" #include "dex_file.h" #include "gc_root.h" @@ -109,19 +108,16 @@ class ClassLinker { // Initialize class linker by bootstraping from dex files. void InitWithoutImage(std::vector<std::unique_ptr<const DexFile>> boot_class_path) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Initialize class linker from one or more images. void InitFromImage() SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Finds a class by its descriptor, loading it if necessary. // If class_loader is null, searches boot_class_path_. - mirror::Class* FindClass(Thread* self, - const char* descriptor, + mirror::Class* FindClass(Thread* self, const char* descriptor, Handle<mirror::ClassLoader> class_loader) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Finds a class in the path class loader, loading it if necessary without using JNI. Hash // function is supposed to be ComputeModifiedUtf8Hash(descriptor). Returns true if the @@ -129,24 +125,19 @@ class ClassLinker { // was encountered while walking the parent chain (currently only BootClassLoader and // PathClassLoader are supported). bool FindClassInPathClassLoader(ScopedObjectAccessAlreadyRunnable& soa, - Thread* self, - const char* descriptor, - size_t hash, + Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader, - out<mirror::Class*> result) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + mirror::Class** result) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Finds a class by its descriptor using the "system" class loader, ie by searching the // boot_class_path_. mirror::Class* FindSystemClass(Thread* self, const char* descriptor) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Finds the array class given for the element class. - mirror::Class* FindArrayClass(Thread* self, /* in parameter */ mirror::Class** element_class) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + mirror::Class* FindArrayClass(Thread* self, mirror::Class** element_class) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Returns true if the class linker is initialized. bool IsInitialized() const { @@ -154,27 +145,20 @@ class ClassLinker { } // Define a new a class based on a ClassDef from a DexFile - mirror::Class* DefineClass(Thread* self, - const char* descriptor, - size_t hash, + mirror::Class* DefineClass(Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader, - const DexFile& dex_file, - const DexFile::ClassDef& dex_class_def) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + const DexFile& dex_file, const DexFile::ClassDef& dex_class_def) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Finds a class by its descriptor, returning null if it isn't wasn't loaded // by the given 'class_loader'. - mirror::Class* LookupClass(Thread* self, - const char* descriptor, - size_t hash, - mirror::ClassLoader* - class_loader) + mirror::Class* LookupClass(Thread* self, const char* descriptor, size_t hash, + mirror::ClassLoader* class_loader) REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); // Finds all the classes with the given descriptor, regardless of ClassLoader. - void LookupClasses(const char* descriptor, out<std::vector<mirror::Class*>> classes) + void LookupClasses(const char* descriptor, std::vector<mirror::Class*>& classes) REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); @@ -182,21 +166,17 @@ class ClassLinker { // General class unloading is not supported, this is used to prune // unwanted classes during image writing. - bool RemoveClass(const char* descriptor, - mirror::ClassLoader* class_loader) - REQUIRES(!Locks::classlinker_classes_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + bool RemoveClass(const char* descriptor, mirror::ClassLoader* class_loader) + REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); void DumpAllClasses(int flags) - REQUIRES(!Locks::classlinker_classes_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); void DumpForSigQuit(std::ostream& os) REQUIRES(!Locks::classlinker_classes_lock_); size_t NumLoadedClasses() - REQUIRES(!Locks::classlinker_classes_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); // Resolve a String with the given index from the DexFile, storing the // result in the DexCache. The referrer is used to identify the @@ -206,95 +186,75 @@ class ClassLinker { // Resolve a String with the given index from the DexFile, storing the // result in the DexCache. - mirror::String* ResolveString(const DexFile& dex_file, - uint32_t string_idx, + mirror::String* ResolveString(const DexFile& dex_file, uint32_t string_idx, Handle<mirror::DexCache> dex_cache) SHARED_REQUIRES(Locks::mutator_lock_); // Resolve a Type with the given index from the DexFile, storing the // result in the DexCache. The referrer is used to identity the // target DexCache and ClassLoader to use for resolution. - mirror::Class* ResolveType(const DexFile& dex_file, - uint16_t type_idx, - mirror::Class* referrer) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + mirror::Class* ResolveType(const DexFile& dex_file, uint16_t type_idx, mirror::Class* referrer) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Resolve a Type with the given index from the DexFile, storing the // result in the DexCache. The referrer is used to identify the // target DexCache and ClassLoader to use for resolution. - mirror::Class* ResolveType(uint16_t type_idx, - ArtMethod* referrer) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + mirror::Class* ResolveType(uint16_t type_idx, ArtMethod* referrer) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); - mirror::Class* ResolveType(uint16_t type_idx, - ArtField* referrer) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + mirror::Class* ResolveType(uint16_t type_idx, ArtField* referrer) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Resolve a type with the given ID from the DexFile, storing the // result in DexCache. The ClassLoader is used to search for the // type, since it may be referenced from but not contained within // the given DexFile. - mirror::Class* ResolveType(const DexFile& dex_file, - uint16_t type_idx, + mirror::Class* ResolveType(const DexFile& dex_file, uint16_t type_idx, Handle<mirror::DexCache> dex_cache, Handle<mirror::ClassLoader> class_loader) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Resolve a method with a given ID from the DexFile, storing the // result in DexCache. The ClassLinker and ClassLoader are used as // in ResolveType. What is unique is the method type argument which // is used to determine if this method is a direct, static, or // virtual method. - ArtMethod* ResolveMethod(const DexFile& dex_file, - uint32_t method_idx, + ArtMethod* ResolveMethod(const DexFile& dex_file, uint32_t method_idx, Handle<mirror::DexCache> dex_cache, - Handle<mirror::ClassLoader> class_loader, - ArtMethod* referrer, + Handle<mirror::ClassLoader> class_loader, ArtMethod* referrer, InvokeType type) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); ArtMethod* GetResolvedMethod(uint32_t method_idx, ArtMethod* referrer) SHARED_REQUIRES(Locks::mutator_lock_); ArtMethod* ResolveMethod(Thread* self, uint32_t method_idx, ArtMethod* referrer, InvokeType type) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); ArtField* GetResolvedField(uint32_t field_idx, mirror::Class* field_declaring_class) SHARED_REQUIRES(Locks::mutator_lock_); ArtField* GetResolvedField(uint32_t field_idx, mirror::DexCache* dex_cache) SHARED_REQUIRES(Locks::mutator_lock_); ArtField* ResolveField(uint32_t field_idx, ArtMethod* referrer, bool is_static) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Resolve a field with a given ID from the DexFile, storing the // result in DexCache. The ClassLinker and ClassLoader are used as // in ResolveType. What is unique is the is_static argument which is // used to determine if we are resolving a static or non-static // field. - ArtField* ResolveField(const DexFile& dex_file, - uint32_t field_idx, + ArtField* ResolveField(const DexFile& dex_file, uint32_t field_idx, Handle<mirror::DexCache> dex_cache, - Handle<mirror::ClassLoader> class_loader, - bool is_static) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + Handle<mirror::ClassLoader> class_loader, bool is_static) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Resolve a field with a given ID from the DexFile, storing the // result in DexCache. The ClassLinker and ClassLoader are used as // in ResolveType. No is_static argument is provided so that Java // field resolution semantics are followed. - ArtField* ResolveFieldJLS(const DexFile& dex_file, - uint32_t field_idx, + ArtField* ResolveFieldJLS(const DexFile& dex_file, uint32_t field_idx, Handle<mirror::DexCache> dex_cache, Handle<mirror::ClassLoader> class_loader) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Get shorty from method index without resolution. Used to do handlerization. const char* MethodShorty(uint32_t method_idx, ArtMethod* referrer, uint32_t* length) @@ -303,12 +263,9 @@ class ClassLinker { // Returns true on success, false if there's an exception pending. // can_run_clinit=false allows the compiler to attempt to init a class, // given the restriction that no <clinit> execution is possible. - bool EnsureInitialized(Thread* self, - Handle<mirror::Class> c, - bool can_init_fields, + bool EnsureInitialized(Thread* self, Handle<mirror::Class> c, bool can_init_fields, bool can_init_parents) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); // Initializes classes that have instances in the image but that have // <clinit> methods so they could not be initialized by the compiler. @@ -332,33 +289,26 @@ class ClassLinker { REQUIRES(!dex_lock_); void VisitClasses(ClassVisitor* visitor) - REQUIRES(!Locks::classlinker_classes_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); // Less efficient variant of VisitClasses that copies the class_table_ into secondary storage // so that it can visit individual classes without holding the doesn't hold the // Locks::classlinker_classes_lock_. As the Locks::classlinker_classes_lock_ isn't held this code // can race with insertion and deletion of classes while the visitor is being called. void VisitClassesWithoutClassesLock(ClassVisitor* visitor) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); void VisitClassRoots(RootVisitor* visitor, VisitRootFlags flags) - REQUIRES(!Locks::classlinker_classes_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!Locks::classlinker_classes_lock_) SHARED_REQUIRES(Locks::mutator_lock_); void VisitRoots(RootVisitor* visitor, VisitRootFlags flags) - REQUIRES(!dex_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!dex_lock_) SHARED_REQUIRES(Locks::mutator_lock_); mirror::DexCache* FindDexCache(const DexFile& dex_file) - REQUIRES(!dex_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!dex_lock_) SHARED_REQUIRES(Locks::mutator_lock_); bool IsDexFileRegistered(const DexFile& dex_file) - REQUIRES(!dex_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!dex_lock_) SHARED_REQUIRES(Locks::mutator_lock_); void FixupDexCaches(ArtMethod* resolution_method) - REQUIRES(!dex_lock_) - SHARED_REQUIRES(Locks::mutator_lock_); + REQUIRES(!dex_lock_) SHARED_REQUIRES(Locks::mutator_lock_); // Finds or creates the oat file holding dex_location. Then loads and returns // all corresponding dex files (there may be more than one dex file loaded @@ -374,75 +324,58 @@ class ClassLinker { // This method should not be called with the mutator_lock_ held, because it // could end up starving GC if we need to generate or relocate any oat // files. - std::vector<std::unique_ptr<const DexFile>> OpenDexFilesFromOat(const char* dex_location, - const char* oat_location, - out<std::vector<std::string>> - error_msgs) + std::vector<std::unique_ptr<const DexFile>> OpenDexFilesFromOat( + const char* dex_location, const char* oat_location, + std::vector<std::string>* error_msgs) REQUIRES(!dex_lock_, !Locks::mutator_lock_); // Allocate an instance of a java.lang.Object. - mirror::Object* AllocObject(Thread* self) - SHARED_REQUIRES(Locks::mutator_lock_) + mirror::Object* AllocObject(Thread* self) SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); // TODO: replace this with multiple methods that allocate the correct managed type. template <class T> mirror::ObjectArray<T>* AllocObjectArray(Thread* self, size_t length) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::ObjectArray<mirror::Class>* AllocClassArray(Thread* self, size_t length) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::ObjectArray<mirror::String>* AllocStringArray(Thread* self, size_t length) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); ArtField* AllocArtFieldArray(Thread* self, size_t length); ArtMethod* AllocArtMethodArray(Thread* self, size_t length); mirror::PointerArray* AllocPointerArray(Thread* self, size_t length) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::IfTable* AllocIfTable(Thread* self, size_t ifcount) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); - mirror::ObjectArray<mirror::StackTraceElement>* AllocStackTraceElementArray(Thread* self, - size_t length) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + mirror::ObjectArray<mirror::StackTraceElement>* AllocStackTraceElementArray( + Thread* self, size_t length) SHARED_REQUIRES(Locks::mutator_lock_) + REQUIRES(!Roles::uninterruptible_); void VerifyClass(Thread* self, Handle<mirror::Class> klass) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); - bool VerifyClassUsingOatFile(const DexFile& dex_file, - mirror::Class* klass, + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); + bool VerifyClassUsingOatFile(const DexFile& dex_file, mirror::Class* klass, mirror::Class::Status& oat_file_class_status) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); void ResolveClassExceptionHandlerTypes(const DexFile& dex_file, Handle<mirror::Class> klass) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); void ResolveMethodExceptionHandlerTypes(const DexFile& dex_file, ArtMethod* klass) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); - mirror::Class* CreateProxyClass(ScopedObjectAccessAlreadyRunnable& soa, - jstring name, - jobjectArray interfaces, - jobject loader, - jobjectArray methods, + mirror::Class* CreateProxyClass(ScopedObjectAccessAlreadyRunnable& soa, jstring name, + jobjectArray interfaces, jobject loader, jobjectArray methods, jobjectArray throws) SHARED_REQUIRES(Locks::mutator_lock_); std::string GetDescriptorForProxy(mirror::Class* proxy_class) SHARED_REQUIRES(Locks::mutator_lock_); - ArtMethod* FindMethodForProxy(mirror::Class* proxy_class, - ArtMethod* proxy_method) + ArtMethod* FindMethodForProxy(mirror::Class* proxy_class, ArtMethod* proxy_method) REQUIRES(!dex_lock_) SHARED_REQUIRES(Locks::mutator_lock_); @@ -451,8 +384,7 @@ class ClassLinker { SHARED_REQUIRES(Locks::mutator_lock_); // Get the oat code for a method from a method index. - const void* GetQuickOatCodeFor(const DexFile& dex_file, - uint16_t class_def_idx, + const void* GetQuickOatCodeFor(const DexFile& dex_file, uint16_t class_def_idx, uint32_t method_idx) SHARED_REQUIRES(Locks::mutator_lock_); @@ -462,7 +394,7 @@ class ClassLinker { const void* GetOatMethodQuickCodeFor(ArtMethod* method) SHARED_REQUIRES(Locks::mutator_lock_); - const OatFile::OatMethod FindOatMethodFor(ArtMethod* method, out<bool> found) + const OatFile::OatMethod FindOatMethodFor(ArtMethod* method, bool* found) SHARED_REQUIRES(Locks::mutator_lock_); pid_t GetClassesLockOwner(); // For SignalCatcher. @@ -519,14 +451,12 @@ class ClassLinker { // Returns true if the method can be called with its direct code pointer, false otherwise. bool MayBeCalledWithDirectCodePointer(ArtMethod* m) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Creates a GlobalRef PathClassLoader that can be used to load classes from the given dex files. // Note: the objects are not completely set up. Do not use this outside of tests and the compiler. - jobject CreatePathClassLoader(Thread* self, const std::vector<const DexFile*>& dex_files) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + jobject CreatePathClassLoader(Thread* self, std::vector<const DexFile*>& dex_files) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); size_t GetImagePointerSize() const { DCHECK(ValidPointerSize(image_pointer_size_)) << image_pointer_size_; @@ -573,39 +503,29 @@ class ClassLinker { // For early bootstrapping by Init mirror::Class* AllocClass(Thread* self, mirror::Class* java_lang_Class, uint32_t class_size) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); // Alloc* convenience functions to avoid needing to pass in mirror::Class* // values that are known to the ClassLinker such as // kObjectArrayClass and kJavaLangString etc. mirror::Class* AllocClass(Thread* self, uint32_t class_size) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::DexCache* AllocDexCache(Thread* self, const DexFile& dex_file) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::Class* CreatePrimitiveClass(Thread* self, Primitive::Type type) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); mirror::Class* InitializePrimitiveClass(mirror::Class* primitive_class, Primitive::Type type) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Roles::uninterruptible_); - mirror::Class* CreateArrayClass(Thread* self, - const char* descriptor, - size_t hash, + mirror::Class* CreateArrayClass(Thread* self, const char* descriptor, size_t hash, Handle<mirror::ClassLoader> class_loader) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_, !Roles::uninterruptible_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_, !Roles::uninterruptible_); void AppendToBootClassPath(Thread* self, const DexFile& dex_file) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); void AppendToBootClassPath(const DexFile& dex_file, Handle<mirror::DexCache> dex_cache) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); // Precomputes size needed for Class, in the case of a non-temporary class this size must be // sufficient to hold all static fields. @@ -614,41 +534,30 @@ class ClassLinker { // Setup the classloader, class def index, type idx so that we can insert this class in the class // table. - void SetupClass(const DexFile& dex_file, - const DexFile::ClassDef& dex_class_def, - Handle<mirror::Class> klass, - mirror::ClassLoader* class_loader) + void SetupClass(const DexFile& dex_file, const DexFile::ClassDef& dex_class_def, + Handle<mirror::Class> klass, mirror::ClassLoader* class_loader) SHARED_REQUIRES(Locks::mutator_lock_); - void LoadClass(Thread* self, - const DexFile& dex_file, - const DexFile::ClassDef& dex_class_def, + void LoadClass(Thread* self, const DexFile& dex_file, const DexFile::ClassDef& dex_class_def, Handle<mirror::Class> klass) SHARED_REQUIRES(Locks::mutator_lock_); - void LoadClassMembers(Thread* self, - const DexFile& dex_file, - const uint8_t* class_data, - Handle<mirror::Class> klass, - const OatFile::OatClass* oat_class) + void LoadClassMembers(Thread* self, const DexFile& dex_file, const uint8_t* class_data, + Handle<mirror::Class> klass, const OatFile::OatClass* oat_class) SHARED_REQUIRES(Locks::mutator_lock_); - void LoadField(const ClassDataItemIterator& it, - Handle<mirror::Class> klass, + void LoadField(const ClassDataItemIterator& it, Handle<mirror::Class> klass, ArtField* dst) SHARED_REQUIRES(Locks::mutator_lock_); - void LoadMethod(Thread* self, - const DexFile& dex_file, - const ClassDataItemIterator& it, - Handle<mirror::Class> klass, - ArtMethod* dst) + void LoadMethod(Thread* self, const DexFile& dex_file, const ClassDataItemIterator& it, + Handle<mirror::Class> klass, ArtMethod* dst) SHARED_REQUIRES(Locks::mutator_lock_); void FixupStaticTrampolines(mirror::Class* klass) SHARED_REQUIRES(Locks::mutator_lock_); // Finds the associated oat class for a dex_file and descriptor. Returns an invalid OatClass on // error and sets found to false. - OatFile::OatClass FindOatClass(const DexFile& dex_file, uint16_t class_def_idx, out<bool> found) + OatFile::OatClass FindOatClass(const DexFile& dex_file, uint16_t class_def_idx, bool* found) SHARED_REQUIRES(Locks::mutator_lock_); void RegisterDexFileLocked(const DexFile& dex_file, Handle<mirror::DexCache> dex_cache) @@ -656,70 +565,55 @@ class ClassLinker { bool IsDexFileRegisteredLocked(const DexFile& dex_file) SHARED_REQUIRES(dex_lock_, Locks::mutator_lock_); - bool InitializeClass(Thread* self, - Handle<mirror::Class> klass, - bool can_run_clinit, + bool InitializeClass(Thread* self, Handle<mirror::Class> klass, bool can_run_clinit, bool can_init_parents) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); - bool WaitForInitializeClass(Handle<mirror::Class> klass, - Thread* self, - ObjectLock<mirror::Class>* lock); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); + bool WaitForInitializeClass(Handle<mirror::Class> klass, Thread* self, + ObjectLock<mirror::Class>& lock); bool ValidateSuperClassDescriptors(Handle<mirror::Class> klass) SHARED_REQUIRES(Locks::mutator_lock_); - bool IsSameDescriptorInDifferentClassContexts(Thread* self, - const char* descriptor, + bool IsSameDescriptorInDifferentClassContexts(Thread* self, const char* descriptor, Handle<mirror::ClassLoader> class_loader1, Handle<mirror::ClassLoader> class_loader2) SHARED_REQUIRES(Locks::mutator_lock_); - bool IsSameMethodSignatureInDifferentClassContexts(Thread* self, - ArtMethod* method, - mirror::Class* klass1, - mirror::Class* klass2) + bool IsSameMethodSignatureInDifferentClassContexts(Thread* self, ArtMethod* method, + mirror::Class* klass1, mirror::Class* klass2) SHARED_REQUIRES(Locks::mutator_lock_); - bool LinkClass(Thread* self, - const char* descriptor, - Handle<mirror::Class> klass, + bool LinkClass(Thread* self, const char* descriptor, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<MutableHandle<mirror::Class>> h_new_class_out) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Locks::classlinker_classes_lock_); + MutableHandle<mirror::Class>* h_new_class_out) + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Locks::classlinker_classes_lock_); bool LinkSuperClass(Handle<mirror::Class> klass) SHARED_REQUIRES(Locks::mutator_lock_); bool LoadSuperAndInterfaces(Handle<mirror::Class> klass, const DexFile& dex_file) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!dex_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); bool LinkMethods(Thread* self, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<ArtMethod* [mirror::Class::kImtSize]> out_imt) + ArtMethod** out_imt) SHARED_REQUIRES(Locks::mutator_lock_); bool LinkVirtualMethods(Thread* self, Handle<mirror::Class> klass) SHARED_REQUIRES(Locks::mutator_lock_); - bool LinkInterfaceMethods(Thread* self, - Handle<mirror::Class> klass, + bool LinkInterfaceMethods(Thread* self, Handle<mirror::Class> klass, Handle<mirror::ObjectArray<mirror::Class>> interfaces, - out<ArtMethod* [mirror::Class::kImtSize]> out_imt) + ArtMethod** out_imt) SHARED_REQUIRES(Locks::mutator_lock_); - bool LinkStaticFields(Thread* self, - Handle<mirror::Class> klass, - out<size_t> class_size) + bool LinkStaticFields(Thread* self, Handle<mirror::Class> klass, size_t* class_size) SHARED_REQUIRES(Locks::mutator_lock_); bool LinkInstanceFields(Thread* self, Handle<mirror::Class> klass) SHARED_REQUIRES(Locks::mutator_lock_); - bool LinkFields(Thread* self, Handle<mirror::Class> klass, bool is_static, out<size_t> class_size) + bool LinkFields(Thread* self, Handle<mirror::Class> klass, bool is_static, size_t* class_size) SHARED_REQUIRES(Locks::mutator_lock_); - void LinkCode(ArtMethod* method, - const OatFile::OatClass* oat_class, + void LinkCode(ArtMethod* method, const OatFile::OatClass* oat_class, uint32_t class_def_method_index) SHARED_REQUIRES(Locks::mutator_lock_); void CreateReferenceInstanceOffsets(Handle<mirror::Class> klass) @@ -792,7 +686,7 @@ class ClassLinker { REQUIRES(!dex_lock_); // Check for duplicate class definitions of the given oat file against all open oat files. - bool HasCollisions(const OatFile* oat_file, out<std::string> error_msg) REQUIRES(!dex_lock_); + bool HasCollisions(const OatFile* oat_file, std::string* error_msg) REQUIRES(!dex_lock_); bool HasInitWithString(Thread* self, const char* descriptor) SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!dex_lock_); @@ -800,11 +694,9 @@ class ClassLinker { bool CanWeInitializeClass(mirror::Class* klass, bool can_init_statics, bool can_init_parents) SHARED_REQUIRES(Locks::mutator_lock_); - void UpdateClassVirtualMethods(mirror::Class* klass, - ArtMethod* new_methods, + void UpdateClassVirtualMethods(mirror::Class* klass, ArtMethod* new_methods, size_t new_num_methods) - SHARED_REQUIRES(Locks::mutator_lock_) - REQUIRES(!Locks::classlinker_classes_lock_); + SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Locks::classlinker_classes_lock_); std::vector<const DexFile*> boot_class_path_; std::vector<std::unique_ptr<const DexFile>> opened_dex_files_; diff --git a/runtime/debugger.cc b/runtime/debugger.cc index 1865516939..c9ae9b8b6e 100644 --- a/runtime/debugger.cc +++ b/runtime/debugger.cc @@ -24,7 +24,6 @@ #include "art_field-inl.h" #include "art_method-inl.h" #include "base/time_utils.h" -#include "base/out.h" #include "class_linker.h" #include "class_linker-inl.h" #include "dex_file-inl.h" @@ -1001,7 +1000,7 @@ JDWP::JdwpError Dbg::GetClassInfo(JDWP::RefTypeId class_id, JDWP::JdwpTypeTag* p void Dbg::FindLoadedClassBySignature(const char* descriptor, std::vector<JDWP::RefTypeId>* ids) { std::vector<mirror::Class*> classes; - Runtime::Current()->GetClassLinker()->LookupClasses(descriptor, outof(classes)); + Runtime::Current()->GetClassLinker()->LookupClasses(descriptor, classes); ids->clear(); for (size_t i = 0; i < classes.size(); ++i) { ids->push_back(gRegistry->Add(classes[i])); diff --git a/runtime/gc/space/image_space.cc b/runtime/gc/space/image_space.cc index aba32a003f..1923d24805 100644 --- a/runtime/gc/space/image_space.cc +++ b/runtime/gc/space/image_space.cc @@ -25,7 +25,6 @@ #include "art_method.h" #include "base/macros.h" -#include "base/out.h" #include "base/stl_util.h" #include "base/scoped_flock.h" #include "base/time_utils.h" @@ -208,7 +207,7 @@ static bool GenerateImage(const std::string& image_filename, InstructionSet imag // Note: we do not generate a fully debuggable boot image so we do not pass the // compiler flag --debuggable here. - Runtime::Current()->AddCurrentRuntimeFeaturesAsDex2OatArguments(outof(arg_vector)); + Runtime::Current()->AddCurrentRuntimeFeaturesAsDex2OatArguments(&arg_vector); CHECK_EQ(image_isa, kRuntimeISA) << "We should always be generating an image for the current isa."; @@ -790,13 +789,10 @@ OatFile* ImageSpace::OpenOatFile(const char* image_path, std::string* error_msg) CHECK(image_header.GetOatDataBegin() != nullptr); - OatFile* oat_file = OatFile::Open(oat_filename, - oat_filename, - image_header.GetOatDataBegin(), + OatFile* oat_file = OatFile::Open(oat_filename, oat_filename, image_header.GetOatDataBegin(), image_header.GetOatFileBegin(), !Runtime::Current()->IsAotCompiler(), - nullptr /* no abs dex location */, - outof_ptr(error_msg)); + nullptr, error_msg); if (oat_file == nullptr) { *error_msg = StringPrintf("Failed to open oat file '%s' referenced from image %s: %s", oat_filename.c_str(), GetName(), error_msg->c_str()); diff --git a/runtime/interpreter/interpreter_common.h b/runtime/interpreter/interpreter_common.h index a6cccef617..2486a983fd 100644 --- a/runtime/interpreter/interpreter_common.h +++ b/runtime/interpreter/interpreter_common.h @@ -553,7 +553,7 @@ static inline bool DoUnboxLambda(Thread* self, ArtMethod* unboxed_closure = nullptr; // Raise an exception if unboxing fails. if (!Runtime::Current()->GetLambdaBoxTable()->UnboxLambda(boxed_closure_object, - outof(unboxed_closure))) { + &unboxed_closure)) { CHECK(self->IsExceptionPending()); return false; } diff --git a/runtime/lambda/box_table.cc b/runtime/lambda/box_table.cc index 22cc820b73..64a6076aea 100644 --- a/runtime/lambda/box_table.cc +++ b/runtime/lambda/box_table.cc @@ -94,7 +94,8 @@ mirror::Object* BoxTable::BoxLambda(const ClosureType& closure) { return method_as_object; } -bool BoxTable::UnboxLambda(mirror::Object* object, out<ClosureType> out_closure) { +bool BoxTable::UnboxLambda(mirror::Object* object, ClosureType* out_closure) { + DCHECK(object != nullptr); *out_closure = nullptr; // Note that we do not need to access lambda_table_lock_ here diff --git a/runtime/lambda/box_table.h b/runtime/lambda/box_table.h index c6d3d0c0fb..312d811b9b 100644 --- a/runtime/lambda/box_table.h +++ b/runtime/lambda/box_table.h @@ -18,7 +18,6 @@ #include "base/allocator.h" #include "base/hash_map.h" -#include "base/out.h" #include "gc_root.h" #include "base/macros.h" #include "base/mutex.h" @@ -52,7 +51,7 @@ class BoxTable FINAL { SHARED_REQUIRES(Locks::mutator_lock_) REQUIRES(!Locks::lambda_table_lock_); // Unboxes an object back into the lambda. Returns false and throws an exception on failure. - bool UnboxLambda(mirror::Object* object, out<ClosureType> out_closure) + bool UnboxLambda(mirror::Object* object, ClosureType* out_closure) SHARED_REQUIRES(Locks::mutator_lock_); // Sweep weak references to lambda boxes. Update the addresses if the objects have been diff --git a/runtime/native/dalvik_system_DexFile.cc b/runtime/native/dalvik_system_DexFile.cc index 1b210bb4c3..4f97d20d6c 100644 --- a/runtime/native/dalvik_system_DexFile.cc +++ b/runtime/native/dalvik_system_DexFile.cc @@ -17,7 +17,6 @@ #include "dalvik_system_DexFile.h" #include "base/logging.h" -#include "base/out.h" #include "base/stl_util.h" #include "base/stringprintf.h" #include "class_linker.h" @@ -165,8 +164,7 @@ static jobject DexFile_openDexFileNative( std::vector<std::unique_ptr<const DexFile>> dex_files; std::vector<std::string> error_msgs; - dex_files = - linker->OpenDexFilesFromOat(sourceName.c_str(), outputName.c_str(), outof(error_msgs)); + dex_files = linker->OpenDexFilesFromOat(sourceName.c_str(), outputName.c_str(), &error_msgs); if (!dex_files.empty()) { jlongArray array = ConvertNativeToJavaArray(env, dex_files); diff --git a/runtime/native/java_lang_VMClassLoader.cc b/runtime/native/java_lang_VMClassLoader.cc index 62a0b7653d..15156301c8 100644 --- a/runtime/native/java_lang_VMClassLoader.cc +++ b/runtime/native/java_lang_VMClassLoader.cc @@ -16,7 +16,6 @@ #include "java_lang_VMClassLoader.h" -#include "base/out.h" #include "class_linker.h" #include "jni_internal.h" #include "mirror/class_loader.h" @@ -46,7 +45,7 @@ static jclass VMClassLoader_findLoadedClass(JNIEnv* env, jclass, jobject javaLoa // Try the common case. StackHandleScope<1> hs(soa.Self()); cl->FindClassInPathClassLoader(soa, soa.Self(), descriptor.c_str(), descriptor_hash, - hs.NewHandle(loader), outof(c)); + hs.NewHandle(loader), &c); if (c != nullptr) { return soa.AddLocalReference<jclass>(c); } diff --git a/runtime/oat_file.cc b/runtime/oat_file.cc index 80fc7fa836..a23d94d845 100644 --- a/runtime/oat_file.cc +++ b/runtime/oat_file.cc @@ -32,7 +32,6 @@ #endif #include "art_method-inl.h" -#include "base/out.h" #include "base/bit_vector.h" #include "base/stl_util.h" #include "base/unix_file/fd_file.h" @@ -89,16 +88,16 @@ void OatFile::CheckLocation(const std::string& location) { OatFile* OatFile::OpenWithElfFile(ElfFile* elf_file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { std::unique_ptr<OatFile> oat_file(new OatFile(location, false)); oat_file->elf_file_.reset(elf_file); uint64_t offset, size; - bool has_section = elf_file->GetSectionOffsetAndSize(".rodata", outof(offset), outof(size)); + bool has_section = elf_file->GetSectionOffsetAndSize(".rodata", &offset, &size); CHECK(has_section); oat_file->begin_ = elf_file->Begin() + offset; oat_file->end_ = elf_file->Begin() + size + offset; // Ignore the optional .bss section when opening non-executable. - return oat_file->Setup(abs_dex_location, outof_forward(error_msg)) ? oat_file.release() : nullptr; + return oat_file->Setup(abs_dex_location, error_msg) ? oat_file.release() : nullptr; } OatFile* OatFile::Open(const std::string& filename, @@ -107,7 +106,7 @@ OatFile* OatFile::Open(const std::string& filename, uint8_t* oat_file_begin, bool executable, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { CHECK(!filename.empty()) << location; CheckLocation(location); std::unique_ptr<OatFile> ret; @@ -155,34 +154,27 @@ OatFile* OatFile::Open(const std::string& filename, return ret.release(); } -OatFile* OatFile::OpenWritable(File* file, - const std::string& location, +OatFile* OatFile::OpenWritable(File* file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { CheckLocation(location); - return OpenElfFile(file, location, nullptr, nullptr, true, false, abs_dex_location, - outof_forward(error_msg)); + return OpenElfFile(file, location, nullptr, nullptr, true, false, abs_dex_location, error_msg); } -OatFile* OatFile::OpenReadable(File* file, - const std::string& location, +OatFile* OatFile::OpenReadable(File* file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { CheckLocation(location); - return OpenElfFile(file, location, nullptr, nullptr, false, false, abs_dex_location, - outof_forward(error_msg)); + return OpenElfFile(file, location, nullptr, nullptr, false, false, abs_dex_location, error_msg); } OatFile* OatFile::OpenDlopen(const std::string& elf_filename, const std::string& location, uint8_t* requested_base, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { std::unique_ptr<OatFile> oat_file(new OatFile(location, true)); - bool success = oat_file->Dlopen(elf_filename, - requested_base, - abs_dex_location, - outof_forward(error_msg)); + bool success = oat_file->Dlopen(elf_filename, requested_base, abs_dex_location, error_msg); if (!success) { return nullptr; } @@ -196,10 +188,10 @@ OatFile* OatFile::OpenElfFile(File* file, bool writable, bool executable, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { std::unique_ptr<OatFile> oat_file(new OatFile(location, executable)); bool success = oat_file->ElfFileOpen(file, requested_base, oat_file_begin, writable, executable, - abs_dex_location, outof_forward(error_msg)); + abs_dex_location, error_msg); if (!success) { CHECK(!error_msg->empty()); return nullptr; @@ -208,13 +200,8 @@ OatFile* OatFile::OpenElfFile(File* file, } OatFile::OatFile(const std::string& location, bool is_executable) - : location_(location), - begin_(nullptr), - end_(nullptr), - bss_begin_(nullptr), - bss_end_(nullptr), - is_executable_(is_executable), - dlopen_handle_(nullptr), + : location_(location), begin_(nullptr), end_(nullptr), bss_begin_(nullptr), bss_end_(nullptr), + is_executable_(is_executable), dlopen_handle_(nullptr), secondary_lookup_lock_("OatFile secondary lookup lock", kOatFileSecondaryLookupLock) { CHECK(!location_.empty()); } @@ -226,10 +213,8 @@ OatFile::~OatFile() { } } -bool OatFile::Dlopen(const std::string& elf_filename, - uint8_t* requested_base, - const char* abs_dex_location, - out<std::string> error_msg) { +bool OatFile::Dlopen(const std::string& elf_filename, uint8_t* requested_base, + const char* abs_dex_location, std::string* error_msg) { #ifdef __APPLE__ // The dl_iterate_phdr syscall is missing. There is similar API on OSX, // but let's fallback to the custom loading code for the time being. @@ -334,28 +319,22 @@ bool OatFile::Dlopen(const std::string& elf_filename, LOG(ERROR) << "File " << elf_filename << " loaded with dlopen but can not find its mmaps."; } - return Setup(abs_dex_location, outof_forward(error_msg)); + return Setup(abs_dex_location, error_msg); #endif // __APPLE__ } -bool OatFile::ElfFileOpen(File* file, - uint8_t* requested_base, - uint8_t* oat_file_begin, - bool writable, - bool executable, +bool OatFile::ElfFileOpen(File* file, uint8_t* requested_base, uint8_t* oat_file_begin, + bool writable, bool executable, const char* abs_dex_location, - out<std::string> error_msg) { + std::string* error_msg) { // TODO: rename requested_base to oat_data_begin - elf_file_.reset(ElfFile::Open(file, - writable, - /*program_header_only*/true, - outof_forward(error_msg), + elf_file_.reset(ElfFile::Open(file, writable, /*program_header_only*/true, error_msg, oat_file_begin)); if (elf_file_ == nullptr) { DCHECK(!error_msg->empty()); return false; } - bool loaded = elf_file_->Load(executable, outof_forward(error_msg)); + bool loaded = elf_file_->Load(executable, error_msg); if (!loaded) { DCHECK(!error_msg->empty()); return false; @@ -396,10 +375,10 @@ bool OatFile::ElfFileOpen(File* file, bss_end_ += sizeof(uint32_t); } - return Setup(abs_dex_location, outof_forward(error_msg)); + return Setup(abs_dex_location, error_msg); } -bool OatFile::Setup(const char* abs_dex_location, out<std::string> error_msg) { +bool OatFile::Setup(const char* abs_dex_location, std::string* error_msg) { if (!GetOatHeader().IsValid()) { std::string cause = GetOatHeader().GetValidationErrorMessage(); *error_msg = StringPrintf("Invalid oat header for '%s': %s", GetLocation().c_str(), @@ -638,9 +617,9 @@ size_t OatFile::OatDexFile::FileSize() const { return reinterpret_cast<const DexFile::Header*>(dex_file_pointer_)->file_size_; } -std::unique_ptr<const DexFile> OatFile::OatDexFile::OpenDexFile(out<std::string> error_msg) const { +std::unique_ptr<const DexFile> OatFile::OatDexFile::OpenDexFile(std::string* error_msg) const { return DexFile::Open(dex_file_pointer_, FileSize(), dex_file_location_, - dex_file_location_checksum_, this, outof_forward(error_msg)); + dex_file_location_checksum_, this, error_msg); } uint32_t OatFile::OatDexFile::GetOatClassOffset(uint16_t class_def_index) const { @@ -798,7 +777,7 @@ std::string OatFile::EncodeDexFileDependencies(const std::vector<const DexFile*> return out.str(); } -bool OatFile::CheckStaticDexFileDependencies(const char* dex_dependencies, out<std::string> msg) { +bool OatFile::CheckStaticDexFileDependencies(const char* dex_dependencies, std::string* msg) { if (dex_dependencies == nullptr || dex_dependencies[0] == 0) { // No dependencies. return true; @@ -807,7 +786,7 @@ bool OatFile::CheckStaticDexFileDependencies(const char* dex_dependencies, out<s // Assumption: this is not performance-critical. So it's OK to do this with a std::string and // Split() instead of manual parsing of the combined char*. std::vector<std::string> split; - Split(dex_dependencies, kDexClassPathEncodingSeparator, outof(split)); + Split(dex_dependencies, kDexClassPathEncodingSeparator, &split); if (split.size() % 2 != 0) { // Expected pairs of location and checksum. *msg = StringPrintf("Odd number of elements in dependency list %s", dex_dependencies); @@ -827,8 +806,8 @@ bool OatFile::CheckStaticDexFileDependencies(const char* dex_dependencies, out<s uint32_t dex_checksum; std::string error_msg; if (DexFile::GetChecksum(DexFile::GetDexCanonicalLocation(location.c_str()).c_str(), - outof(dex_checksum), - outof(error_msg))) { + &dex_checksum, + &error_msg)) { if (converted != dex_checksum) { *msg = StringPrintf("Checksums don't match for %s: %" PRId64 " vs %u", location.c_str(), converted, dex_checksum); @@ -847,7 +826,8 @@ bool OatFile::CheckStaticDexFileDependencies(const char* dex_dependencies, out<s } bool OatFile::GetDexLocationsFromDependencies(const char* dex_dependencies, - out<std::vector<std::string>> locations) { + std::vector<std::string>* locations) { + DCHECK(locations != nullptr); if (dex_dependencies == nullptr || dex_dependencies[0] == 0) { return true; } @@ -855,7 +835,7 @@ bool OatFile::GetDexLocationsFromDependencies(const char* dex_dependencies, // Assumption: this is not performance-critical. So it's OK to do this with a std::string and // Split() instead of manual parsing of the combined char*. std::vector<std::string> split; - Split(dex_dependencies, kDexClassPathEncodingSeparator, outof(split)); + Split(dex_dependencies, kDexClassPathEncodingSeparator, &split); if (split.size() % 2 != 0) { // Expected pairs of location and checksum. return false; diff --git a/runtime/oat_file.h b/runtime/oat_file.h index 6c40c68902..27f8677f03 100644 --- a/runtime/oat_file.h +++ b/runtime/oat_file.h @@ -22,7 +22,6 @@ #include <vector> #include "base/mutex.h" -#include "base/out_fwd.h" #include "base/stringpiece.h" #include "dex_file.h" #include "invoke_type.h" @@ -46,10 +45,9 @@ class OatFile FINAL { // Opens an oat file contained within the given elf file. This is always opened as // non-executable at the moment. - static OatFile* OpenWithElfFile(ElfFile* elf_file, - const std::string& location, + static OatFile* OpenWithElfFile(ElfFile* elf_file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); // Open an oat file. Returns null on failure. Requested base can // optionally be used to request where the file should be loaded. // See the ResolveRelativeEncodedDexLocation for a description of how the @@ -60,22 +58,20 @@ class OatFile FINAL { uint8_t* oat_file_begin, bool executable, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); // Open an oat file from an already opened File. // Does not use dlopen underneath so cannot be used for runtime use // where relocations may be required. Currently used from // ImageWriter which wants to open a writable version from an existing // file descriptor for patching. - static OatFile* OpenWritable(File* file, - const std::string& location, + static OatFile* OpenWritable(File* file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); // Opens an oat file from an already opened File. Maps it PROT_READ, MAP_PRIVATE. - static OatFile* OpenReadable(File* file, - const std::string& location, + static OatFile* OpenReadable(File* file, const std::string& location, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); ~OatFile(); @@ -256,13 +252,12 @@ class OatFile FINAL { // Check the given dependency list against their dex files - thus the name "Static," this does // not check the class-loader environment, only whether there have been file updates. - static bool CheckStaticDexFileDependencies(const char* dex_dependencies, - out<std::string> error_msg); + static bool CheckStaticDexFileDependencies(const char* dex_dependencies, std::string* msg); // Get the dex locations of a dependency list. Note: this is *not* cleaned for synthetic // locations of multidex files. static bool GetDexLocationsFromDependencies(const char* dex_dependencies, - out<std::vector<std::string>> locations); + std::vector<std::string>* locations); private: static void CheckLocation(const std::string& location); @@ -271,7 +266,7 @@ class OatFile FINAL { const std::string& location, uint8_t* requested_base, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); static OatFile* OpenElfFile(File* file, const std::string& location, @@ -280,22 +275,18 @@ class OatFile FINAL { bool writable, bool executable, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); explicit OatFile(const std::string& filename, bool executable); - bool Dlopen(const std::string& elf_filename, - uint8_t* requested_base, - const char* abs_dex_location, - out<std::string> error_msg); - bool ElfFileOpen(File* file, - uint8_t* requested_base, + bool Dlopen(const std::string& elf_filename, uint8_t* requested_base, + const char* abs_dex_location, std::string* error_msg); + bool ElfFileOpen(File* file, uint8_t* requested_base, uint8_t* oat_file_begin, // Override where the file is loaded to if not null - bool writable, - bool executable, + bool writable, bool executable, const char* abs_dex_location, - out<std::string> error_msg); + std::string* error_msg); - bool Setup(const char* abs_dex_location, out<std::string> error_msg); + bool Setup(const char* abs_dex_location, std::string* error_msg); // The oat file name. // @@ -374,7 +365,7 @@ class OatFile FINAL { class OatDexFile FINAL { public: // Opens the DexFile referred to by this OatDexFile from within the containing OatFile. - std::unique_ptr<const DexFile> OpenDexFile(out<std::string> error_msg) const; + std::unique_ptr<const DexFile> OpenDexFile(std::string* error_msg) const; const OatFile* GetOatFile() const { return oat_file_; diff --git a/runtime/oat_file_assistant.cc b/runtime/oat_file_assistant.cc index e919b36b99..29b879ee80 100644 --- a/runtime/oat_file_assistant.cc +++ b/runtime/oat_file_assistant.cc @@ -29,7 +29,6 @@ #include <set> #include "base/logging.h" -#include "base/out.h" #include "base/stringprintf.h" #include "class_linker.h" #include "gc/heap.h" @@ -231,7 +230,7 @@ std::vector<std::unique_ptr<const DexFile>> OatFileAssistant::LoadDexFiles( return std::vector<std::unique_ptr<const DexFile>>(); } - std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(outof(error_msg)); + std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg); if (dex_file.get() == nullptr) { LOG(WARNING) << "Failed to open dex file from oat dex file: " << error_msg; return std::vector<std::unique_ptr<const DexFile>>(); @@ -247,7 +246,7 @@ std::vector<std::unique_ptr<const DexFile>> OatFileAssistant::LoadDexFiles( break; } - dex_file = oat_dex_file->OpenDexFile(outof(error_msg)); + dex_file = oat_dex_file->OpenDexFile(&error_msg); if (dex_file.get() == nullptr) { LOG(WARNING) << "Failed to open dex file from oat dex file: " << error_msg; return std::vector<std::unique_ptr<const DexFile>>(); @@ -272,7 +271,7 @@ const std::string* OatFileAssistant::OdexFileName() { std::string error_msg; cached_odex_file_name_found_ = DexFilenameToOdexFilename( - dex_location_, isa_, &cached_odex_file_name_, outof(error_msg)); + dex_location_, isa_, &cached_odex_file_name_, &error_msg); if (!cached_odex_file_name_found_) { // If we can't figure out the odex file, we treat it as if the odex // file was inaccessible. @@ -340,7 +339,7 @@ const std::string* OatFileAssistant::OatFileName() { DalvikCacheDirectory().c_str(), GetInstructionSetString(isa_)); std::string error_msg; cached_oat_file_name_found_ = GetDalvikCacheFilename(dex_location_, - cache_dir.c_str(), &cached_oat_file_name_, outof(error_msg)); + cache_dir.c_str(), &cached_oat_file_name_, &error_msg); if (!cached_oat_file_name_found_) { // If we can't determine the oat file name, we treat the oat file as // inaccessible. @@ -433,7 +432,7 @@ bool OatFileAssistant::GivenOatFileIsOutOfDate(const OatFile& file) { std::string error_msg; uint32_t expected_secondary_checksum = 0; if (DexFile::GetChecksum(secondary_dex_location.c_str(), - &expected_secondary_checksum, outof(error_msg))) { + &expected_secondary_checksum, &error_msg)) { uint32_t actual_secondary_checksum = secondary_oat_dex_file->GetDexFileLocationChecksum(); if (expected_secondary_checksum != actual_secondary_checksum) { @@ -723,7 +722,7 @@ bool OatFileAssistant::Dex2Oat(const std::vector<std::string>& args, if (runtime->IsDebuggable()) { argv.push_back("--debuggable"); } - runtime->AddCurrentRuntimeFeaturesAsDex2OatArguments(outof(argv)); + runtime->AddCurrentRuntimeFeaturesAsDex2OatArguments(&argv); if (!runtime->IsVerificationEnabled()) { argv.push_back("--compiler-filter=verify-none"); @@ -874,7 +873,7 @@ const OatFile* OatFileAssistant::GetOdexFile() { std::string error_msg; cached_odex_file_.reset(OatFile::Open(odex_file_name.c_str(), odex_file_name.c_str(), nullptr, nullptr, load_executable_, - dex_location_, outof(error_msg))); + dex_location_, &error_msg)); if (cached_odex_file_.get() == nullptr) { VLOG(oat) << "OatFileAssistant test for existing pre-compiled oat file " << odex_file_name << ": " << error_msg; @@ -905,7 +904,7 @@ const OatFile* OatFileAssistant::GetOatFile() { std::string error_msg; cached_oat_file_.reset(OatFile::Open(oat_file_name.c_str(), oat_file_name.c_str(), nullptr, nullptr, load_executable_, - dex_location_, outof(error_msg))); + dex_location_, &error_msg)); if (cached_oat_file_.get() == nullptr) { VLOG(oat) << "OatFileAssistant test for existing oat file " << oat_file_name << ": " << error_msg; diff --git a/runtime/oat_file_assistant_test.cc b/runtime/oat_file_assistant_test.cc index 4a0de59a20..03ad2d5ac8 100644 --- a/runtime/oat_file_assistant_test.cc +++ b/runtime/oat_file_assistant_test.cc @@ -26,7 +26,6 @@ #include <gtest/gtest.h> #include "art_field-inl.h" -#include "base/out.h" #include "class_linker-inl.h" #include "common_runtime_test.h" #include "compiler_callbacks.h" @@ -88,7 +87,7 @@ class OatFileAssistantTest : public CommonRuntimeTest { << "Expected dex file to be at: " << GetDexSrc1(); ASSERT_TRUE(OS::FileExists(GetStrippedDexSrc1().c_str())) << "Expected stripped dex file to be at: " << GetStrippedDexSrc1(); - ASSERT_FALSE(DexFile::GetChecksum(GetStrippedDexSrc1().c_str(), &checksum, outof(error_msg))) + ASSERT_FALSE(DexFile::GetChecksum(GetStrippedDexSrc1().c_str(), &checksum, &error_msg)) << "Expected stripped dex file to be stripped: " << GetStrippedDexSrc1(); ASSERT_TRUE(OS::FileExists(GetDexSrc2().c_str())) << "Expected dex file to be at: " << GetDexSrc2(); @@ -97,12 +96,12 @@ class OatFileAssistantTest : public CommonRuntimeTest { // GetMultiDexSrc1, but a different secondary dex checksum. std::vector<std::unique_ptr<const DexFile>> multi1; ASSERT_TRUE(DexFile::Open(GetMultiDexSrc1().c_str(), - GetMultiDexSrc1().c_str(), outof(error_msg), &multi1)) << error_msg; + GetMultiDexSrc1().c_str(), &error_msg, &multi1)) << error_msg; ASSERT_GT(multi1.size(), 1u); std::vector<std::unique_ptr<const DexFile>> multi2; ASSERT_TRUE(DexFile::Open(GetMultiDexSrc2().c_str(), - GetMultiDexSrc2().c_str(), outof(error_msg), &multi2)) << error_msg; + GetMultiDexSrc2().c_str(), &error_msg, &multi2)) << error_msg; ASSERT_GT(multi2.size(), 1u); ASSERT_EQ(multi1[0]->GetLocationChecksum(), multi2[0]->GetLocationChecksum()); @@ -232,13 +231,13 @@ class OatFileAssistantTest : public CommonRuntimeTest { args.push_back("--runtime-arg"); args.push_back("-Xnorelocate"); std::string error_msg; - ASSERT_TRUE(OatFileAssistant::Dex2Oat(args, outof(error_msg))) << error_msg; + ASSERT_TRUE(OatFileAssistant::Dex2Oat(args, &error_msg)) << error_msg; setenv("ANDROID_DATA", android_data_.c_str(), 1); // Verify the odex file was generated as expected. std::unique_ptr<OatFile> odex_file(OatFile::Open( odex_location.c_str(), odex_location.c_str(), nullptr, nullptr, - false, dex_location.c_str(), outof(error_msg))); + false, dex_location.c_str(), &error_msg)); ASSERT_TRUE(odex_file.get() != nullptr) << error_msg; if (!pic) { @@ -284,7 +283,7 @@ class OatFileAssistantTest : public CommonRuntimeTest { image_reservation_.push_back(std::unique_ptr<MemMap>( MemMap::MapAnonymous("image reservation", reinterpret_cast<uint8_t*>(start), end - start, - PROT_NONE, false, false, outof(error_msg)))); + PROT_NONE, false, false, &error_msg))); ASSERT_TRUE(image_reservation_.back().get() != nullptr) << error_msg; LOG(INFO) << "Reserved space for image " << reinterpret_cast<void*>(image_reservation_.back()->Begin()) << "-" << @@ -319,7 +318,7 @@ static void GenerateOatForTest(const char* dex_location) { OatFileAssistant oat_file_assistant(dex_location, kRuntimeISA, false); std::string error_msg; - ASSERT_TRUE(oat_file_assistant.GenerateOatFile(outof(error_msg))) << error_msg; + ASSERT_TRUE(oat_file_assistant.GenerateOatFile(&error_msg)) << error_msg; } // Case: We have a DEX file, but no OAT file for it. @@ -358,7 +357,7 @@ TEST_F(OatFileAssistantTest, NoDexNoOat) { // Trying to make the oat file up to date should not fail or crash. std::string error_msg; - EXPECT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))); + EXPECT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)); // Trying to get the best oat file should fail, but not crash. std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile(); @@ -442,7 +441,7 @@ TEST_F(OatFileAssistantTest, RelativeEncodedDexLocation) { args.push_back("--oat-file=" + oat_location); std::string error_msg; - ASSERT_TRUE(OatFileAssistant::Dex2Oat(args, outof(error_msg))) << error_msg; + ASSERT_TRUE(OatFileAssistant::Dex2Oat(args, &error_msg)) << error_msg; // Verify we can load both dex files. OatFileAssistant oat_file_assistant(dex_location.c_str(), @@ -541,7 +540,7 @@ TEST_F(OatFileAssistantTest, StrippedDexOdexNoOat) { // Make the oat file up to date. std::string error_msg; - ASSERT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))) << error_msg; + ASSERT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)) << error_msg; EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded, oat_file_assistant.GetDexOptNeeded()); @@ -597,7 +596,7 @@ TEST_F(OatFileAssistantTest, StrippedDexOdexOat) { // Make the oat file up to date. std::string error_msg; - ASSERT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))) << error_msg; + ASSERT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)) << error_msg; EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded, oat_file_assistant.GetDexOptNeeded()); @@ -645,7 +644,7 @@ TEST_F(OatFileAssistantTest, ResourceOnlyDex) { // Make the oat file up to date. This should have no effect. std::string error_msg; - EXPECT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))) << error_msg; + EXPECT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)) << error_msg; EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded, oat_file_assistant.GetDexOptNeeded()); @@ -689,7 +688,7 @@ TEST_F(OatFileAssistantTest, SelfRelocation) { // Make the oat file up to date. std::string error_msg; - ASSERT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))) << error_msg; + ASSERT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)) << error_msg; EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded, oat_file_assistant.GetDexOptNeeded()); @@ -830,7 +829,7 @@ TEST_F(OatFileAssistantTest, LoadDexNoAlternateOat) { OatFileAssistant oat_file_assistant( dex_location.c_str(), oat_location.c_str(), kRuntimeISA, true); std::string error_msg; - ASSERT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))) << error_msg; + ASSERT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)) << error_msg; std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile(); ASSERT_TRUE(oat_file.get() != nullptr); @@ -920,7 +919,7 @@ TEST_F(OatFileAssistantTest, ShortDexLocation) { // Trying to make it up to date should have no effect. std::string error_msg; - EXPECT_TRUE(oat_file_assistant.MakeUpToDate(outof(error_msg))); + EXPECT_TRUE(oat_file_assistant.MakeUpToDate(&error_msg)); EXPECT_TRUE(error_msg.empty()); } @@ -959,9 +958,7 @@ class RaceGenerateTask : public Task { ClassLinker* linker = Runtime::Current()->GetClassLinker(); std::vector<std::unique_ptr<const DexFile>> dex_files; std::vector<std::string> error_msgs; - dex_files = linker->OpenDexFilesFromOat(dex_location_.c_str(), - oat_location_.c_str(), - outof(error_msgs)); + dex_files = linker->OpenDexFilesFromOat(dex_location_.c_str(), oat_location_.c_str(), &error_msgs); CHECK(!dex_files.empty()) << Join(error_msgs, '\n'); CHECK(dex_files[0]->GetOatDexFile() != nullptr) << dex_files[0]->GetLocation(); loaded_oat_file_ = dex_files[0]->GetOatDexFile()->GetOatFile(); @@ -1058,17 +1055,17 @@ TEST(OatFileAssistantUtilsTest, DexFilenameToOdexFilename) { std::string odex_file; EXPECT_TRUE(OatFileAssistant::DexFilenameToOdexFilename( - "/foo/bar/baz.jar", kArm, &odex_file, outof(error_msg))) << error_msg; + "/foo/bar/baz.jar", kArm, &odex_file, &error_msg)) << error_msg; EXPECT_EQ("/foo/bar/oat/arm/baz.odex", odex_file); EXPECT_TRUE(OatFileAssistant::DexFilenameToOdexFilename( - "/foo/bar/baz.funnyext", kArm, &odex_file, outof(error_msg))) << error_msg; + "/foo/bar/baz.funnyext", kArm, &odex_file, &error_msg)) << error_msg; EXPECT_EQ("/foo/bar/oat/arm/baz.odex", odex_file); EXPECT_FALSE(OatFileAssistant::DexFilenameToOdexFilename( - "nopath.jar", kArm, &odex_file, outof(error_msg))); + "nopath.jar", kArm, &odex_file, &error_msg)); EXPECT_FALSE(OatFileAssistant::DexFilenameToOdexFilename( - "/foo/bar/baz_noext", kArm, &odex_file, outof(error_msg))); + "/foo/bar/baz_noext", kArm, &odex_file, &error_msg)); } // Verify the dexopt status values from dalvik.system.DexFile diff --git a/runtime/oat_file_test.cc b/runtime/oat_file_test.cc index 3bd6df2ef5..a88553ca7b 100644 --- a/runtime/oat_file_test.cc +++ b/runtime/oat_file_test.cc @@ -20,7 +20,6 @@ #include <gtest/gtest.h> -#include "base/out.h" #include "common_runtime_test.h" #include "scoped_thread_state_change.h" @@ -76,16 +75,16 @@ TEST_F(OatFileTest, DexFileDependencies) { std::string error_msg; // No dependencies. - EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(nullptr, outof(error_msg))) << error_msg; - EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies("", outof(error_msg))) << error_msg; + EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(nullptr, &error_msg)) << error_msg; + EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies("", &error_msg)) << error_msg; // Ill-formed dependencies. - EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc", outof(error_msg))); - EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*123*def", outof(error_msg))); - EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*def*", outof(error_msg))); + EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc", &error_msg)); + EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*123*def", &error_msg)); + EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*def*", &error_msg)); // Unsatisfiable dependency. - EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*123*", outof(error_msg))); + EXPECT_FALSE(OatFile::CheckStaticDexFileDependencies("abc*123*", &error_msg)); // Load some dex files to be able to do a real test. ScopedObjectAccess soa(Thread::Current()); @@ -93,10 +92,10 @@ TEST_F(OatFileTest, DexFileDependencies) { std::vector<std::unique_ptr<const DexFile>> dex_files1 = OpenTestDexFiles("Main"); std::vector<const DexFile*> dex_files_const1 = ToConstDexFiles(dex_files1); std::string encoding1 = OatFile::EncodeDexFileDependencies(dex_files_const1); - EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(encoding1.c_str(), outof(error_msg))) + EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(encoding1.c_str(), &error_msg)) << error_msg << " " << encoding1; std::vector<std::string> split1; - EXPECT_TRUE(OatFile::GetDexLocationsFromDependencies(encoding1.c_str(), outof(split1))); + EXPECT_TRUE(OatFile::GetDexLocationsFromDependencies(encoding1.c_str(), &split1)); ASSERT_EQ(split1.size(), 1U); EXPECT_EQ(split1[0], dex_files_const1[0]->GetLocation()); @@ -104,10 +103,10 @@ TEST_F(OatFileTest, DexFileDependencies) { EXPECT_GT(dex_files2.size(), 1U); std::vector<const DexFile*> dex_files_const2 = ToConstDexFiles(dex_files2); std::string encoding2 = OatFile::EncodeDexFileDependencies(dex_files_const2); - EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(encoding2.c_str(), outof(error_msg))) + EXPECT_TRUE(OatFile::CheckStaticDexFileDependencies(encoding2.c_str(), &error_msg)) << error_msg << " " << encoding2; std::vector<std::string> split2; - EXPECT_TRUE(OatFile::GetDexLocationsFromDependencies(encoding2.c_str(), outof(split2))); + EXPECT_TRUE(OatFile::GetDexLocationsFromDependencies(encoding2.c_str(), &split2)); ASSERT_EQ(split2.size(), 2U); EXPECT_EQ(split2[0], dex_files_const2[0]->GetLocation()); EXPECT_EQ(split2[1], dex_files_const2[1]->GetLocation()); diff --git a/runtime/parsed_options.cc b/runtime/parsed_options.cc index 7f82497531..25b5e49b3d 100644 --- a/runtime/parsed_options.cc +++ b/runtime/parsed_options.cc @@ -18,7 +18,6 @@ #include <sstream> -#include "base/out.h" #include "base/stringpiece.h" #include "debugger.h" #include "gc/heap.h" @@ -42,11 +41,12 @@ ParsedOptions::ParsedOptions() // Runtime::Abort } -ParsedOptions* ParsedOptions::Create(const RuntimeOptions& options, - bool ignore_unrecognized, - out<RuntimeArgumentMap> runtime_options) { +ParsedOptions* ParsedOptions::Create(const RuntimeOptions& options, bool ignore_unrecognized, + RuntimeArgumentMap* runtime_options) { + CHECK(runtime_options != nullptr); + std::unique_ptr<ParsedOptions> parsed(new ParsedOptions()); - if (parsed->Parse(options, ignore_unrecognized, outof_forward(runtime_options))) { + if (parsed->Parse(options, ignore_unrecognized, runtime_options)) { return parsed.release(); } return nullptr; @@ -293,7 +293,6 @@ std::unique_ptr<RuntimeParser> ParsedOptions::MakeParser(bool ignore_unrecognize // As a side-effect, populate the hooks from options. bool ParsedOptions::ProcessSpecialOptions(const RuntimeOptions& options, RuntimeArgumentMap* runtime_options, - // TODO: should be an optional_out here. std::vector<std::string>* out_options) { using M = RuntimeArgumentMap; @@ -400,7 +399,7 @@ static void MaybeOverrideVerbosity() { } bool ParsedOptions::Parse(const RuntimeOptions& options, bool ignore_unrecognized, - out<RuntimeArgumentMap> runtime_options) { + RuntimeArgumentMap* runtime_options) { for (size_t i = 0; i < options.size(); ++i) { if (true && options[0].first == "-Xzygote") { LOG(INFO) << "option[" << i << "]=" << options[i].first; @@ -411,9 +410,7 @@ bool ParsedOptions::Parse(const RuntimeOptions& options, bool ignore_unrecognize // Convert to a simple string list (without the magic pointer options) std::vector<std::string> argv_list; - if (!ProcessSpecialOptions(options, - nullptr, // No runtime argument map - outof(argv_list))) { + if (!ProcessSpecialOptions(options, nullptr, &argv_list)) { return false; } diff --git a/runtime/parsed_options.h b/runtime/parsed_options.h index bcd6228b7a..529dd5ce1c 100644 --- a/runtime/parsed_options.h +++ b/runtime/parsed_options.h @@ -22,7 +22,6 @@ #include <jni.h> -#include "base/out_fwd.h" #include "globals.h" #include "gc/collector_type.h" #include "gc/space/large_object_space.h" @@ -51,9 +50,8 @@ class ParsedOptions { static std::unique_ptr<RuntimeParser> MakeParser(bool ignore_unrecognized); // returns true if parsing succeeds, and stores the resulting options into runtime_options - static ParsedOptions* Create(const RuntimeOptions& options, - bool ignore_unrecognized, - out<RuntimeArgumentMap> runtime_options); + static ParsedOptions* Create(const RuntimeOptions& options, bool ignore_unrecognized, + RuntimeArgumentMap* runtime_options); bool (*hook_is_sensitive_thread_)(); jint (*hook_vfprintf_)(FILE* stream, const char* format, va_list ap); @@ -65,7 +63,6 @@ class ParsedOptions { bool ProcessSpecialOptions(const RuntimeOptions& options, RuntimeArgumentMap* runtime_options, - // Optional out: std::vector<std::string>* out_options); void Usage(const char* fmt, ...); @@ -75,9 +72,8 @@ class ParsedOptions { void Exit(int status); void Abort(); - bool Parse(const RuntimeOptions& options, - bool ignore_unrecognized, - out<RuntimeArgumentMap> runtime_options); + bool Parse(const RuntimeOptions& options, bool ignore_unrecognized, + RuntimeArgumentMap* runtime_options); }; } // namespace art diff --git a/runtime/parsed_options_test.cc b/runtime/parsed_options_test.cc index 81a48a68cf..a8575de425 100644 --- a/runtime/parsed_options_test.cc +++ b/runtime/parsed_options_test.cc @@ -18,7 +18,6 @@ #include <memory> -#include "base/out.h" #include "common_runtime_test.h" namespace art { @@ -61,7 +60,7 @@ TEST_F(ParsedOptionsTest, ParsedOptions) { options.push_back(std::make_pair("exit", test_exit)); RuntimeArgumentMap map; - std::unique_ptr<ParsedOptions> parsed(ParsedOptions::Create(options, false, outof(map))); + std::unique_ptr<ParsedOptions> parsed(ParsedOptions::Create(options, false, &map)); ASSERT_TRUE(parsed.get() != nullptr); ASSERT_NE(0u, map.Size()); @@ -103,7 +102,7 @@ TEST_F(ParsedOptionsTest, ParsedOptionsGc) { options.push_back(std::make_pair("-Xgc:MC", nullptr)); RuntimeArgumentMap map; - std::unique_ptr<ParsedOptions> parsed(ParsedOptions::Create(options, false, outof(map))); + std::unique_ptr<ParsedOptions> parsed(ParsedOptions::Create(options, false, &map)); ASSERT_TRUE(parsed.get() != nullptr); ASSERT_NE(0u, map.Size()); diff --git a/runtime/runtime.cc b/runtime/runtime.cc index a27acb22e5..1914124600 100644 --- a/runtime/runtime.cc +++ b/runtime/runtime.cc @@ -56,7 +56,6 @@ #include "atomic.h" #include "base/arena_allocator.h" #include "base/dumpable.h" -#include "base/out.h" #include "base/unix_file/fd_file.h" #include "class_linker-inl.h" #include "compiler_callbacks.h" @@ -308,8 +307,8 @@ struct AbortState { Thread* self = Thread::Current(); if (self == nullptr) { os << "(Aborting thread was not attached to runtime!)\n"; - DumpKernelStack(os, GetTid(), " kernel: ", false /* don't include count */); - DumpNativeStack(os, GetTid(), " native: ", nullptr /* no ucontext ptr */); + DumpKernelStack(os, GetTid(), " kernel: ", false); + DumpNativeStack(os, GetTid(), " native: ", nullptr); } else { os << "Aborting thread:\n"; if (Locks::mutator_lock_->IsExclusiveHeld(self) || Locks::mutator_lock_->IsSharedHeld(self)) { @@ -418,7 +417,7 @@ bool Runtime::Create(const RuntimeOptions& options, bool ignore_unrecognized) { if (Runtime::instance_ != nullptr) { return false; } - InitLogging(nullptr /* no argv */); // Calls Locks::Init() as a side effect. + InitLogging(nullptr); // Calls Locks::Init() as a side effect. instance_ = new Runtime; if (!instance_->Init(options, ignore_unrecognized)) { // TODO: Currently deleting the instance will abort the runtime on destruction. Now This will @@ -660,7 +659,7 @@ void Runtime::DidForkFromZygote(JNIEnv* env, NativeBridgeAction action, const ch // before fork aren't attributed to an app. heap_->ResetGcPerformanceInfo(); - if (jit_ == nullptr && jit_options_->UseJIT()) { + if (jit_.get() == nullptr && jit_options_->UseJIT()) { // Create the JIT if the flag is set and we haven't already create it (happens for run-tests). CreateJit(); } @@ -708,8 +707,9 @@ void Runtime::StartDaemonThreads() { } static bool OpenDexFilesFromImage(const std::string& image_location, - out<std::vector<std::unique_ptr<const DexFile>>> dex_files, - out<size_t> failures) { + std::vector<std::unique_ptr<const DexFile>>* dex_files, + size_t* failures) { + DCHECK(dex_files != nullptr) << "OpenDexFilesFromImage: out-param is nullptr"; std::string system_filename; bool has_system = false; std::string cache_filename_unused; @@ -718,12 +718,12 @@ static bool OpenDexFilesFromImage(const std::string& image_location, bool is_global_cache_unused; bool found_image = gc::space::ImageSpace::FindImageFilename(image_location.c_str(), kRuntimeISA, - outof(system_filename), - outof(has_system), - outof(cache_filename_unused), - outof(dalvik_cache_exists_unused), - outof(has_cache_unused), - outof(is_global_cache_unused)); + &system_filename, + &has_system, + &cache_filename_unused, + &dalvik_cache_exists_unused, + &has_cache_unused, + &is_global_cache_unused); *failures = 0; if (!found_image || !has_system) { return false; @@ -737,12 +737,12 @@ static bool OpenDexFilesFromImage(const std::string& image_location, if (file.get() == nullptr) { return false; } - std::unique_ptr<ElfFile> elf_file(ElfFile::Open(file.release(), false, false, outof(error_msg))); + std::unique_ptr<ElfFile> elf_file(ElfFile::Open(file.release(), false, false, &error_msg)); if (elf_file.get() == nullptr) { return false; } std::unique_ptr<OatFile> oat_file(OatFile::OpenWithElfFile(elf_file.release(), oat_location, - nullptr, outof(error_msg))); + nullptr, &error_msg)); if (oat_file.get() == nullptr) { LOG(INFO) << "Unable to use '" << oat_filename << "' because " << error_msg; return false; @@ -753,7 +753,7 @@ static bool OpenDexFilesFromImage(const std::string& image_location, *failures += 1; continue; } - std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(outof(error_msg)); + std::unique_ptr<const DexFile> dex_file = oat_dex_file->OpenDexFile(&error_msg); if (dex_file.get() == nullptr) { *failures += 1; } else { @@ -768,11 +768,10 @@ static bool OpenDexFilesFromImage(const std::string& image_location, static size_t OpenDexFiles(const std::vector<std::string>& dex_filenames, const std::vector<std::string>& dex_locations, const std::string& image_location, - out<std::vector<std::unique_ptr<const DexFile>>> dex_files) { + std::vector<std::unique_ptr<const DexFile>>* dex_files) { + DCHECK(dex_files != nullptr) << "OpenDexFiles: out-param is nullptr"; size_t failure_count = 0; - if (!image_location.empty() && OpenDexFilesFromImage(image_location, - outof_forward(dex_files), - outof(failure_count))) { + if (!image_location.empty() && OpenDexFilesFromImage(image_location, dex_files, &failure_count)) { return failure_count; } failure_count = 0; @@ -784,7 +783,7 @@ static size_t OpenDexFiles(const std::vector<std::string>& dex_filenames, LOG(WARNING) << "Skipping non-existent dex file '" << dex_filename << "'"; continue; } - if (!DexFile::Open(dex_filename, dex_location, outof(error_msg), outof_forward(dex_files))) { + if (!DexFile::Open(dex_filename, dex_location, &error_msg, dex_files)) { LOG(WARNING) << "Failed to open .dex from file '" << dex_filename << "': " << error_msg; ++failure_count; } @@ -801,7 +800,7 @@ bool Runtime::Init(const RuntimeOptions& raw_options, bool ignore_unrecognized) using Opt = RuntimeArgumentMap; RuntimeArgumentMap runtime_options; std::unique_ptr<ParsedOptions> parsed_options( - ParsedOptions::Create(raw_options, ignore_unrecognized, outof(runtime_options))); + ParsedOptions::Create(raw_options, ignore_unrecognized, &runtime_options)); if (parsed_options.get() == nullptr) { LOG(ERROR) << "Failed to parse options"; ATRACE_END(); @@ -1039,7 +1038,7 @@ bool Runtime::Init(const RuntimeOptions& raw_options, bool ignore_unrecognized) OpenDexFiles(dex_filenames, dex_locations, runtime_options.GetOrDefault(Opt::Image), - outof(boot_class_path)); + &boot_class_path); instruction_set_ = runtime_options.GetOrDefault(Opt::ImageInstructionSet); class_linker_->InitWithoutImage(std::move(boot_class_path)); @@ -1168,7 +1167,7 @@ void Runtime::InitNativeMethods() { // the library that implements System.loadLibrary! { std::string reason; - if (!java_vm_->LoadNativeLibrary(env, "libjavacore.so", nullptr, outof(reason))) { + if (!java_vm_->LoadNativeLibrary(env, "libjavacore.so", nullptr, &reason)) { LOG(FATAL) << "LoadNativeLibrary failed for \"libjavacore.so\": " << reason; } } @@ -1331,9 +1330,7 @@ void Runtime::BlockSignals() { signals.Block(); } -bool Runtime::AttachCurrentThread(const char* thread_name, - bool as_daemon, - jobject thread_group, +bool Runtime::AttachCurrentThread(const char* thread_name, bool as_daemon, jobject thread_group, bool create_peer) { return Thread::Attach(thread_name, as_daemon, thread_group, create_peer) != nullptr; } @@ -1439,8 +1436,7 @@ void Runtime::VisitThreadRoots(RootVisitor* visitor) { thread_list_->VisitRoots(visitor); } -size_t Runtime::FlipThreadRoots(Closure* thread_flip_visitor, - Closure* flip_callback, +size_t Runtime::FlipThreadRoots(Closure* thread_flip_visitor, Closure* flip_callback, gc::collector::GarbageCollector* collector) { return thread_list_->FlipThreadRoots(thread_flip_visitor, flip_callback, collector); } @@ -1627,64 +1623,50 @@ void Runtime::ThrowTransactionAbortError(Thread* self) { preinitialization_transaction_->ThrowAbortError(self, nullptr); } -void Runtime::RecordWriteFieldBoolean(mirror::Object* obj, - MemberOffset field_offset, - uint8_t value, - bool is_volatile) const { +void Runtime::RecordWriteFieldBoolean(mirror::Object* obj, MemberOffset field_offset, + uint8_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteFieldBoolean(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteFieldByte(mirror::Object* obj, - MemberOffset field_offset, - int8_t value, - bool is_volatile) const { +void Runtime::RecordWriteFieldByte(mirror::Object* obj, MemberOffset field_offset, + int8_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteFieldByte(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteFieldChar(mirror::Object* obj, - MemberOffset field_offset, - uint16_t value, - bool is_volatile) const { +void Runtime::RecordWriteFieldChar(mirror::Object* obj, MemberOffset field_offset, + uint16_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteFieldChar(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteFieldShort(mirror::Object* obj, - MemberOffset field_offset, - int16_t value, - bool is_volatile) const { +void Runtime::RecordWriteFieldShort(mirror::Object* obj, MemberOffset field_offset, + int16_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteFieldShort(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteField32(mirror::Object* obj, - MemberOffset field_offset, - uint32_t value, - bool is_volatile) const { +void Runtime::RecordWriteField32(mirror::Object* obj, MemberOffset field_offset, + uint32_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteField32(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteField64(mirror::Object* obj, - MemberOffset field_offset, - uint64_t value, - bool is_volatile) const { +void Runtime::RecordWriteField64(mirror::Object* obj, MemberOffset field_offset, + uint64_t value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteField64(obj, field_offset, value, is_volatile); } -void Runtime::RecordWriteFieldReference(mirror::Object* obj, - MemberOffset field_offset, - mirror::Object* value, - bool is_volatile) const { +void Runtime::RecordWriteFieldReference(mirror::Object* obj, MemberOffset field_offset, + mirror::Object* value, bool is_volatile) const { DCHECK(IsAotCompiler()); DCHECK(IsActiveTransaction()); preinitialization_transaction_->RecordWriteFieldReference(obj, field_offset, value, is_volatile); @@ -1725,7 +1707,7 @@ void Runtime::SetFaultMessage(const std::string& message) { fault_message_ = message; } -void Runtime::AddCurrentRuntimeFeaturesAsDex2OatArguments(out<std::vector<std::string>> argv) +void Runtime::AddCurrentRuntimeFeaturesAsDex2OatArguments(std::vector<std::string>* argv) const { if (GetInstrumentation()->InterpretOnly() || UseJit()) { argv->push_back("--compiler-filter=interpret-only"); diff --git a/runtime/runtime.h b/runtime/runtime.h index 206623e86e..4577b75397 100644 --- a/runtime/runtime.h +++ b/runtime/runtime.h @@ -28,7 +28,6 @@ #include "arch/instruction_set.h" #include "base/macros.h" -#include "base/out.h" #include "gc_root.h" #include "instrumentation.h" #include "jobject_comparator.h" @@ -225,9 +224,7 @@ class Runtime { jobject GetSystemClassLoader() const; // Attaches the calling native thread to the runtime. - bool AttachCurrentThread(const char* thread_name, - bool as_daemon, - jobject thread_group, + bool AttachCurrentThread(const char* thread_name, bool as_daemon, jobject thread_group, bool create_peer); void CallExitHook(jint status); @@ -289,7 +286,8 @@ class Runtime { mirror::Throwable* GetPreAllocatedOutOfMemoryError() SHARED_REQUIRES(Locks::mutator_lock_); - mirror::Throwable* GetPreAllocatedNoClassDefFoundError() SHARED_REQUIRES(Locks::mutator_lock_); + mirror::Throwable* GetPreAllocatedNoClassDefFoundError() + SHARED_REQUIRES(Locks::mutator_lock_); const std::vector<std::string>& GetProperties() const { return properties_; @@ -318,7 +316,8 @@ class Runtime { void VisitImageRoots(RootVisitor* visitor) SHARED_REQUIRES(Locks::mutator_lock_); // Visit all of the roots we can do safely do concurrently. - void VisitConcurrentRoots(RootVisitor* visitor, VisitRootFlags flags = kVisitRootFlagAllRoots) + void VisitConcurrentRoots(RootVisitor* visitor, + VisitRootFlags flags = kVisitRootFlagAllRoots) SHARED_REQUIRES(Locks::mutator_lock_); // Visit all of the non thread roots, we can do this with mutators unpaused. @@ -332,8 +331,7 @@ class Runtime { void VisitThreadRoots(RootVisitor* visitor) SHARED_REQUIRES(Locks::mutator_lock_); // Flip thread roots from from-space refs to to-space refs. - size_t FlipThreadRoots(Closure* thread_flip_visitor, - Closure* flip_callback, + size_t FlipThreadRoots(Closure* thread_flip_visitor, Closure* flip_callback, gc::collector::GarbageCollector* collector) REQUIRES(!Locks::mutator_lock_); @@ -469,34 +467,20 @@ class Runtime { void ThrowTransactionAbortError(Thread* self) SHARED_REQUIRES(Locks::mutator_lock_); - void RecordWriteFieldBoolean(mirror::Object* obj, - MemberOffset field_offset, - uint8_t value, + void RecordWriteFieldBoolean(mirror::Object* obj, MemberOffset field_offset, uint8_t value, bool is_volatile) const; - void RecordWriteFieldByte(mirror::Object* obj, - MemberOffset field_offset, - int8_t value, + void RecordWriteFieldByte(mirror::Object* obj, MemberOffset field_offset, int8_t value, bool is_volatile) const; - void RecordWriteFieldChar(mirror::Object* obj, - MemberOffset field_offset, - uint16_t value, + void RecordWriteFieldChar(mirror::Object* obj, MemberOffset field_offset, uint16_t value, bool is_volatile) const; - void RecordWriteFieldShort(mirror::Object* obj, - MemberOffset field_offset, - int16_t value, + void RecordWriteFieldShort(mirror::Object* obj, MemberOffset field_offset, int16_t value, bool is_volatile) const; - void RecordWriteField32(mirror::Object* obj, - MemberOffset field_offset, - uint32_t value, + void RecordWriteField32(mirror::Object* obj, MemberOffset field_offset, uint32_t value, bool is_volatile) const; - void RecordWriteField64(mirror::Object* obj, - MemberOffset field_offset, - uint64_t value, + void RecordWriteField64(mirror::Object* obj, MemberOffset field_offset, uint64_t value, bool is_volatile) const; - void RecordWriteFieldReference(mirror::Object* obj, - MemberOffset field_offset, - mirror::Object* value, - bool is_volatile) const; + void RecordWriteFieldReference(mirror::Object* obj, MemberOffset field_offset, + mirror::Object* value, bool is_volatile) const; void RecordWriteArray(mirror::Array* array, size_t index, uint64_t value) const SHARED_REQUIRES(Locks::mutator_lock_); void RecordStrongStringInsertion(mirror::String* s) const @@ -515,7 +499,7 @@ class Runtime { return fault_message_; } - void AddCurrentRuntimeFeaturesAsDex2OatArguments(out<std::vector<std::string>> arg_vector) const; + void AddCurrentRuntimeFeaturesAsDex2OatArguments(std::vector<std::string>* arg_vector) const; bool ExplicitStackOverflowChecks() const { return !implicit_so_checks_; diff --git a/runtime/stack.cc b/runtime/stack.cc index 2916eaaf5e..b07b244282 100644 --- a/runtime/stack.cc +++ b/runtime/stack.cc @@ -19,7 +19,6 @@ #include "arch/context.h" #include "art_method-inl.h" #include "base/hex_dump.h" -#include "base/out.h" #include "entrypoints/entrypoint_utils-inl.h" #include "entrypoints/runtime_asm_entrypoints.h" #include "gc_map.h" @@ -181,7 +180,7 @@ mirror::Object* StackVisitor::GetThisObject() const { } else { uint16_t reg = code_item->registers_size_ - code_item->ins_size_; uint32_t value = 0; - bool success = GetVReg(m, reg, kReferenceVReg, outof(value)); + bool success = GetVReg(m, reg, kReferenceVReg, &value); // We currently always guarantee the `this` object is live throughout the method. CHECK(success) << "Failed to read the this object in " << PrettyMethod(m); return reinterpret_cast<mirror::Object*>(value); @@ -376,8 +375,8 @@ bool StackVisitor::GetVRegPairFromQuickCode(ArtMethod* m, uint16_t vreg, VRegKin QuickMethodFrameInfo frame_info = m->GetQuickFrameInfo(code_pointer); uint32_t vmap_offset_lo, vmap_offset_hi; // TODO: IsInContext stops before spotting floating point registers. - if (vmap_table.IsInContext(vreg, kind_lo, outof(vmap_offset_lo)) && - vmap_table.IsInContext(vreg + 1, kind_hi, outof(vmap_offset_hi))) { + if (vmap_table.IsInContext(vreg, kind_lo, &vmap_offset_lo) && + vmap_table.IsInContext(vreg + 1, kind_hi, &vmap_offset_hi)) { bool is_float = (kind_lo == kDoubleLoVReg); uint32_t spill_mask = is_float ? frame_info.FpSpillMask() : frame_info.CoreSpillMask(); uint32_t reg_lo = vmap_table.ComputeRegister(spill_mask, vmap_offset_lo, kind_lo); @@ -400,8 +399,8 @@ bool StackVisitor::GetVRegPairFromOptimizedCode(ArtMethod* m, uint16_t vreg, uint64_t* val) const { uint32_t low_32bits; uint32_t high_32bits; - bool success = GetVRegFromOptimizedCode(m, vreg, kind_lo, outof(low_32bits)); - success &= GetVRegFromOptimizedCode(m, vreg + 1, kind_hi, outof(high_32bits)); + bool success = GetVRegFromOptimizedCode(m, vreg, kind_lo, &low_32bits); + success &= GetVRegFromOptimizedCode(m, vreg + 1, kind_hi, &high_32bits); if (success) { *val = (static_cast<uint64_t>(high_32bits) << 32) | static_cast<uint64_t>(low_32bits); } @@ -453,7 +452,7 @@ bool StackVisitor::SetVRegFromQuickCode(ArtMethod* m, uint16_t vreg, uint32_t ne QuickMethodFrameInfo frame_info = m->GetQuickFrameInfo(code_pointer); uint32_t vmap_offset; // TODO: IsInContext stops before spotting floating point registers. - if (vmap_table.IsInContext(vreg, kind, outof(vmap_offset))) { + if (vmap_table.IsInContext(vreg, kind, &vmap_offset)) { bool is_float = (kind == kFloatVReg) || (kind == kDoubleLoVReg) || (kind == kDoubleHiVReg); uint32_t spill_mask = is_float ? frame_info.FpSpillMask() : frame_info.CoreSpillMask(); uint32_t reg = vmap_table.ComputeRegister(spill_mask, vmap_offset, kind); @@ -533,8 +532,8 @@ bool StackVisitor::SetVRegPairFromQuickCode( QuickMethodFrameInfo frame_info = m->GetQuickFrameInfo(code_pointer); uint32_t vmap_offset_lo, vmap_offset_hi; // TODO: IsInContext stops before spotting floating point registers. - if (vmap_table.IsInContext(vreg, kind_lo, outof(vmap_offset_lo)) && - vmap_table.IsInContext(vreg + 1, kind_hi, outof(vmap_offset_hi))) { + if (vmap_table.IsInContext(vreg, kind_lo, &vmap_offset_lo) && + vmap_table.IsInContext(vreg + 1, kind_hi, &vmap_offset_hi)) { bool is_float = (kind_lo == kDoubleLoVReg); uint32_t spill_mask = is_float ? frame_info.FpSpillMask() : frame_info.CoreSpillMask(); uint32_t reg_lo = vmap_table.ComputeRegister(spill_mask, vmap_offset_lo, kind_lo); |