diff options
| author | Nick Kralevich <nnk@google.com> | 2018-08-24 12:16:17 -0700 |
|---|---|---|
| committer | Nick Kralevich <nnk@google.com> | 2018-08-24 12:16:17 -0700 |
| commit | 38e9f2320ad711303f168c19be259d89ae74df20 (patch) | |
| tree | 83caf6a42acabd6bebc24f01785524510e29e856 /toolbox | |
| parent | e58548e5f57ae1b750df91d4bfc76f2a560fff23 (diff) | |
| download | system_core-38e9f2320ad711303f168c19be259d89ae74df20.tar.gz system_core-38e9f2320ad711303f168c19be259d89ae74df20.tar.bz2 system_core-38e9f2320ad711303f168c19be259d89ae74df20.zip | |
getevent: O_RDWR -> O_RDONLY | O_CLOEXEC
No need to open the device read write. Just open it read-only.
This is a partial redo of
https://android-review.googlesource.com/c/platform/system/core/+/334583
which was reverted in
https://android-review.googlesource.com/c/platform/system/core/+/342483
Bug: 30861057
Test: ran getevent, saw correct output, played with device
Change-Id: I426efd68f39dcd97d3ee23c13ed1a9ed96cb4c2e
Diffstat (limited to 'toolbox')
| -rw-r--r-- | toolbox/getevent.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/toolbox/getevent.c b/toolbox/getevent.c index e6def6bae..39033ad4d 100644 --- a/toolbox/getevent.c +++ b/toolbox/getevent.c @@ -321,7 +321,7 @@ static int open_device(const char *device, int print_flags) char idstr[80]; struct input_id id; - fd = open(device, O_RDWR); + fd = open(device, O_RDONLY | O_CLOEXEC); if(fd < 0) { if(print_flags & PRINT_DEVICE_ERRORS) fprintf(stderr, "could not open %s, %s\n", device, strerror(errno)); |