diff options
| author | bohu <bohu@google.com> | 2017-03-01 23:31:14 -0800 |
|---|---|---|
| committer | bohu <bohu@google.com> | 2017-03-28 09:27:43 -0700 |
| commit | a19abf17697863c2458d7d085a225ff4f3c75f75 (patch) | |
| tree | 6bef3519c2d8b6e0205bb1dbc91e2f6c35cfbd42 /qemu_pipe/include | |
| parent | 7b60bd95dfa07e86325b432465fb0043648f6c97 (diff) | |
| download | system_core-a19abf17697863c2458d7d085a225ff4f3c75f75.tar.gz system_core-a19abf17697863c2458d7d085a225ff4f3c75f75.tar.bz2 system_core-a19abf17697863c2458d7d085a225ff4f3c75f75.zip | |
Qemu: make the qemu_pipe_open back compatible
Commit c7b098ceb528afc62b1545377201e45f5d37f974 has changed
the qemu_pipe_open interface to require the "pipe:" prefix in
the service name.
However in APIs 24 and before, the "pipe:" prefix is not required
This causes quite some confusion and bugs since it is very common
to forget the difference when working across differnet APIs.
This CL is meant to make qemu_pipe_open work in both cases by
doing the following:
1. try the service name as is;
2. if it fails, add 'pipe:' prefix and try the service name again.
Change-Id: If9782396c03780fad1aadeb8374eb308517dc963
(cherry picked from aosp f7d64fd8e1703c54ff01c2e53b0af850977777a0)
Diffstat (limited to 'qemu_pipe/include')
| -rw-r--r-- | qemu_pipe/include/qemu_pipe.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/qemu_pipe/include/qemu_pipe.h b/qemu_pipe/include/qemu_pipe.h index 16486c087..098749899 100644 --- a/qemu_pipe/include/qemu_pipe.h +++ b/qemu_pipe/include/qemu_pipe.h @@ -28,8 +28,10 @@ extern "C" { // This file descriptor can be used as a standard pipe/socket descriptor. // // 'pipeName' is the name of the emulator service you want to connect to, -// and must begin with 'pipe:' (e.g. 'pipe:camera' or 'pipe:opengles'). -// +// and should begin with 'pipe:' (e.g. 'pipe:camera' or 'pipe:opengles'). +// For backward compatibility, the 'pipe:' prefix can be omitted, and in +// that case, qemu_pipe_open will add it for you. + // On success, return a valid file descriptor, or -1/errno on failure. E.g.: // // EINVAL -> unknown/unsupported pipeName |