summaryrefslogtreecommitdiffstats
path: root/logwrapper/include
diff options
context:
space:
mode:
authorNarayan Kamath <narayan@google.com>2017-03-22 10:26:11 +0000
committerNarayan Kamath <narayan@google.com>2017-03-22 11:00:43 +0000
commitabd4613f05664510951a55b76e2061f729b51b7c (patch)
tree1133a0daf7dfca14c9e4128c83fbe69b308175f5 /logwrapper/include
parent450c44052c53e68fa6c6fcd13e7c34a08d9c7bb1 (diff)
downloadsystem_core-abd4613f05664510951a55b76e2061f729b51b7c.tar.gz
system_core-abd4613f05664510951a55b76e2061f729b51b7c.tar.bz2
system_core-abd4613f05664510951a55b76e2061f729b51b7c.zip
Logwrapper: Remove unused support for input / output processing.
Should make it easier to switch callers over to posix_spawn once that's available. NOTE: The (now) unused arguments will be removed in a followup (multi-project)c hange once we empirically confirm that there aren't any prebuilt blobs using this function. I did readelf all currently checked in prebuilts to look for a reference to this method, but one can never be too paranoid. Test: make checkbuild Change-Id: I454d80c52f269c31846133cc54375decd702fe71
Diffstat (limited to 'logwrapper/include')
-rw-r--r--logwrapper/include/logwrap/logwrap.h31
1 files changed, 5 insertions, 26 deletions
diff --git a/logwrapper/include/logwrap/logwrap.h b/logwrapper/include/logwrap/logwrap.h
index 89a8fddcc..d3538b30c 100644
--- a/logwrapper/include/logwrap/logwrap.h
+++ b/logwrapper/include/logwrap/logwrap.h
@@ -54,9 +54,8 @@ __BEGIN_DECLS
* the specified log until the child has exited.
* file_path: if log_target has the LOG_FILE bit set, then this parameter
* must be set to the pathname of the file to log to.
- * opts: set to non-NULL if you want to use one or more of the
- * FORK_EXECVP_OPTION_* features.
- * opts_len: the length of the opts array. When opts is NULL, pass 0.
+ * unused_opts: currently unused.
+ * unused_opts_len: currently unused.
*
* Return value:
* 0 when logwrap successfully run the child process and captured its status
@@ -72,30 +71,10 @@ __BEGIN_DECLS
#define LOG_KLOG 2
#define LOG_FILE 4
-/* Write data to child's stdin. */
-#define FORK_EXECVP_OPTION_INPUT 0
-/* Capture data from child's stdout and stderr. */
-#define FORK_EXECVP_OPTION_CAPTURE_OUTPUT 1
-
-struct AndroidForkExecvpOption {
- int opt_type;
- union {
- struct {
- const uint8_t* input;
- size_t input_len;
- } opt_input;
- struct {
- void (*on_output)(const uint8_t* /*output*/,
- size_t /*output_len*/,
- void* /* user_pointer */);
- void* user_pointer;
- } opt_capture_output;
- };
-};
-
+// TODO: Remove unused_opts / unused_opts_len in a followup change.
int android_fork_execvp_ext(int argc, char* argv[], int *status, bool ignore_int_quit,
- int log_target, bool abbreviated, char *file_path,
- const struct AndroidForkExecvpOption* opts, size_t opts_len);
+ int log_target, bool abbreviated, char *file_path, void* unused_opts,
+ int unused_opts_len);
/* Similar to above, except abbreviated logging is not available, and if logwrap
* is true, logging is to the Android system log, and if false, there is no