diff options
author | Chih-Hung Hsieh <chh@google.com> | 2016-08-02 11:31:44 -0700 |
---|---|---|
committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-02 11:31:44 -0700 |
commit | 9e70ba6352ad1ee4fdb3f70a8945c2985638de77 (patch) | |
tree | 8c133f336ab8ec13367783970c5c1af50e33996c /logd/LogStatistics.h | |
parent | c97b73aa83fc7b80b60d88d856675d4ab502296d (diff) | |
download | system_core-9e70ba6352ad1ee4fdb3f70a8945c2985638de77.tar.gz system_core-9e70ba6352ad1ee4fdb3f70a8945c2985638de77.tar.bz2 system_core-9e70ba6352ad1ee4fdb3f70a8945c2985638de77.zip |
Fix google-explicit-constructor warnings in logd.
Bug: 28341362
Change-Id: I5b419c40593982925034e9b7217b0eb53c51adcb
Test: build with WITH_TIDY=1
Diffstat (limited to 'logd/LogStatistics.h')
-rw-r--r-- | logd/LogStatistics.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/logd/LogStatistics.h b/logd/LogStatistics.h index 71ad73aef..878c33381 100644 --- a/logd/LogStatistics.h +++ b/logd/LogStatistics.h @@ -166,7 +166,7 @@ struct EntryBase { size_t size; EntryBase():size(0) { } - EntryBase(LogBufferElement *element):size(element->getMsgLen()) { } + explicit EntryBase(LogBufferElement *element):size(element->getMsgLen()) { } size_t getSizes() const { return size; } @@ -201,7 +201,7 @@ struct EntryBaseDropped : public EntryBase { size_t dropped; EntryBaseDropped():dropped(0) { } - EntryBaseDropped(LogBufferElement *element): + explicit EntryBaseDropped(LogBufferElement *element): EntryBase(element), dropped(element->getDropped()) { } @@ -226,7 +226,7 @@ struct UidEntry : public EntryBaseDropped { const uid_t uid; pid_t pid; - UidEntry(LogBufferElement *element): + explicit UidEntry(LogBufferElement *element): EntryBaseDropped(element), uid(element->getUid()), pid(element->getPid()) { @@ -256,13 +256,13 @@ struct PidEntry : public EntryBaseDropped { uid_t uid; char *name; - PidEntry(pid_t pid): + explicit PidEntry(pid_t pid): EntryBaseDropped(), pid(pid), uid(android::pidToUid(pid)), name(android::pidToName(pid)) { } - PidEntry(LogBufferElement *element): + explicit PidEntry(LogBufferElement *element): EntryBaseDropped(element), pid(element->getPid()), uid(element->getUid()), @@ -320,7 +320,7 @@ struct TidEntry : public EntryBaseDropped { uid(android::pidToUid(tid)), name(android::tidToName(tid)) { } - TidEntry(LogBufferElement *element): + explicit TidEntry(LogBufferElement *element): EntryBaseDropped(element), tid(element->getTid()), pid(element->getPid()), @@ -375,7 +375,7 @@ struct TagEntry : public EntryBaseDropped { pid_t pid; uid_t uid; - TagEntry(LogBufferElement *element): + explicit TagEntry(LogBufferElement *element): EntryBaseDropped(element), tag(element->getTag()), pid(element->getPid()), @@ -407,7 +407,7 @@ class LogFindWorst { public: - LogFindWorst(std::unique_ptr<const TEntry *[]> &&sorted) : sorted(std::move(sorted)) { } + explicit LogFindWorst(std::unique_ptr<const TEntry *[]> &&sorted) : sorted(std::move(sorted)) { } void findWorst(int &worst, size_t &worst_sizes, size_t &second_worst_sizes, |