diff options
| author | Mark Salyzyn <salyzyn@google.com> | 2017-01-25 15:28:29 -0800 |
|---|---|---|
| committer | Mark Salyzyn <salyzyn@google.com> | 2017-01-25 15:29:29 -0800 |
| commit | e7e21ea67faeadaebe7c5300229bffd9e6dd76f6 (patch) | |
| tree | 235cdac18c9be1a1e868e5bd494d4d701dd384ff /logcat | |
| parent | 4d61417997a46592449d84ec2900c338ae5680d6 (diff) | |
| download | system_core-e7e21ea67faeadaebe7c5300229bffd9e6dd76f6.tar.gz system_core-e7e21ea67faeadaebe7c5300229bffd9e6dd76f6.tar.bz2 system_core-e7e21ea67faeadaebe7c5300229bffd9e6dd76f6.zip | |
logcat: test: increase retry on fgetLongTimestamp to 4, and sleep to settle to 3
Test: gTest logcat-unit-tests
Bug: 34454772
Change-Id: I8557b0f7f25c4aa160a23a2428c9b53c8e3b26e1
Diffstat (limited to 'logcat')
| -rw-r--r-- | logcat/tests/logcat_test.cpp | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/logcat/tests/logcat_test.cpp b/logcat/tests/logcat_test.cpp index 337861e6e..10d9e395b 100644 --- a/logcat/tests/logcat_test.cpp +++ b/logcat/tests/logcat_test.cpp @@ -171,8 +171,8 @@ char *fgetLongTime(char *buffer, size_t buflen, FILE *fp) { if (!ep) { continue; } - static const size_t tag_field_width = 7; - ep -= tag_field_width; + static const size_t pid_field_width = 7; + ep -= pid_field_width; *ep = '\0'; return cp; } @@ -184,14 +184,15 @@ char *fgetLongTime(char *buffer, size_t buflen, FILE *fp) { static size_t inject(ssize_t count) { if (count <= 0) return 0; - static const size_t retry = 3; + static const size_t retry = 4; size_t errors = retry; size_t num = 0; for(;;) { log_time ts(CLOCK_MONOTONIC); if (__android_log_btwrite(0, EVENT_TYPE_LONG, &ts, sizeof(ts)) >= 0) { if (++num >= (size_t)count) { - sleep(1); // let data settle end-to-end + // let data settle end-to-end + sleep(3); return num; } errors = retry; @@ -211,7 +212,7 @@ TEST(logcat, tz) { return; } - int tries = 3; // in case run too soon after system start or buffer clear + int tries = 4; // in case run too soon after system start or buffer clear int count; do { @@ -228,6 +229,8 @@ TEST(logcat, tz) { while (fgetLongTime(buffer, sizeof(buffer), fp)) { if (strstr(buffer, " -0700") || strstr(buffer, " -0800")) { ++count; + } else { + fprintf(stderr, "ts=\"%s\"\n", buffer + 2); } } @@ -261,7 +264,7 @@ TEST(logcat, ntz) { } void do_tail(int num) { - int tries = 3; // in case run too soon after system start or buffer clear + int tries = 4; // in case run too soon after system start or buffer clear int count; do { @@ -310,7 +313,7 @@ TEST(logcat, tail_time) { char *first_timestamp = NULL; char *cp; - int tries = 3; // in case run too soon after system start or buffer clear + int tries = 4; // in case run too soon after system start or buffer clear // Do not be tempted to use -v usec because that increases the // chances of an occasional test failure by 1000 (see below). |
