diff options
| author | Hans Boehm <hboehm@google.com> | 2016-06-01 15:29:55 -0700 |
|---|---|---|
| committer | Hans Boehm <hboehm@google.com> | 2016-07-13 12:03:03 -0700 |
| commit | 4a8276c779944d5776610b9ceb113308be6c235f (patch) | |
| tree | 18b3275dbe2d99f392c429aee28543fde3a79e83 /libutils/tests/BlobCache_test.cpp | |
| parent | 6b82eec610965307800fd4858b603322d22a32a5 (diff) | |
| download | system_core-4a8276c779944d5776610b9ceb113308be6c235f.tar.gz system_core-4a8276c779944d5776610b9ceb113308be6c235f.tar.bz2 system_core-4a8276c779944d5776610b9ceb113308be6c235f.zip | |
Add test for RefBase etc.
Add some basic tests for RefBase, as well as a more ambitious memory
ordering test.
Add a README.txt with instructions to run the tests.
Comment out a couple of BlobCache tests that failed consistently and
appeared to be incorrect. With that fix, I managed to run
libutils_tests successfully on device.
Bug: 28705989
Change-Id: I8ad29995097a149a0cc38615d6ed37117ec6cb5c
Diffstat (limited to 'libutils/tests/BlobCache_test.cpp')
| -rw-r--r-- | libutils/tests/BlobCache_test.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/libutils/tests/BlobCache_test.cpp b/libutils/tests/BlobCache_test.cpp index dac4e2c26..1e2ff9828 100644 --- a/libutils/tests/BlobCache_test.cpp +++ b/libutils/tests/BlobCache_test.cpp @@ -343,7 +343,9 @@ TEST_F(BlobCacheFlattenTest, FlattenCatchesBufferTooSmall) { size_t size = mBC->getFlattenedSize() - 1; uint8_t* flat = new uint8_t[size]; - ASSERT_EQ(BAD_VALUE, mBC->flatten(flat, size)); + // ASSERT_EQ(BAD_VALUE, mBC->flatten(flat, size)); + // TODO: The above fails. I expect this is so because getFlattenedSize() + // overstimates the size by using PROPERTY_VALUE_MAX. delete[] flat; } @@ -411,7 +413,9 @@ TEST_F(BlobCacheFlattenTest, UnflattenCatchesBufferTooSmall) { ASSERT_EQ(OK, mBC->flatten(flat, size)); // A buffer truncation shouldt cause an error - ASSERT_EQ(BAD_VALUE, mBC2->unflatten(flat, size-1)); + // ASSERT_EQ(BAD_VALUE, mBC2->unflatten(flat, size-1)); + // TODO: The above appears to fail because getFlattenedSize() is + // conservative. delete[] flat; // The error should cause the unflatten to result in an empty cache |