summaryrefslogtreecommitdiffstats
path: root/libstats
diff options
context:
space:
mode:
authorYao Chen <yaochen@google.com>2018-05-22 15:57:08 -0700
committerYao Chen <yaochen@google.com>2018-05-22 16:06:21 -0700
commit4d1deed139bbfabd7c3078a802e5b6a69f3ed8e8 (patch)
tree7dd8b29a043c72e27ed97bdf86e17b8385c6444f /libstats
parent931a840e8c3494a4fac881c6f7b8663679ca6a88 (diff)
downloadsystem_core-4d1deed139bbfabd7c3078a802e5b6a69f3ed8e8.tar.gz
system_core-4d1deed139bbfabd7c3078a802e5b6a69f3ed8e8.tar.bz2
system_core-4d1deed139bbfabd7c3078a802e5b6a69f3ed8e8.zip
Remove a redundant check in statsd socket code.
The original liblog code has this additional check because there may be multiple writers registered, there is a for-loop and the retVal is set to be the FIRST error. Statsd doesn't need it because it only has one writer. Test: locally tested. Change-Id: I03f0015d0c29eba19eb2b5ea145380cb98fb2509
Diffstat (limited to 'libstats')
-rw-r--r--libstats/stats_event_list.c13
1 files changed, 3 insertions, 10 deletions
diff --git a/libstats/stats_event_list.c b/libstats/stats_event_list.c
index 966bb08a2..3d746db18 100644
--- a/libstats/stats_event_list.c
+++ b/libstats/stats_event_list.c
@@ -131,7 +131,7 @@ static int __write_to_statsd_initialize_locked() {
}
static int __write_to_stats_daemon(struct iovec* vec, size_t nr) {
- int ret, save_errno;
+ int save_errno;
struct timespec ts;
size_t len, i;
@@ -145,14 +145,7 @@ static int __write_to_stats_daemon(struct iovec* vec, size_t nr) {
save_errno = errno;
clock_gettime(CLOCK_REALTIME, &ts);
- ret = 0;
-
- ssize_t retval;
- retval = (*statsdLoggerWrite.write)(&ts, vec, nr);
- if (ret >= 0) {
- ret = retval;
- }
-
+ int ret = (int)(*statsdLoggerWrite.write)(&ts, vec, nr);
errno = save_errno;
return ret;
}
@@ -178,4 +171,4 @@ static int __write_to_statsd_init(struct iovec* vec, size_t nr) {
ret = write_to_statsd(vec, nr);
errno = save_errno;
return ret;
-} \ No newline at end of file
+}