diff options
author | Christopher Ferris <cferris@google.com> | 2017-05-05 16:29:50 -0700 |
---|---|---|
committer | Christopher Ferris <cferris@google.com> | 2017-05-05 17:09:49 -0700 |
commit | 47e02f429d049d42afd4e10203aa64ae1c229032 (patch) | |
tree | 4b95c4778685459bdeafc705ed326fe880f41b31 /libmemunreachable | |
parent | 484acce026c14c8303dee845b8021d5a11e7d1a7 (diff) | |
download | system_core-47e02f429d049d42afd4e10203aa64ae1c229032.tar.gz system_core-47e02f429d049d42afd4e10203aa64ae1c229032.tar.bz2 system_core-47e02f429d049d42afd4e10203aa64ae1c229032.zip |
Small test fixes.
Bug: 31919199
Test: Ran the unit tests.
Change-Id: I62bdb007f9cfa57e3faaa05993fd6e23ce32b82f
Diffstat (limited to 'libmemunreachable')
-rw-r--r-- | libmemunreachable/tests/DisableMalloc_test.cpp | 4 | ||||
-rw-r--r-- | libmemunreachable/tests/MemUnreachable_test.cpp | 10 |
2 files changed, 8 insertions, 6 deletions
diff --git a/libmemunreachable/tests/DisableMalloc_test.cpp b/libmemunreachable/tests/DisableMalloc_test.cpp index ea5c22c88..4e6155b81 100644 --- a/libmemunreachable/tests/DisableMalloc_test.cpp +++ b/libmemunreachable/tests/DisableMalloc_test.cpp @@ -74,7 +74,7 @@ TEST_F(DisableMallocTest, deadlock_new) { { alarm(100ms); ScopedDisableMalloc disable_malloc; - char* ptr = new(char); + char* ptr = new (std::nothrow)(char); ASSERT_NE(ptr, nullptr); delete(ptr); } @@ -89,6 +89,8 @@ TEST_F(DisableMallocTest, deadlock_delete) { alarm(250ms); ScopedDisableMalloc disable_malloc; delete(ptr); + // Force ptr usage or this code gets optimized away by the arm64 compiler. + ASSERT_NE(ptr, nullptr); } }, ""); } diff --git a/libmemunreachable/tests/MemUnreachable_test.cpp b/libmemunreachable/tests/MemUnreachable_test.cpp index 2ae3db83e..71da3655a 100644 --- a/libmemunreachable/tests/MemUnreachable_test.cpp +++ b/libmemunreachable/tests/MemUnreachable_test.cpp @@ -23,8 +23,6 @@ #include <memunreachable/memunreachable.h> -void* ptr; - class HiddenPointer { public: explicit HiddenPointer(size_t size = 256) { @@ -92,10 +90,12 @@ TEST(MemunreachableTest, stack) { } } +void* g_ptr; + TEST(MemunreachableTest, global) { HiddenPointer hidden_ptr; - ptr = hidden_ptr.Get(); + g_ptr = hidden_ptr.Get(); { UnreachableMemoryInfo info; @@ -104,7 +104,7 @@ TEST(MemunreachableTest, global) { ASSERT_EQ(0U, info.leaks.size()); } - ptr = NULL; + g_ptr = nullptr; { UnreachableMemoryInfo info; @@ -126,7 +126,7 @@ TEST(MemunreachableTest, global) { TEST(MemunreachableTest, tls) { HiddenPointer hidden_ptr; pthread_key_t key; - pthread_key_create(&key, NULL); + pthread_key_create(&key, nullptr); pthread_setspecific(key, hidden_ptr.Get()); |