diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2018-06-28 11:01:44 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-06-28 11:01:44 +0000 |
commit | 5f70ed6ee125f0e64b04aca7532c16962713d224 (patch) | |
tree | c5d3c4a5f52ae9ac43f937b18d4ecda22586c3a1 /libcutils | |
parent | 749ee86fafb521dfad17cac971beac0bb0e1e8b2 (diff) | |
parent | 4351bb05ad9fd5580aba7cd6a3dc2bc8c101c3a3 (diff) | |
download | system_core-5f70ed6ee125f0e64b04aca7532c16962713d224.tar.gz system_core-5f70ed6ee125f0e64b04aca7532c16962713d224.tar.bz2 system_core-5f70ed6ee125f0e64b04aca7532c16962713d224.zip |
Merge "libcutils: Simplify android_get_control_socket()"
Diffstat (limited to 'libcutils')
-rw-r--r-- | libcutils/sockets_unix.cpp | 24 |
1 files changed, 10 insertions, 14 deletions
diff --git a/libcutils/sockets_unix.cpp b/libcutils/sockets_unix.cpp index 2849aa886..0cb8a4dc5 100644 --- a/libcutils/sockets_unix.cpp +++ b/libcutils/sockets_unix.cpp @@ -32,10 +32,6 @@ #include "android_get_control_env.h" -#ifndef TEMP_FAILURE_RETRY -#define TEMP_FAILURE_RETRY(exp) (exp) // KISS implementation -#endif - #if defined(__ANDROID__) /* For the socket trust (credentials) check */ #include <private/android_filesystem_config.h> @@ -102,15 +98,15 @@ int android_get_control_socket(const char* name) { // Compare to UNIX domain socket name, must match! struct sockaddr_un addr; socklen_t addrlen = sizeof(addr); - int ret = TEMP_FAILURE_RETRY(getsockname(fd, (struct sockaddr *)&addr, &addrlen)); + int ret = getsockname(fd, (struct sockaddr*)&addr, &addrlen); if (ret < 0) return -1; - char *path = NULL; - if (asprintf(&path, ANDROID_SOCKET_DIR "/%s", name) < 0) return -1; - if (!path) return -1; - int cmp = strcmp(addr.sun_path, path); - free(path); - if (cmp != 0) return -1; - - // It is what we think it is - return fd; + + constexpr char prefix[] = ANDROID_SOCKET_DIR "/"; + constexpr size_t prefix_size = sizeof(prefix) - sizeof('\0'); + if ((strncmp(addr.sun_path, prefix, prefix_size) == 0) && + (strcmp(addr.sun_path + prefix_size, name) == 0)) { + // It is what we think it is + return fd; + } + return -1; } |