summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorWilliam Roberts <william.c.roberts@intel.com>2017-04-19 16:12:09 -0700
committerWilliam Roberts <william.c.roberts@intel.com>2017-04-19 17:21:44 -0700
commite6ec2661b73de1a3cfd184e37bf02bf9cd2e9c24 (patch)
treefae791f8b3cbd29fecab7dc6a06976418f83f133 /init
parent9401a0b9d196f8f87cce0dd8ae7499f8e05ce938 (diff)
downloadsystem_core-e6ec2661b73de1a3cfd184e37bf02bf9cd2e9c24.tar.gz
system_core-e6ec2661b73de1a3cfd184e37bf02bf9cd2e9c24.tar.bz2
system_core-e6ec2661b73de1a3cfd184e37bf02bf9cd2e9c24.zip
init: fix errno handling on KillProcessGroup
KillProcessGroup can return -1 without errno set, which produces error messages like this: init: Sending signal 15 to service 'vold' (pid 1806) process group... init: failed to kill 2 processes for processgroup 1806 init: killProcessGroup(0, 1806, 15) failed: Success Test: boot and reboot hikey. Change-Id: I51f242da234daee84795a3fbdffe9ad1f4567140 Signed-off-by: William Roberts <william.c.roberts@intel.com>
Diffstat (limited to 'init')
-rw-r--r--init/service.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/init/service.cpp b/init/service.cpp
index caf5785e5..c0745e340 100644
--- a/init/service.cpp
+++ b/init/service.cpp
@@ -217,7 +217,7 @@ void Service::KillProcessGroup(int signal) {
r = killProcessGroup(uid_, pid_, signal);
}
if (r == -1) {
- PLOG(ERROR) << "killProcessGroup(" << uid_ << ", " << pid_ << ", " << signal << ") failed";
+ LOG(ERROR) << "killProcessGroup(" << uid_ << ", " << pid_ << ", " << signal << ") failed";
}
if (kill(-pid_, signal) == -1) {
PLOG(ERROR) << "kill(" << pid_ << ", " << signal << ") failed";