diff options
author | Rahul Sabnis <rahulsabnis@google.com> | 2020-02-03 18:22:54 -0800 |
---|---|---|
committer | Rahul Sabnis <rahulsabnis@google.com> | 2020-02-10 11:16:49 -0800 |
commit | dcedd7d6f58bcb267d92dd35fec6a094086eab97 (patch) | |
tree | e8c524e2faad1145402873a11b4d19f96772bc1e /src | |
parent | 3c77bd3631cb2cef3e8b294d8625cb83bf8c0919 (diff) | |
download | packages_apps_Settings-dcedd7d6f58bcb267d92dd35fec6a094086eab97.tar.gz packages_apps_Settings-dcedd7d6f58bcb267d92dd35fec6a094086eab97.tar.bz2 packages_apps_Settings-dcedd7d6f58bcb267d92dd35fec6a094086eab97.zip |
Pass in active device to all BluetoothA2dp APIs in
packages/apps/Settings as null input is no longer supported
Bug: 147287141
Test: Manual
Change-Id: If43934374914c657080ffd0509f8095d988cc550
Diffstat (limited to 'src')
4 files changed, 15 insertions, 11 deletions
diff --git a/src/com/android/settings/development/AbstractBluetoothA2dpPreferenceController.java b/src/com/android/settings/development/AbstractBluetoothA2dpPreferenceController.java index 0f429c729f..128f4dae01 100644 --- a/src/com/android/settings/development/AbstractBluetoothA2dpPreferenceController.java +++ b/src/com/android/settings/development/AbstractBluetoothA2dpPreferenceController.java @@ -83,7 +83,7 @@ public abstract class AbstractBluetoothA2dpPreferenceController extends final BluetoothCodecConfig codecConfig = mBluetoothA2dpConfigStore.createCodecConfig(); synchronized (mBluetoothA2dpConfigStore) { if (mBluetoothA2dp != null) { - setCodecConfigPreference(null, codecConfig); // Use current active device + setCodecConfigPreference(mBluetoothA2dp.getActiveDevice(), codecConfig); } } // Because the setting is not persisted into permanent storage, we cannot call update state @@ -102,13 +102,14 @@ public abstract class AbstractBluetoothA2dpPreferenceController extends @Override public void updateState(Preference preference) { - if (getCodecConfig(null) == null || mPreference == null) { // Use current active device + BluetoothDevice activeDevice = mBluetoothA2dp.getActiveDevice(); + if (getCodecConfig(activeDevice) == null || mPreference == null) { return; } BluetoothCodecConfig codecConfig; synchronized (mBluetoothA2dpConfigStore) { - codecConfig = getCodecConfig(null); // Use current active device + codecConfig = getCodecConfig(activeDevice); } final int index = getCurrentA2dpSettingIndex(codecConfig); diff --git a/src/com/android/settings/development/bluetooth/AbstractBluetoothDialogPreferenceController.java b/src/com/android/settings/development/bluetooth/AbstractBluetoothDialogPreferenceController.java index 71907b6f9f..6f1eab04b5 100644 --- a/src/com/android/settings/development/bluetooth/AbstractBluetoothDialogPreferenceController.java +++ b/src/com/android/settings/development/bluetooth/AbstractBluetoothDialogPreferenceController.java @@ -80,7 +80,7 @@ public abstract class AbstractBluetoothDialogPreferenceController extends } writeConfigurationValues(index); final BluetoothCodecConfig codecConfig = mBluetoothA2dpConfigStore.createCodecConfig(); - bluetoothA2dp.setCodecConfigPreference(null, codecConfig); + bluetoothA2dp.setCodecConfigPreference(bluetoothA2dp.getActiveDevice(), codecConfig); mPreference.setSummary(((BaseBluetoothDialogPreference) mPreference).generateSummary( index)); } @@ -146,7 +146,8 @@ public abstract class AbstractBluetoothDialogPreferenceController extends if (bluetoothA2dp == null) { return null; } - final BluetoothCodecStatus codecStatus = bluetoothA2dp.getCodecStatus(null); + final BluetoothCodecStatus codecStatus = + bluetoothA2dp.getCodecStatus(bluetoothA2dp.getActiveDevice()); if (codecStatus == null) { Log.d(TAG, "Unable to get current codec config. Codec status is null"); return null; @@ -177,7 +178,8 @@ public abstract class AbstractBluetoothDialogPreferenceController extends * @return {@link BluetoothCodecConfig}. */ protected BluetoothCodecConfig getSelectableByCodecType(int codecTypeValue) { - final BluetoothCodecConfig[] configs = getSelectableConfigs(null); + final BluetoothCodecConfig[] configs = getSelectableConfigs( + mBluetoothA2dp.getActiveDevice()); if (configs == null) { Log.d(TAG, "Unable to get selectable config. Selectable configs is empty."); return null; diff --git a/src/com/android/settings/development/bluetooth/BluetoothCodecDialogPreferenceController.java b/src/com/android/settings/development/bluetooth/BluetoothCodecDialogPreferenceController.java index c2977a8681..8eecec939a 100644 --- a/src/com/android/settings/development/bluetooth/BluetoothCodecDialogPreferenceController.java +++ b/src/com/android/settings/development/bluetooth/BluetoothCodecDialogPreferenceController.java @@ -83,9 +83,9 @@ public class BluetoothCodecDialogPreferenceController extends return index; } // Check HD audio is enabled, display the available list. - if (bluetoothA2dp.getOptionalCodecsEnabled(activeDevice) + if (bluetoothA2dp.isOptionalCodecsEnabled(activeDevice) == BluetoothA2dp.OPTIONAL_CODECS_PREF_ENABLED) { - BluetoothCodecConfig[] configs = getSelectableConfigs(null); + BluetoothCodecConfig[] configs = getSelectableConfigs(bluetoothA2dp.getActiveDevice()); if (configs != null) { return getIndexFromConfig(configs); } @@ -101,7 +101,8 @@ public class BluetoothCodecDialogPreferenceController extends int codecPriorityValue = BluetoothCodecConfig.CODEC_PRIORITY_DEFAULT; switch (index) { case 0: - codecTypeValue = getHighestCodec(getSelectableConfigs(null)); + codecTypeValue = getHighestCodec(getSelectableConfigs( + mBluetoothA2dp.getActiveDevice())); codecPriorityValue = BluetoothCodecConfig.CODEC_PRIORITY_HIGHEST; break; case 1: diff --git a/src/com/android/settings/development/bluetooth/BluetoothHDAudioPreferenceController.java b/src/com/android/settings/development/bluetooth/BluetoothHDAudioPreferenceController.java index 80081886e3..714b9ab314 100644 --- a/src/com/android/settings/development/bluetooth/BluetoothHDAudioPreferenceController.java +++ b/src/com/android/settings/development/bluetooth/BluetoothHDAudioPreferenceController.java @@ -58,11 +58,11 @@ public class BluetoothHDAudioPreferenceController extends AbstractBluetoothPrefe mPreference.setEnabled(false); return; } - final boolean supported = (bluetoothA2dp.supportsOptionalCodecs(activeDevice) + final boolean supported = (bluetoothA2dp.isOptionalCodecsSupported(activeDevice) == BluetoothA2dp.OPTIONAL_CODECS_SUPPORTED); mPreference.setEnabled(supported); if (supported) { - final boolean isEnabled = bluetoothA2dp.getOptionalCodecsEnabled(activeDevice) + final boolean isEnabled = bluetoothA2dp.isOptionalCodecsEnabled(activeDevice) == BluetoothA2dp.OPTIONAL_CODECS_PREF_ENABLED; ((SwitchPreference) mPreference).setChecked(isEnabled); } |