diff options
author | Jan Tomljanovic <jtomljanovic@google.com> | 2021-04-27 20:58:12 +0100 |
---|---|---|
committer | Jan Tomljanovic <jtomljanovic@google.com> | 2021-04-29 17:38:52 +0100 |
commit | 07bffff45407aabbd670742c7240eec830b08b10 (patch) | |
tree | f65001327a31778d708e1b7d9d1f42f361f5076d /src | |
parent | 6be940f396e22abc5f93c4652e9eee17c8f28803 (diff) | |
download | packages_apps_Settings-07bffff45407aabbd670742c7240eec830b08b10.tar.gz packages_apps_Settings-07bffff45407aabbd670742c7240eec830b08b10.tar.bz2 packages_apps_Settings-07bffff45407aabbd670742c7240eec830b08b10.zip |
Launch SecurityHub fragment on SECURITY_SETTINGS intent when available.
Test: atest SettingsUnitTests
Test: adb shell am start -a android.settings.SECURITY_SETTINGS opens
SecurityHub screen (when SecurityHub enabled)
Test: assistant opens SecurityHub screen (when SecurityHub enabled) when
given instrucion to "open security settings"
Bug: 183930061
Change-Id: Ie8fcb2f2dce4cd0a2a84c6cd21a0a1c0b2b3665e
Diffstat (limited to 'src')
-rw-r--r-- | src/com/android/settings/Settings.java | 37 | ||||
-rw-r--r-- | src/com/android/settings/SettingsActivity.java | 10 |
2 files changed, 44 insertions, 3 deletions
diff --git a/src/com/android/settings/Settings.java b/src/com/android/settings/Settings.java index c89402cb2c..d28f86d079 100644 --- a/src/com/android/settings/Settings.java +++ b/src/com/android/settings/Settings.java @@ -19,11 +19,14 @@ package com.android.settings; import android.content.Context; import android.content.Intent; import android.os.Bundle; +import android.text.TextUtils; import android.util.FeatureFlagUtils; +import com.android.internal.annotations.VisibleForTesting; import com.android.settings.core.FeatureFlags; import com.android.settings.enterprise.EnterprisePrivacySettings; import com.android.settings.overlay.FeatureFactory; +import com.android.settings.security.SecuritySettingsFeatureProvider; /** * Top-level Settings activity @@ -118,7 +121,39 @@ public class Settings extends SettingsActivity { * Activity for Reduce Bright Colors. */ public static class ReduceBrightColorsSettingsActivity extends SettingsActivity { /* empty */ } - public static class SecurityDashboardActivity extends SettingsActivity { /* empty */ } + /** Activity for the security dashboard. */ + public static class SecurityDashboardActivity extends SettingsActivity { + + /** Whether the given fragment is allowed. */ + @VisibleForTesting + @Override + public boolean isValidFragment(String fragmentName) { + return super.isValidFragment(fragmentName) + || (fragmentName != null + && TextUtils.equals(fragmentName, getAlternativeFragmentName())); + } + + @Override + public String getInitialFragmentName(Intent intent) { + final String alternativeFragmentName = getAlternativeFragmentName(); + if (alternativeFragmentName != null) { + return alternativeFragmentName; + } + + return super.getInitialFragmentName(intent); + } + + private String getAlternativeFragmentName() { + String alternativeFragmentClassname = null; + final SecuritySettingsFeatureProvider securitySettingsFeatureProvider = + FeatureFactory.getFactory(this).getSecuritySettingsFeatureProvider(); + if (securitySettingsFeatureProvider.hasAlternativeSecuritySettingsFragment()) { + alternativeFragmentClassname = securitySettingsFeatureProvider + .getAlternativeSecuritySettingsFragmentClassname(); + } + return alternativeFragmentClassname; + } + } public static class UsageAccessSettingsActivity extends SettingsActivity { /* empty */ } public static class AppUsageAccessSettingsActivity extends SettingsActivity { /* empty */ } public static class LocationSettingsActivity extends SettingsActivity { /* empty */ } diff --git a/src/com/android/settings/SettingsActivity.java b/src/com/android/settings/SettingsActivity.java index b6729179d1..923c2bd719 100644 --- a/src/com/android/settings/SettingsActivity.java +++ b/src/com/android/settings/SettingsActivity.java @@ -219,7 +219,7 @@ public class SettingsActivity extends SettingsBaseActivity private String getMetricsTag() { String tag = null; if (getIntent() != null && getIntent().hasExtra(EXTRA_SHOW_FRAGMENT)) { - tag = getIntent().getStringExtra(EXTRA_SHOW_FRAGMENT); + tag = getInitialFragmentName(getIntent()); } if (TextUtils.isEmpty(tag)) { Log.w(LOG_TAG, "MetricsTag is invalid " + tag); @@ -262,7 +262,7 @@ public class SettingsActivity extends SettingsBaseActivity } // Getting Intent properties can only be done after the super.onCreate(...) - final String initialFragmentName = intent.getStringExtra(EXTRA_SHOW_FRAGMENT); + final String initialFragmentName = getInitialFragmentName(intent); // This is a "Sub Settings" when: // - this is a real SubSettings @@ -363,6 +363,12 @@ public class SettingsActivity extends SettingsBaseActivity } } + /** Returns the initial fragment name that the activity will launch. */ + @VisibleForTesting + public String getInitialFragmentName(Intent intent) { + return intent.getStringExtra(EXTRA_SHOW_FRAGMENT); + } + @Override protected void onApplyThemeResource(Theme theme, int resid, boolean first) { theme.applyStyle(R.style.SetupWizardPartnerResource, true); |